1006830 - Tarako user agent says 28.0 not 28.1

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Runtime, defect)

Description

[Wil Clouser [:clouserw]]

Attachment: settings page

Over in bug 987450 we changed the Gecko Version to 28.1 so that Tarako could be detected via the User Agent on our sites (namely, the Marketplace).

If you look at the Platform Version in the settings of the phone we see "28.1" as expected, but when looking at the User Agent on a website we see 28.0.  Attaching screenshots.

I'm marking this as 1.3T? because, as far as I know, the primary reason for having a 28.1 was the UA detection.

Comment 1

[Wil Clouser [:clouserw]]

Attachment: user agent screenshots

Comment 3

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

We'll want this change.  It will help post market if we should try to get other webpages to tune more for the tarako device like facebook and twitter and I think there will be little risk in a patch for this.

Comment 4

[(no longer active)]

The app version comes from <http://mxr.mozilla.org/mozilla-central/source/netwerk/protocol/http/nsHttpHandler.cpp#281>.  MOZILLA_UA_VERSION is set here <http://mxr.mozilla.org/mozilla-central/source/js/src/configure.in#240>, which is set in <http://mxr.mozilla.org/mozilla-b2g28_v1_3/source/config/milestone.pl#77>.  Note the comment there, the patch level is intentionally hidden in the UA string.

Comment 5

[(no longer active)]

Attachment: Show the patch level in the UA string for 1.3t; r=fabrice

This restores the code which was removed in bug 870868.

Comment 6

[Masatoshi Kimura [:emk]]

Do we expose the detectable UA to the world? Why don't you use the site-override like bug 988725?

Comment 7

[[:fabrice] Fabrice Desré]

Comment on attachment 8418483 [details] [diff] [review]
Show the patch level in the UA string for 1.3t; r=fabrice

Review of attachment 8418483 [details] [diff] [review]:
-----------------------------------------------------------------

I was about to ask you to review the same patch ;)

Comment 8

[[:fabrice] Fabrice Desré]

(In reply to Masatoshi Kimura [:emk] from comment #6)
> Do we expose the detectable UA to the world? Why don't you use the
> site-override like bug 988725?

Yes we expose that to the world.

Comment 9

[Joe Cheng [:jcheng] (please needinfo)]

in general i agree with all the previous comments to plus this bug for tarako
Since i am not very familiar with the impact of changing User Agent, ni? Lawrence Mandel for final input before plusing

Comment 10

[(no longer active)]

I don't know what the landing rules for 1.3t are, but please land this patch *only* on 1.3t and on no other branches.  Thanks!

Comment 11

[[:fabrice] Fabrice Desré]

 https://hg.mozilla.org/releases/mozilla-b2g28_v1_3t/rev/06216419c171

Comment 12

[Lawrence Mandel [:lmandel] (use needinfo)]

I'm late to comment but agree with this change. We have precedent as we took the same action in B2G 1.1. (See [1] for reference.)

[1] https://developer.mozilla.org/en-US/docs/Gecko_user_agent_string_reference#Firefox_OS_version_number

Comment 13

[Montoya Clemmons (MClemmons)]

Verified that User Agent is displaying appropriately on the web on the latest 1.3T build. User navigated to http://whatsmyuseragent.com and the site displayed the following user agent:

User Agent: Mozilla/5.0 (Mobile; rv:28.1) Gecko/28.1 Firefox/28.1

1.3T Environmental Variables:
Device: Tarako 1.3T
BuildID: 20140602014001
Gaia: 335486c42498fa7a93c21e4d6121199728602ab8
Gecko: 55e4d83019e5
Version: 28.1
Firmware Version: sp6821a-gonk-4.0-5-12
User Agent: Mozilla/5.0 (Mobile; rv:28.1) Gecko/28.1 Firefox/28.1