1007006 - GCLI should allow commands to be generators

Status: RESOLVED FIXED

(DevTools :: General, defect)

Description

[Joe Walker [:jwalker]]

It's as easy as slapping a Task.spawn in a host.exec thing, and it means that we can function* in our commands.

Will probably land a fix in bug 975522 because it's close to a one-liner.

Comment 1

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Note that you can also just do

  ...
  exec: Task.async(function* () {
    ...
  }),
  ...

Comment 2

[Joe Walker [:jwalker]]

Attachment: 0001-Bug-1007006-Add-Task.spawn-support-to-GCLI-commands-.patch

The change to browser_gcli_fail.js is because when Task.spawn catches the exception, it rejects the promise with ex.getMessage() which means we get an added "Error: " in the output string.

Since this should work on the web there is a new host.exec() function which just executes the function on the web, but does a Task.spawn in Firefox.

Finally there was originally a badly named host.exec() before which really spawned a new task, so that is now called host.spawn.

Comment 3

[Carsten Book [:Tomcat]]

Hi,
could you provide a Try link. Suggestions for what to run if you haven't
yet can be found here:
https://wiki.mozilla.org/Sheriffing/How:To:Recommended_Try_Practices

Comment 4

[Joe Walker [:jwalker]]

https://tbpl.mozilla.org/?tree=Try&rev=ff52dfa2153d

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/634f240208f3

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/634f240208f3

Comment 7

[Girish Sharma [:Optimizer]]

Joel, I don't think so this bug can cause those regressions in any way. DevTools are not even loaded while running such suites.