1008225 - Remove fog / frost effect behind the menu bar on Windows 8

Status: VERIFIED FIXED

(Firefox :: Theme, defect, P4)

Description

[Dão Gottwald [:dao]]

From bug 1007229:

That fog was intended for aero glass. It made sense to keep it on Windows 8 as long as we couldn't adjust the text color depending on the frame color, but now not so much. It feels super alien on Windows 8.

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Was this fixed by bug 1184651?

Comment 3

[:Gijs (out for now; he/him)]

(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #2)
> Was this fixed by bug 1184651?

Nah, there's still a lighter frostness behind the menu bar on its own on win8. It's gone in win10, but not win8.

Comment 4

[Dão Gottwald [:dao]]

(In reply to :Gijs Kruitbosch from comment #3)
> (In reply to Jared Wein [:jaws] (please needinfo? me) from comment #2)
> > Was this fixed by bug 1184651?
> 
> Nah, there's still a lighter frostness behind the menu bar on its own on
> win8. It's gone in win10, but not win8.

But then bug 1235320 isn't a duplicate :/

Comment 5

[Dão Gottwald [:dao]]

Jared, you have a plan for how to approach this? You're sure this is a good candidate for a mentored bug?

Comment 6

[Jared Wein [:jaws] (please needinfo? me)]

I was planning to make this one of the penultimate bugs of the Outreach internship, but hesitated on changing the Points column since you had already put in "3" and I assumed you knew of a clear path forward based on that score. I was ready to put an 8 or 13 on it.

I was hoping that by the end of the internship, the intern will have enough experience to be willing to investigate what is necessary and not need as much hand-holding.

Comment 7

[Dão Gottwald [:dao]]

Attachment: move Aero Glass-specific rules from -moz-windows-compositor section to -moz-windows-glass section

Comment 8

[Florian Quèze [:florian]]

Comment on attachment 8778561 [details] [diff] [review]
move Aero Glass-specific rules from -moz-windows-compositor section to -moz-windows-glass section

Review of attachment 8778561 [details] [diff] [review]:
-----------------------------------------------------------------

Looks reasonable. I don't have access to test machines with the various versions of Windows, so my r+ here is more a sanity check by code inspection than a full review. That's probably enough though :).

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a1727a7c7f2f
move Aero Glass-specific rules from -moz-windows-compositor section to -moz-windows-glass section. r=florian

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/a1727a7c7f2f

Comment 11

[Azmina]

I have reproduced this bug with Nightly 32.0a1 (2014-05-09) on Windows 8.1 , 64 bit!
This Bug's fix is verified on Latest Nightly 51.0a1.

Build ID : 20160810030202
User Agent : Mozilla/5.0 (Windows NT 6.3; WOW64; rv:51.0) Gecko/20100101 Firefox/51.0

[bugday-20160810]

Comment 12

[Dão Gottwald [:dao]]

(In reply to azmina721 from comment #11)
> I have reproduced this bug with Nightly 32.0a1 (2014-05-09) on Windows 8.1 ,
> 64 bit!
> This Bug's fix is verified on Latest Nightly 51.0a1.
> 
> Build ID : 20160810030202
> User Agent : Mozilla/5.0 (Windows NT 6.3; WOW64; rv:51.0) Gecko/20100101
> Firefox/51.0
> 
> [bugday-20160810]

Thanks!

Comment 13

[Matthew N. [:MattN]]

Confirmed by Nightly screenshots too: https://screenshots.mattn.ca/compare/?oldProject=mozilla-central&oldRev=720b5d2c84d5b253d4dfde4897e13384dc97a46a&newProject=mozilla-central&newRev=6cf0089510fad8deb866136f5b92bbced9498447&filter=primaryUI

Comment 14

[Dão Gottwald [:dao]]

https://hg.mozilla.org/releases/mozilla-aurora/pushloghtml?changeset=6cd56350a895

Comment 15

[Cornel Ionce [:noni] [Hubs QA]]

Verified fixed on Windows 8.1 x64 using latest DevEdition 50.0a2, build ID 20160914004005.