1235320 - Remove the text-shadow from menu bar items without Aero glass

Status: VERIFIED FIXED

(Firefox :: Theme, defect, P4)

Description

[(Currently slow to respond) Philipp Sackl [:phlsa] (Firefox UX) please use needinfo]

The items in the menu bar on Windows have a text shadow applied to them. This is a legacy style from Windows 7 that looks out of place and is no longer needed on Windows 10, so let's remove it.

Comment 1

[:Gijs (he/him)]

Do you mean the glass/fog effect, or something else? See also bug 1008225.

Comment 2

[(Currently slow to respond) Philipp Sackl [:phlsa] (Firefox UX) please use needinfo]

I think I mean the same thing: putting this rule into a media query that excludes Windows 10 and 8:
https://dxr.mozilla.org/mozilla-central/source/browser/themes/windows/browser-aero.css#333

Comment 4

[Adolfo Jayme]

IMHO this is a duplicate of bug 1198538.

Comment 5

[:Gijs (he/him)]

(In reply to Adolfo Jayme from comment #4)
> IMHO this is a duplicate of bug 1198538.

That bug is about the highlight colors used in menus generally, which is different from the menubar having text shadow.

Comment 6

[Jared Wein [:jaws] (please needinfo? me)]

Katie, would you like to work on this next? See comment #2 for an approach to try.

Comment 7

[Katie Broida [:ktbee]]

Attachment: Removes menu bar text shadow

Thanks Jared, I've written this patch using a media query based on comment 2. I didn't include windows-xp in the query because I wasn't sure that the more recent versions of Firefox still support it (and I didn't see it accounted for anywhere else in browser-aero.css). If we need it however, I can add it in.

Comment 8

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8740244 [details] [diff] [review]
Removes menu bar text shadow

Review of attachment 8740244 [details] [diff] [review]:
-----------------------------------------------------------------

browser-aero.css is only included when the operating system is *not* Windows XP, which is why you didn't see XP referenced in browser-aero.css.

We actually have a large number of users still on Windows XP, so we'll want to keep supporting those users. However, this rule wasn't previously applied to Windows XP, so we shouldn't worry about adding it there now. This patch looks good, nice job!

Comment 9

[Jared Wein [:jaws] (please needinfo? me)]

I had meant to include a link showing where browser-aero.css gets included as part of comment #8. Here's the link: http://hg.mozilla.org/mozilla-central/annotate/21bf1af375c1/browser/themes/windows/browser.css#l2783

Comment 10

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/a79bc2230647

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/a79bc2230647

Comment 12

[Matthew N. [:MattN]]

Drive-by comment: This seems like a case where `@media (-moz-windows-glass)` is what was wanted as the shadow was due to glass IIRC (see also bug ). We should avoid `-moz-os-version` when we can do proper feature detection.

You can review the screenshots of the change that landed at https://screenshots.mattn.ca/compare/?oldProject=mozilla-central&oldRev=49d7fb650c9dde7cf6e4b2c7aa578a4a11e83f83&newProject=mozilla-central&newRev=564b225d553547fe4aa9a1039278f695c9507db9 and looking at the Windows 8 section. This change only affected all configurations showing the menubar (allToolbars) and with no lightweight theme (noLWT) which seems expected.

For clarity (since it was mentioned in comment 1) this only affected the text shadow, not the white rectangular frosting.