1022547 - Menu bar unreadable in High Contrast mode

Status: VERIFIED FIXED

(Firefox :: Theme, defect, P1)

Description

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Attachment: Screenshot

The main menu is basically unreadable in High Contrast mode, due to:
* Glass blur/text shadow effect
* Lack of contrast from color of text

See attached screenshot.

Comment 1

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Note: The submenus are fine.

Comment 3

[Dão Gottwald [:dao]]

Attachment: move rule for menu text color since it's wrong on Windows 8 and later where all themes use the compositor

Comment 4

[:Gijs (he/him)]

Comment on attachment 8780847 [details] [diff] [review]
move rule for menu text color since it's wrong on Windows 8 and later where all themes use the compositor

r=me

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e34ed28ec449
move rule for menu text color since it's wrong on Windows 8 and later where all themes use the compositor. r=gijs

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/e34ed28ec449

Comment 7

[Azmina]

I have reproduced this bug with Nightly 32.0a1 (2014-06-09) on Windows 8.1 , 64 bit! 

This Bug's fix is verified on Latest Nightly 51.0a1 .

Build ID : 20160816030459
User Agent : Mozilla/5.0 (Windows NT 6.3; WOW64; rv:51.0) Gecko/20100101 Firefox/51.0

[bugday-20160817]

Comment 8

[:Gijs (he/him)]

Thanks!

Comment 10

[jscher2000]

Windows 10 doesn't even have the odd glow effect, so it's pure black-on-black. 

I tried to use the patch in a user style in Firefox 48, but it didn't work, so I hard-coded the color. https://userstyles.org/styles/132146/menu-bar-on-high-contrast-windows-64-bit-firefox

Any chance of uplift for this bug?

Comment 11

[:Gijs (he/him)]

Per comment #10, feels like this could be uplifted to 50 relatively painlessly. It's too late for 49. Dão, would you agree?

Comment 12

[Dão Gottwald [:dao]]

Attachment: patch for uplift

Approval Request Comment

This is bug 1008225's and this bug's patch combined. Fixing bug 1008225 is a prerequisite for this one.

[Feature/regressing bug #]: high-contrast mode support
[User impact if declined]: unreadable menu bar
[Describe test coverage new/current, TreeHerder]: n/a
[Risks and why]: low. just moving around some CSS, baked on Nightly for almost a month
[String/UUID change made/needed]: none

Comment 13

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8789308 [details] [diff] [review]
patch for uplift

Fix was verified on Nightly, CSS only, low risk, Aurora50+

Comment 14

[Dão Gottwald [:dao]]

https://hg.mozilla.org/releases/mozilla-aurora/pushloghtml?changeset=6cd56350a895

Comment 15

[ithompson4]

[testday-20160909]

Verification of this fix FAILED. I was to reproduce this problem for Firefox 50.0a2.  I filed a new bug report 1301616 "Firefox Developer - Menu bar unreadable in High Contrast mode" that references this one.

Comment 16

[Dão Gottwald [:dao]]

It's possible that the dev edition theme needs another fix. However, this patch just landed a couple of hours ago on mozilla-aurora. Are you sure the build you were using had that patch?

Comment 17

[ithompson4]

I clicked on "What's New" for Firefox Developer Firefox 50.0a2 and got the following.

New

    Find in page now supports a mode to search for whole words only

    New preference for allowing Ctrl+Tab to cycle through tabs in recently used order

    Improved printing by using the Reader Mode

Changed

    Emoji for everyone! Firefox will use built-in Emoji on operating systems without native Emoji fonts (Windows 8.0 and lower and Linux)

    Use accel-(opt/alt)-r as the reader mode keyboard shortcut

 

Firefox 50 for developers
In This Article

    Changes for Web developers
        Developer Tools
        HTML
        CSS
        JavaScript
        Interfaces/APIs/DOM
            DOM & HTML DOM
            Canvas
            WebGL
            IndexedDB
            Service Workers
            WebRTC
            Web Audio API
            New APIs
            Others
        MathML
        SVG
        Audio/Video
    HTTP
    Networking
    Security
    Changes for add-on and Mozilla developers
        Interfaces
        XUL
        JavaScript code modules
        XPCOM
        Other
    See also
    Older versions 

Firefox 50, based on Gecko 50, will ship in November 2016. This article provides information about the changes in this release that will affect developers. Nightly builds of what will become Firefox 50 are currently available on the Developer Edition channel.
Note: Items listed here are tentatively slated for Firefox 50; however, they may be held for a future release if testing shows they're not ready by the time Firefox 50 is due to ship. Please keep an eye on this page to stay up to date on the plans for Firefox 50.

Changes for Web developers
Edit
Developer Tools

    Box model was moved into Computed side panel (bug 1247729).

HTML


    For compatibility purposes, the non-standard webkitdirectory attribute of the <input> element, as well as the property HTMLInputElement.webkitDirectory property, have been implemented (bug 1258489).
    The default style of <bdo> now has a unicode-bidi with the isolate-override value (bug 1249497).
    Setting the <track> element's src attribute now works correctly (bug 1281418).

CSS

    Border-radiused corner with dashed and dotted style is now rendered with specified style instead of solid style (bug 382721).
    The non-standard :-moz-full-screen-ancestor pseudo-class selector has been removed (bug 1199529).
    The box-sizing: padding-box has been removed, since it’s no longer a part of the spec and Firefox was the only major browser to implement it (bug 1166728).
    Our experimental implementation of mask-position now supports animation of this property (bug 1273804). It is still available only on Nightly.
    The three values isolate, isolate-override, and plaintext of the unicode-bidi have been unprefixed (bug 1141895).
    In quirk mode, the bullet of a list now inherit the size of the list, like in standard mode (bug 648331).
    Changed behavior of the :in-range and :out-of-range pseudo-classes to not match disabled or read-only inputs (bug 1264157).
    Unprefixed :any-link pseudo-class bug 843579.
    Implemented space value of border-image-repeat (bug 720531).

JavaScript

    The ES2015 Symbol.hasInstance property has been implemented (bug 1054906).
    The ES2017 Object.getOwnPropertyDescriptors() method has been implemented (bug 1245024).
    The behavior of \W in RegExp with unicode and ignoreCase flags is changed to match recent draft spec. Now it doesn't match to K, S, k, s, and KELVIN SIGN (U+212A), and LATIN SMALL LETTER LONG S (U+017F) (bug 1281739).

Interfaces/APIs/DOM
DOM & HTML DOM

    The HTMLInputElement.webkitdirectory property is now supported (bug 1258489).
    The once option for EventTarget.addEventListener() is now supported (bug 1287706).
    The non-standard and experimental method HTMLMediaElement.seekToNextFrame() now seeks to the next frame in the media asynchronously, rather than synchronously, and returns a Promise which resolves once the seek is complete.
    The implementation of HTMLTrackElement has been corrected to allow <track> elements to load resources even if not in a document (bug 871747).

Canvas

No change.
WebGL

    The EXT_shader_texture_lod WebGL extension has been implemented (bug 1111689).

IndexedDB

No change.
Service Workers

    The WindowClient.navigate() method has been implemented. This method lets you open a specified URL into a client window which is being controlled by the service worker (bug 1218148).

WebRTC

    Adding a track to a MediaStream now generates the addtrack event as described in the specification. The event is of type MediaStreamTrackEvent and is fired on the stream to which the track was added. You can use either MediaStream.addEventListener('addtrack', ...) or the MediaStream.onaddtrack property to handle "addtrack" events.
    The MediaStreamTrack interface now supports the ended event and the MediaStreamTrack.onended event handler.
    Firefox now supports the MediaStreamTrack.readyState property, which indicates whether the track is live or permanently ended.
    The MediaStreamTrack methods getConstraints() and getSettings() have been implemented; these let you get the most recently applied set of customized property constraints and the actual values of all of the track's constrainable properties, respectively. The accompanying data types have been documented as well.
    The RTCDataChannel.stream property has been removed. This was replaced with RTCDataChannel.id in Firefox 24, but was supported for backward compatibility. Please be sure to update your code to use the id property if you haven't done so yet.

Web Audio API

    The PannerNode interface now supports the 3D Cartesian space properties for the position (PannerNode.positionX, PannerNode.positionY, and PannerNode.positionZ) and directionality (PannerNode.orientationX, PannerNode.orientationY, PannerNode.orientationZ) of an audio source.
    The interface IIRFilterNode, which implements a general infinite impulse response (IIR) filter, has been implemented.

New APIs

No change.
Others

    XMLHttpRequest.getResponseHeader() and XMLHttpRequest.getAllResponseHeaders() now also return empty headers by default. This can be controlled via the preference network.http.keep_empty_response_headers_as_empty_string (bug 918721).
    The navigator.battery property, which has been deprecated since Firefox 43, is now obsolete and has been removed. Use the navigator.getBattery() method instead to get a battery Promise, which will resolve when the BatteryManager is available for use; the BatteryManager is passed into the fulfillment handler for the promise.

MathML

No change.
SVG

No change.
Audio/Video

    The AlignSetting enum (representing possible values for VTTCue.align) incorrectly previously included the value "middle" instead of "center". This has been corrected (bug 1276130).

HTTP
Edit

    The experimental (and deprecated) SPDY 3.1 is now disabled by default bug 1287132.
    Support for X-Content-Type-Options has been added (bug 471020).
    The cookie prefixes __Host- and __Secure- have been implemented. See Set-Cookie and bug 1283368.

Networking
Edit

    The ping attribute of <a> element now abides by the connect-src CSP 1.1 policy directive (bug 1100181).
    Support for the sandbox CSP directive has been added (bug 671389).

Security
Edit

No change.
Changes for add-on and Mozilla developers
Edit
Interfaces

No change.
XUL

No change.
JavaScript code modules

No change.
XPCOM

No change.
Other

No change.

Comment 18

[Dão Gottwald [:dao]]

The What's New page won't tell you whether your build contains the patch.

Comment 19

[Jared Wein [:jaws] (please needinfo? me)]

You can go to about:buildconfig and copy the line that starts with "Built from". That will allow us to know if it includes this fix.

Comment 20

[ithompson4]

Accessed about:buildconfig Firefox Developer Firefox 50.0a2 and got the following:



about:buildconfig
Source

Built from https://hg.mozilla.org/releases/mozilla-aurora/rev/7d3d4f307002cc8475800df191196b94999ffd0a
Build platform
target
x86_64-pc-mingw32
Build tools
Compiler 	Version 	Compiler flags
c:/builds/moz2_slave/m-aurora-w64-ntly-000000000000/build/src/vs2015u2/VC/bin/amd64/cl.EXE 	19.00.23918 	-TC -nologo -wd4091 -D_HAS_EXCEPTIONS=0 -W3 -Gy -Zc:inline -FS -wd4244 -wd4267 -wd4819 -we4553
c:/builds/moz2_slave/m-aurora-w64-ntly-000000000000/build/src/vs2015u2/VC/bin/amd64/cl.EXE 	19.00.23918 	-TP -nologo -wd5026 -wd5027 -Zc:sizedDealloc- -Zc:threadSafeInit- -wd4091 -wd4577 -D_HAS_EXCEPTIONS=0 -W3 -Gy -Zc:inline -FS -wd4251 -wd4244 -wd4267 -wd4345 -wd4351 -wd4800 -wd4819 -wd4595 -we4553 -GR- -Zi -GL -wd4624 -wd4952 -O1 -Oi -Oy
Configure options

'MOZILLABUILD=C:\mozilla-build' --host=x86_64-pc-mingw32 --target=x86_64-pc-mingw32 --enable-update-channel=aurora --enable-js-shell --enable-eme=+adobe WINDOWSSDKDIR=c:/builds/moz2_slave/m-aurora-w64-ntly-000000000000/build/src/vs2015u2/SDK --enable-rust RUSTC=c:/builds/moz2_slave/m-aurora-w64-ntly-000000000000/build/src/rustc/bin/rustc --enable-jemalloc --enable-crashreporter --enable-release --enable-verify-mar --enable-warnings-as-errors --with-branding=browser/branding/aurora --with-google-api-keyfile=/c/builds/gapi.data --with-google-oauth-api-keyfile=/c/builds/google-oauth-api.key --with-mozilla-api-keyfile=/c/builds/mozilla-desktop-geoloc-api.key

--------------------------------------------------------------------

author	Thomas Wisniewski <[e-mail]>
	Sun, 31 Jul 2016 13:44:50 -0400 (5 weeks ago)
changeset 333101 	7d3d4f307002
parent 333100 	8c26f35e08a3
child 333102 	312abfcd4ee3
push id	9996
push user	[e-mail]
push date	2016-09-08 04:21 +0000
treeherder	mozilla-aurora@7d3d4f307002 [default view] [failures only]
perfherder	[talos] [build metrics] [platform microbench] (compared to previous push)
reviewers	aswan, testonly
bugs	1283902
milestone	50.0a2

Comment 21

[Dão Gottwald [:dao]]

That build doesn't contain the patch.

Comment 23

[Md. Majedul islam]

I have reproduced this bug with Firefox nightly 32.0a1 (2014-06-09) on Windows 10, 64 Bit.

The Bug's fix is now verified on latest nightly 52.0a1 (2016-09-29).

Build ID 	20160929030426
User Agent     Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Firefox/52.0

[testday-30092016]

Comment 24

[Onek Jude]

On my platform it works just fine. im running firefox version 50.0 beta 7

On windows 7 - 64 bits