1008355 - Easter egg whimsycorn should spin on mousedown

Status: VERIFIED FIXED

(Firefox :: Menus, defect)

Description

[Madhava Enros [:madhava]]

It should do something different every couple of releases or so, but this would be a good start.

Comment 1

[Blake Winton (:bwinton) (:☕️)]

Attachment: whimsy

Comment 2

[Blake Winton (:bwinton) (:☕️)]

It might be nice to not have the flickering scrollbar, but I wasn't sure how to do it.
Madhava thinks it's already fixed.

Comment 3

[Dão Gottwald [:dao]]

I think at this point we're wiring so much dedicated code in panelUI.inc.xul/js for this that it becomes hard to justify this investment. It's not just the time it took you to write this patch and the time it will take to review it. This code (which doesn't seem self-contained at first glance) will also need to be maintained.

Comment 4

[Dão Gottwald [:dao]]

(In reply to Dão Gottwald [:dao] from comment #3)
> It's not just the time it took you to write this patch and the time it will
> take to review it. This code (which doesn't seem self-contained at first
> glance) will also need to be maintained.

And of course comment 2 isn't encouraging at all in this regard...

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Simplified patch (spins on the Y axis)

Comment 6

[Dão Gottwald [:dao]]

Comment on attachment 8420678 [details] [diff] [review]
Simplified patch (spins on the Y axis)

>+@keyframes rotate {

Please make this more self-contained by giving the animation a name that can be expected to remain unique.

Comment 7

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Patch v2

I added a whimsy prefix to the animation-names so they are guaranteed unique.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/84c572a9c878

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/84c572a9c878

Comment 10

[Jared Wein [:jaws] (please needinfo? me)]

Marco, can you please add this to the backlog?

Comment 11

[Marco Mucci [:MarcoM]]

Added to Iteration 32.2

Comment 12

[Catalin Varga [QA][:VarCat]]

I verified the bug using the following environment:

FF 32 Nightly
Build Id: 20140523030202
Os: Win 7 x64, Ubuntu 12.10 x32, Mac Os X 10.8.5