1008596 - No SeaMonkey 2.28a2 nightly aurora builds, likely due to wrong relbranches in client.py configuration

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, defect)

Description

[rsx11m]

The following issue is reported in both Windows and Mac OSX build logs (and likely would be seen on Linux if bug 983536 were fixed), thus no 2.28a2 builds are generated. Judging from how the bug manifests itself, this seems to be the same issue as bug 985964 which occurred after the last merge:

> updating cache /e/builds/slave/c-aurora-w32-ntly/build/objdir/config.cache
> creating ./config.status
> Reticulating splines...
> Traceback (most recent call last):
>   File "./config.status", line 908, in <module>
>     config_status(**args)
>   File "e:\builds\slave\c-aurora-w32-ntly\build\mozilla\python\mozbuild\mozbuild\config_status.py", line 148, in config_status
>     summary = the_backend.consume(definitions)
>   File "e:\builds\slave\c-aurora-w32-ntly\build\mozilla\python\mozbuild\mozbuild\backend\base.py", line 186, in consume
>     for obj in objs:
>   File "e:\builds\slave\c-aurora-w32-ntly\build\mozilla\python\mozbuild\mozbuild\frontend\emitter.py", line 106, in emit
>     objs = list(self.emit_from_sandbox(out))
>   File "e:\builds\slave\c-aurora-w32-ntly\build\mozilla\python\mozbuild\mozbuild\frontend\emitter.py", line 429, in emit_from_sandbox
>     sandbox['SRCDIR'])
> mozbuild.frontend.reader.SandboxValidationError: A jar.mn exists in e:/builds/slave/c-aurora-w32-ntly/build/mozilla/extensions/venkman/resources but it is not referenced in the corresponding moz.build file. Please define JAR_MANIFESTS in the moz.build file.
> *** Fix above errors and then restart with               "D:/mozilla-build/python27/python2.7.exe e:/builds/slave/c-aurora-w32-ntly/build/mozilla/build/pymake/pymake/../make.py -f client.mk build"

The following is seen in the Windows logs only:

> e:\builds\slave\c-aurora-w32-ntly\build\client.mk:350:0: command 'cd objdir &&  MAKE="D:/mozilla-build/python27/python2.7.exe e:/builds/slave/c-aurora-w32-ntly/build/mozilla/build/pymake/pymake/../make.py"  e:/builds/slave/c-aurora-w32-ntly/build/configure  \
>   || ( echo "*** Fix above errors and then restart with\
>                \"D:/mozilla-build/python27/python2.7.exe e:/builds/slave/c-aurora-w32-ntly/build/mozilla/build/pymake/pymake/../make.py -f client.mk build\"" && exit 1 )' failed, return code 1
> e:\builds\slave\c-aurora-w32-ntly\build\client.mk:362:0: command 'D:/mozilla-build/python27/python2.7.exe e:/builds/slave/c-aurora-w32-ntly/build/mozilla/build/pymake/pymake/../make.py -f e:/builds/slave/c-aurora-w32-ntly/build/client.mk configure' failed, return code 2
> configure: error: e:/builds/slave/c-aurora-w32-ntly/build/mozilla/configure failed for mozilla
> Traceback (most recent call last):
>   File "e:/builds/slave/c-aurora-w32-ntly/build/build/pymake/make.py", line 35, in <module>
>     main(sys.argv[1:])
>   File "e:/builds/slave/c-aurora-w32-ntly/build/build/pymake/make.py", line 32, in main
>     subprocess.check_call([sys.executable, PYMAKE] + args)
>   File "D:\mozilla-build\python27\lib\subprocess.py", line 511, in check_call
>     raise CalledProcessError(retcode, cmd)
> subprocess.CalledProcessError: Command '['D:\\mozilla-build\\python27\\python2.7.exe', 'e:\\builds\\slave\\c-aurora-w32-ntly\\build\\mozilla\\build\\pymake\\make.py', '-f', 'client.mk', 'build', 'MOZ_BUILD_DATE=20140510013001']' returned non-zero exit status 2
> program finished with exit code 1

Comment 1

[rsx11m]

(Quoting rsx11m from bug 985964 comment #7)
> So, this will have to be done after each merge now ...
... apparently yes, at least for this cycle.

> or is there some way to automate it?
Any ideas?

Comment 2

[rsx11m]

http://hg.mozilla.org/releases/comm-aurora/file/ebcaac24ae6e/client.py [AURORA_30_END] uses SEA2_26_RELBRANCH, yet http://hg.mozilla.org/releases/comm-aurora/file/6d6550f3e91a/client.py [AURORA_BASE_20140429] switched that back to SEA2_25_RELBRANCH. Why does that happen?

Anything that needs to be changed in the comm-central client.py definitions? Current definitions http://hg.mozilla.org/comm-central/file/27968692278f/client.py there show SEA2_25_RELBRANCH commented out. Would updating it there to 2_26 prevent flipping it back at the time of the next merge?

Comment 3

[Ian Neal]

Attachment: Patch for aurora [Checked in: Comment 6]

Change to SEA2_26_RELBRANCH

Comment 4

[Ian Neal]

Attachment: Patch for trunk [Checked in trunk: Comment 13]

Change to SEA2_26_RELBRANCH

Comment 5

[Ian Neal]

Comment on attachment 8420711 [details] [diff] [review]
Patch for aurora [Checked in: Comment 6]

[Approval Request Comment]
Regression caused by (bug #): 
User impact if declined: aurora cannot be built
Testing completed (on m-c, etc.): local tree
Risk to taking this patch (and alternatives if risky): none
String changes made by this patch: none

Comment 6

[Ian Neal]

Comment on attachment 8420711 [details] [diff] [review]
Patch for aurora [Checked in: Comment 6]

https://hg.mozilla.org/releases/comm-aurora/rev/525c829ab5fb
Checked in as a bustage fix, any review comments can be fixed as a followup.

Comment 7

[rsx11m]

The Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 SeaMonkey/2.28a2 nightly build looks good to me; I don't see any Mac OSX builds yet, but the acute bustage seems to be fixed (again).

Comment 8

[rsx11m]

Mac OSX builds are done now as well, so verified fixed as far as current aurora is concerned.

Comment 9

[Philip Chee]

Comment on attachment 8420711 [details] [diff] [review]
Patch for aurora [Checked in: Comment 6]

rs=aurora bustage fix

Comment 10

[Frank Wein [:mcsmurf]]

For reference: Chatzilla etc. branches were created here https://hg.mozilla.org/chatzilla/rev/2a50fb6c1691

Comment 11

[Frank Wein [:mcsmurf]]

Comment on attachment 8420711 [details] [diff] [review]
Patch for aurora [Checked in: Comment 6]

Looks fine to me, stealing review.

Comment 12

[Frank Wein [:mcsmurf]]

Comment on attachment 8420712 [details] [diff] [review]
Patch for trunk [Checked in trunk: Comment 13]

This is fine, too.

Comment 13

[Ian Neal]

Comment on attachment 8420712 [details] [diff] [review]
Patch for trunk [Checked in trunk: Comment 13]

https://hg.mozilla.org/comm-central/rev/68da72a28bb3

Comment 14

[rsx11m]

Needs to be verified for 2.29a2 after the next merge scheduled for June 10.