1009368 - [settings] Opening settings as an activity fails

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Description

[Jim Porter (:squib)]

I don't really have time to QA this at the moment, but it appears that on gaia/master, opening the settings app as an activity doesn't work. It worked as of 46878e54d551e25dc11f835139407a68cdf2b886.

To reproduce this, go to Settings -> Keyboards -> Built-in Keyboard and then try to hit the back button. Nothing happens.

Comment 1

[(inactive after 6/18) Alive Kuo [:alive]]

Regression from https://bugzilla.mozilla.org/show_bug.cgi?id=994533 ?

Comment 2

[Jim Porter (:squib)]

Possibly? Unless GitHub is reordering things, the only commits after 46878e... are for bug 973456 and bug 846909.

Comment 3

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

@Alive,

I just found the problem when bisecting : 

9866a25cab96cb2eab2a808d40da87b4aa68cc3a is the first bad commit
commit 9866a25cab96cb2eab2a808d40da87b4aa68cc3a
Author: Alive Kuo <[e-mail]>
Date:   Fri May 9 13:08:41 2014 +0800

    Bug 1007574 - Ready right away if screenshot is protecting the frame

Hope this can help you know the root cause better.

Comment 4

[(inactive after 6/18) Alive Kuo [:alive]]

Thanks, fixing

Comment 5

[(inactive after 6/18) Alive Kuo [:alive]]

The settings app seems to call postResult and makes window management to display the keyboard app again.
Another weird result from settings<->keyboard implementation..

Comment 6

[(inactive after 6/18) Alive Kuo [:alive]]

Attachment: https://github.com/mozilla-b2g/gaia/pull/19215

The root cause is settings app calls activity.postError when it found the panel name is not passed in the activity when keyboard invokes.
This is not a regression from screenshot ready check but a bug due to keyboard app change from long time ago to pretend to 'back to settings'.

Comment 7

[Jim Porter (:squib)]

Cool, now my tests in bug 960329 pass! Removing dependency...

Comment 8

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8422042 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/19215

Please try the following STR to see if anything regressed:

1. Launch keyboard settings from Settings
2. Go back
3. Press home key

Expected:

1. See home screen

Unexpected:

1. Either keyboard settings or settings being launched incorrectly at this point.

Comment 9

[(inactive after 6/18) Alive Kuo [:alive]]

(In reply to Tim Guan-tin Chien [:timdream] (MoCo-TPE) (please ni?) from comment #8)
> Comment on attachment 8422042 [details] [review]
> https://github.com/mozilla-b2g/gaia/pull/19215
> 
> Please try the following STR to see if anything regressed:
> 
> 1. Launch keyboard settings from Settings
> 2. Go back
> 3. Press home key
> 
> Expected:
> 
> 1. See home screen
> 
> Unexpected:
> 
> 1. Either keyboard settings or settings being launched incorrectly at this
> point.

Nothing regressed, merging.

Comment 10

[(inactive after 6/18) Alive Kuo [:alive]]

https://github.com/mozilla-b2g/gaia/commit/6d8e117f636da82608b6e0f751cf8c274e556d46

Comment 11

[Jim Porter (:squib)]

Strange... now I'm seeing that when you hit the "back" button from the keyboard settings, it seems to turn the settings page into a popup (sort of). The back button becomes an X instead...

There's got to be a way to tell the system to take us back to whatever app opened us. Maybe Haida allows this somehow? Any ideas?

Comment 12

[Arthur Chen [:arthurcc][inactive after 6/30]]

By specifying the target, settings app assumes that it is going to handle the activity but what we want is actually going back to the settings app. This issue is being tracked by bug 1016280.

Comment 13

[Arthur Chen [:arthurcc][inactive after 6/30]]

I meant specifying "section" instead of "target".