Closed Bug 1009379 Opened 10 years ago Closed 10 years ago

[Stingray] The naming of "AppEntryPoint" object in applications.js is inconsistent

Categories

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: lchang, Assigned: lchang)

References

Details

(Whiteboard: [FT:Stream3])

Attachments

(1 file)

46 bytes, text/x-github-pull-request
johnhu
: review+
GaryChen
: review+
Details | Review
In applications.js, we expose the "Application Entry Points" data in the form of 

{
  manifestURL: '',
  entry_point: '',
  name: ''
}

The variables "manifestURL" and "entry_point" are using different naming style.

I propose changing "entry_point" to "entryPoint" to make them consistent.
Attached file Pull Request 19193
Hi John and Gary, 

Would you mind reviewing this trivial patch? Thanks.
Attachment #8421622 - Flags: review?(johu)
Attachment #8421622 - Flags: review?(gchen)
Comment on attachment 8421622 [details] [review]
Pull Request 19193

r=garychen, looks good for me.
Attachment #8421622 - Flags: review?(gchen) → review+
Comment on attachment 8421622 [details] [review]
Pull Request 19193

Thanks for this patch.
Attachment #8421622 - Flags: review?(johu) → review+
merged in gaia master branch:
https://github.com/mozilla-b2g/gaia/commit/655a1eb2e9f5f155142560f7d1ebbada390776dc

Gary, John, Thanks!
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [FT:Stream3]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: