Note: There are a few cases of duplicates in user autocompletion which are being worked on.

[Flatfish] Set GAIA_DEVICE_TYPE for tablet distribution

RESOLVED FIXED in 2.0 S2 (23may)

Status

Firefox OS
General
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: dliang, Assigned: dliang)

Tracking

unspecified
2.0 S2 (23may)
ARM
Gonk (Firefox OS)
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
Due to Gaia will be remove the distribution_tablet folder, so we need to set GAIA_DEVICE_TYPE for correct distribution.
(Assignee)

Comment 1

3 years ago
Created attachment 8422334 [details]
pull request for bug 1010128.html
Attachment #8422334 - Flags: feedback?(kli)
(Assignee)

Updated

3 years ago
Assignee: nobody → dliang
Comment on attachment 8422334 [details]
pull request for bug 1010128.html

Marco, Now GAIA can support build for different distribution. We need to add "tablet" distribution for flatfish. Could you help to review this patch? Thanks!
Attachment #8422334 - Flags: review?(mchen)
Attachment #8422334 - Flags: feedback?(kli)
Attachment #8422334 - Flags: feedback+
Blocks: 996461

Comment 3

3 years ago
Comment on attachment 8422334 [details]
pull request for bug 1010128.html

Hi,

Is GAIA_DEVICE_TYPE a env variable or just a variable in make process?

I think it is for make process, could you just use "GAIA_DEVICE_TYPE := tablet"?
(ex: https://github.com/mozilla-b2g/device-helix/blob/master/full_helix.mk#L35)
Attachment #8422334 - Flags: review?(mchen)
(Assignee)

Comment 4

3 years ago
(In reply to Marco Chen [:mchen] from comment #3)
> Comment on attachment 8422334 [details]
> pull request for bug 1010128.html
> 
> Hi,
> 
> Is GAIA_DEVICE_TYPE a env variable or just a variable in make process?
> 
> I think it is for make process, could you just use "GAIA_DEVICE_TYPE :=
> tablet"?
> (ex:
> https://github.com/mozilla-b2g/device-helix/blob/master/full_helix.mk#L35)

It's just for make process, but GAIA_DEVICE_TYPE is checked in Makefile, not .mk file, the flag in full_flatfish.mk cannot be passed to gaia by "GAIA_DEVICE_TYPE := tablet".

Hi Gary,
Could you add some check in Android.mk to receive this gaia flag? The example as below:

./Android.mk:33:ifneq (,$(GAIA_DEV_PIXELS_PER_PX))
./Android.mk:34:GAIA_MAKE_FLAGS += GAIA_DEV_PIXELS_PER_PX=$(GAIA_DEV_PIXELS_PER_PX)

And then we can use GAIA_DEVICE_TYPE := tablet to follow the code style in .mk file.
Thanks,
Flags: needinfo?(gchen)
Danny, I think you are right. As I know gaia Makefile can't use compile flag from aosp build system, and need to export as an env variable. That's why I had feedback+ to your patch.

Comment 6

3 years ago
Hi Danny,

Yes, add new make flags from AOSP build system into GAIA_MAKE_FLAGS should be a generic way for passing into Gaia build system. And we already had an example from GAIA_DEV_PIXELS_PER_PX.
Blocks: 1012497
No longer blocks: 1012497
Depends on: 1012497
(In reply to Danny Liang [:dliang] from comment #4)
> (In reply to Marco Chen [:mchen] from comment #3)
> > Comment on attachment 8422334 [details]
> > pull request for bug 1010128.html
> > 
> > Hi,
> > 
> > Is GAIA_DEVICE_TYPE a env variable or just a variable in make process?
> > 
> > I think it is for make process, could you just use "GAIA_DEVICE_TYPE :=
> > tablet"?
> > (ex:
> > https://github.com/mozilla-b2g/device-helix/blob/master/full_helix.mk#L35)
> 
> It's just for make process, but GAIA_DEVICE_TYPE is checked in Makefile, not
> .mk file, the flag in full_flatfish.mk cannot be passed to gaia by
> "GAIA_DEVICE_TYPE := tablet".
> 
> Hi Gary,
> Could you add some check in Android.mk to receive this gaia flag? The
> example as below:
> 
> ./Android.mk:33:ifneq (,$(GAIA_DEV_PIXELS_PER_PX))
> ./Android.mk:34:GAIA_MAKE_FLAGS +=
> GAIA_DEV_PIXELS_PER_PX=$(GAIA_DEV_PIXELS_PER_PX)
> 
> And then we can use GAIA_DEVICE_TYPE := tablet to follow the code style in
> .mk file.
> Thanks,

Hi Danny,
   OK!!!
   I just send a patch and ask Marco and Yuren to review my patch.
   Please wait for landing that patch.
   Thanks.
(Assignee)

Comment 8

3 years ago
Comment on attachment 8422334 [details]
pull request for bug 1010128.html

I have modified the PR and please help to review it.
Attachment #8422334 - Flags: review?(mchen)

Comment 9

3 years ago
Comment on attachment 8422334 [details]
pull request for bug 1010128.html

Thanks for looking into tablet project.
Attachment #8422334 - Flags: review?(mchen) → review+
Flags: needinfo?(gchen)
(Assignee)

Updated

3 years ago
Keywords: checkin-needed
master: https://github.com/mozilla-b2g/device-flatfish/commit/9cc3935a9d7b56e089021f2cd65ba213fa1ea904
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 2.0 S2 (23may)
You need to log in before you can comment on or make changes to this bug.