1011031 - Project Editor: Reload file that has already been opened when changed on disk

Status: RESOLVED FIXED

(DevTools Graveyard :: WebIDE, defect)

Description

[Brian Grinstead [:bgrins]]

STR:
Open a file in itchpad
Edit the same file using a separate editor
Select a different file, then reselect the first in itchpad

Expected:
The new data from the file is loaded into the editor

Actual:
The original data is still in the editor

We don't want to overwrite editor content if the user is still editing a file, but if they've left and come back I think it is safe to reload from disk.

Comment 2

[Brian Grinstead [:bgrins]]

Attachment: file-change.patch

Most of the changes here are for tests (I've added a new one for detecting external changes and for the image editor plugin).  The code changes are to give editors support for their load() functions to be called more than once. 

Basically now it will reload the editor whenever selectShell is called.  A future optimization could be to only call load() if we have detected a file change in the meantime.  So, both (1) and (2) cause reloads, but we could add code to make just (1) reload.  This would be quite a bit easier when we have FS.watch.

1) open File A -> navigate to File B -> [some external app edits File A] -> navigate to File A -> Reload from disk
2) open File A -> navigate to File B -> navigate to File A -> Reload from disk

Pushed to try: https://tbpl.mozilla.org/?tree=Try&rev=843830f4e916

Comment 3

[Brian Grinstead [:bgrins]]

Attachment: file-change.patch

Looks like there is a leak on try in browser_projecteditor_editors_image.js - here is another patch with a couple of minor updates that maybe will take care of it.

Comment 4

[Brian Grinstead [:bgrins]]

Attachment: file-change.patch

OK, got the leak figured out: https://tbpl.mozilla.org/?tree=Try&rev=a4fd3ba46ddd

Comment 5

[Heather Arthur [:harth]]

Comment on attachment 8443955 [details] [diff] [review]
file-change.patch

Review of attachment 8443955 [details] [diff] [review]:
-----------------------------------------------------------------

Sublime will automatically reload from disk if you've saved the content of the editor, but if there's anything unsaved it'll ask you before overwriting with the disk contents. We should consider that.

Comment 6

[Brian Grinstead [:bgrins]]

(In reply to Heather Arthur [:harth] from comment #5)
> Comment on attachment 8443955 [details] [diff] [review]
> file-change.patch
> 
> Review of attachment 8443955 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Sublime will automatically reload from disk if you've saved the content of
> the editor, but if there's anything unsaved it'll ask you before overwriting
> with the disk contents. We should consider that.

Yeah, I like that idea.  I'll file a follow up.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/9c66bdf234e4

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/9c66bdf234e4