1011214 - H264 OMX encoder deadlocks on shutdown

Status: RESOLVED FIXED

(Core :: WebRTC: Audio/Video, defect)

Description

[Randell Jesup [:jesup] (needinfo me)]

Attachment: deadlock

This may well be the cause of the problems in bug 1003749, since with the patch I can make multiple calls without rebooting.

Alfredo, you should try this patch and see if the problem goes away. I'll note you told me that you saw the problem in pure gUM though, with no H264 encoder, so this may merely get rid of the "fails every time" aspect of that problem.

Comment 1

[John Lin [:jhlin][:jolin]]

Comment on attachment 8423390 [details] [diff] [review]
deadlock

Review of attachment 8423390 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM. Thanks!

Comment 2

[Randell Jesup [:jesup] (needinfo me)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c8e329647317

Comment 3

[Alfredo Yang (:alfredo)]

The normal "Hang up" is ok with this patch.
The bug is still there if you kill the tab directly. (without pressing hangout button)

Comment 4

[Randell Jesup [:jesup] (needinfo me)]

That may be (very likely is) a different bug about failure to release something; please file a bug on that issue.

Comment 5

[Alfredo Yang (:alfredo)]

Bug 1003749 has updated title "Can't consistently reopen audio device", that's the bug for this symptom.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/c8e329647317