Closed Bug 1011418 Opened 5 years ago Closed 5 years ago

[Dialer][Call Screen] In-app message should follow the visual refresh spec

Categories

(Firefox OS Graveyard :: Gaia::Dialer, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(feature-b2g:2.0, tracking-b2g:backlog, b2g-v2.0 fixed)

VERIFIED FIXED
2.0 S3 (6june)
feature-b2g 2.0
tracking-b2g backlog
Tracking Status
b2g-v2.0 --- fixed

People

(Reporter: gtorodelvalle, Assigned: pivanov)

References

Details

Attachments

(6 files)

The in-app message when a conference call participant leaves the conference does not conform to the visual refresh spec.

Please see current implementation and spec (SMS one) I'll attach in a sec.
I think it would look better if this toaster had the same background and color as the bottom of the screen (white translucent background and dark color).

Also, we use this toaster to display merge errors (could not add someone to a conference call for example). Could you verify that the style is properly applied to this message too?
Need-infoing Vicky regarding comment 3 ;-)
Flags: needinfo?(vpg)
The new appearance should also be applied to the "Unable to merge" message (please, see screenshot) shown when trying to start a conference call using a SIM which does not have this service enabled.
(In reply to Anthony Ricaud (:rik) from comment #3)
> I think it would look better if this toaster had the same background and
> color as the bottom of the screen (white translucent background and dark
> color).
> 
> Also, we use this toaster to display merge errors (could not add someone to
> a conference call for example). Could you verify that the style is properly
> applied to this message too?

Hi Anthony,

There's a reason why this in app message has that color, while in messaging everything is white, there's the need of calling out attention so the toaster is really effective in a darker color.
Flags: needinfo?(vpg)
Moreover, when we design an element we think about it in a wider context, the OS, we cannot think of a single instance of a single app, that's why it's called system and that same word is used to talk about the design, and common elements are part of it, all that set of elements that are able to function in different scenarios are called a design system. They relate to each other creating a dialogue stablished by the definition of a certain amount of parameters color, size, position and defining hierarchy between each other.

The repetition of this elements in a consistent way is what stablish patterns and leads the user towards a good experience.

And this is the reason why sometimes we have to compromise and use an element that might works well in all instances and not necesarily perfect in one of them.
Fair enough :)
blocking-b2g: --- → backlog
feature-b2g: --- → 2.0
No longer blocks: 951606
Depends on: 951606
Arnau: Germán said you were working on this as part of bug 963018. So assigning to you and marking it for this sprint. Let us know if you think this won't be possible.
Assignee: nobody → arnau
Target Milestone: --- → 2.0 S3 (6june)
Assignee: arnau → pivanov
Hey Vicky,
I can't test on my device now. What is the right font-weight? Regular or Light? because as you can see from this image on Desktop `light` version is more close to the spec?

P.S. The patch is with Regular font weight like in spec.
Attachment #8429547 - Flags: ui-review?(vpg)
Comment on attachment 8429547 [details]
Font Weight regular/light

Thanks Pavel. I think I would go for light. The regular weight should not be looking that fat though. It would be good to understand why is this happening.
Attachment #8429547 - Flags: ui-review?(vpg) → ui-review+
Attached image Shot from Device
Hey Vicky,
here are shots from real Device. Font weight `normal (400)` or `light (300)`? :)

Thanks in advance :)
Attachment #8429892 - Flags: ui-review?(vpg)
Comment on attachment 8429892 [details]
Shot from Device

+ to 300
Attachment #8429892 - Flags: ui-review?(vpg) → ui-review+
Attachment #8429550 - Flags: review?(etienne)
Attachment #8429550 - Flags: review?(etienne) → review?(anthony)
Thanks, Pavel and Etienne. Anthony is out through today so here's hoping he can pick this up soon!
Comment on attachment 8429550 [details] [review]
patch for Gaia/master

Good to go with one small comment on Github about -moz-box-sizing.
Attachment #8429550 - Flags: review?(anthony) → review+
Thanks :) 

Landed to master:
https://github.com/mozilla-b2g/gaia/commit/e5529986cc2018638d502a5040cd7d37130b5a23
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Tested and working
Hamachi
2.0
Gecko-7a31c32
Gaia-1bd6e89
Status: RESOLVED → VERIFIED
blocking-b2g: backlog → ---
You need to log in before you can comment on or make changes to this bug.