1011418 - [Dialer][Call Screen] In-app message should follow the visual refresh spec

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[Germán Toro del Valle (:gtorodelvalle)]

The in-app message when a conference call participant leaves the conference does not conform to the visual refresh spec.

Please see current implementation and spec (SMS one) I'll attach in a sec.

Comment 1

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: current_callscreen_conferencecall_number_leaving.png

Comment 2

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: Spec_SMS_MMS_in-appmessage.png

Comment 3

[Anthony Ricaud (:rik)]

I think it would look better if this toaster had the same background and color as the bottom of the screen (white translucent background and dark color).

Also, we use this toaster to display merge errors (could not add someone to a conference call for example). Could you verify that the style is properly applied to this message too?

Comment 4

[Germán Toro del Valle (:gtorodelvalle)]

Need-infoing Vicky regarding comment 3 ;-)

Comment 5

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: callscreen_callwaiting_number_ongoing_unable_to_merge.png

The new appearance should also be applied to the "Unable to merge" message (please, see screenshot) shown when trying to start a conference call using a SIM which does not have this service enabled.

Comment 6

[Victoria Gerchinhoren [:vicky]]

(In reply to Anthony Ricaud (:rik) from comment #3)
> I think it would look better if this toaster had the same background and
> color as the bottom of the screen (white translucent background and dark
> color).
> 
> Also, we use this toaster to display merge errors (could not add someone to
> a conference call for example). Could you verify that the style is properly
> applied to this message too?

Hi Anthony,

There's a reason why this in app message has that color, while in messaging everything is white, there's the need of calling out attention so the toaster is really effective in a darker color.

Comment 7

[Victoria Gerchinhoren [:vicky]]

Moreover, when we design an element we think about it in a wider context, the OS, we cannot think of a single instance of a single app, that's why it's called system and that same word is used to talk about the design, and common elements are part of it, all that set of elements that are able to function in different scenarios are called a design system. They relate to each other creating a dialogue stablished by the definition of a certain amount of parameters color, size, position and defining hierarchy between each other.

The repetition of this elements in a consistent way is what stablish patterns and leads the user towards a good experience.

And this is the reason why sometimes we have to compromise and use an element that might works well in all instances and not necesarily perfect in one of them.

Comment 8

[Anthony Ricaud (:rik)]

Fair enough :)

Comment 9

[Anthony Ricaud (:rik)]

Arnau: Germán said you were working on this as part of bug 963018. So assigning to you and marking it for this sprint. Let us know if you think this won't be possible.

Comment 10

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Attachment: Font Weight regular/light

Hey Vicky,
I can't test on my device now. What is the right font-weight? Regular or Light? because as you can see from this image on Desktop `light` version is more close to the spec?

P.S. The patch is with Regular font weight like in spec.

Comment 11

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Attachment: patch for Gaia/master

Comment 12

[Victoria Gerchinhoren [:vicky]]

Comment on attachment 8429547 [details]
Font Weight regular/light

Thanks Pavel. I think I would go for light. The regular weight should not be looking that fat though. It would be good to understand why is this happening.

Comment 13

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Attachment: Shot from Device

Hey Vicky,
here are shots from real Device. Font weight `normal (400)` or `light (300)`? :)

Thanks in advance :)

Comment 14

[Victoria Gerchinhoren [:vicky]]

Comment on attachment 8429892 [details]
Shot from Device

+ to 300

Comment 15

[Stephany Wilkes]

Thanks, Pavel and Etienne. Anthony is out through today so here's hoping he can pick this up soon!

Comment 16

[Anthony Ricaud (:rik)]

Comment on attachment 8429550 [details] [review]
patch for Gaia/master

Good to go with one small comment on Github about -moz-box-sizing.

Comment 17

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Thanks :) 

Landed to master:
https://github.com/mozilla-b2g/gaia/commit/e5529986cc2018638d502a5040cd7d37130b5a23

Comment 18

[Loli (:lolimartinezcr)]

Tested and working
Hamachi
2.0
Gecko-7a31c32
Gaia-1bd6e89