951606 - [Dialer] Call screen visual refresh 2.0

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[Victoria Gerchinhoren [:vicky]]

Apply new Call screen design.

Comment 1

[Joe Cheng [:jcheng] (please needinfo)]

This is marked as MVP#1. 
Do we have more details on this?

Comment 2

[Maria Angeles Oteo (:oteo)]

A new reduced scope for v1.4 is going to be proposed within the Dialer meta bug 950760, please refer to it for the visual material.

Comment 3

[Victoria Gerchinhoren [:vicky]]

Clearing need info as the Visual designs are already posted in the Dialer meta bug which this one is blocking.

Comment 4

[Joe Cheng [:jcheng] (please needinfo)]

triage: move to 1.5? to be considered in the 1.5 vxd refresh

Comment 5

[Germán Toro del Valle (:gtorodelvalle)]

This bug will cover the following visuals:
 - attachment 8369917 [details]
 - attachment 8369921 [details]
 - attachment 8369924 [details]
 - attachment 8369925 [details]
 - attachment 8369926 [details]
 - attachment 8369927 [details]
 - attachment 8369928 [details]

Being the specs available at attachment 8370141 [details].

Comment 7

[Joe Cheng [:jcheng] (please needinfo)]

this is part of the visual refresh for 1.5

Comment 8

[Noemí Freire (:noemi)]

(In reply to gtorodelvalle from comment #5)
> This bug will cover the following visuals:
>  - attachment 8369917 [details]
>  - attachment 8369921 [details]
>  - attachment 8369924 [details]
>  - attachment 8369925 [details]
>  - attachment 8369926 [details]
>  - attachment 8369927 [details]
>  - attachment 8369928 [details]
> 
> Being the specs available at attachment 8370141 [details].

Notice that some visuals will be impacted by the feature being implemented as part of Bug 959011:
- Ongoing call: https://bug959011.bugzilla.mozilla.org/attachment.cgi?id=8393681
- Incoming call: https://bug959011.bugzilla.mozilla.org/attachment.cgi?id=8393683

Comment 9

[Germán Toro del Valle (:gtorodelvalle)]

FirefoxOS/Dialer/Call screen states: https://wiki.mozilla.org/FirefoxOS/Dialer/Call_screen_states

Comment 10

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: callscreen_contact_outgoing.png

Comment 11

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: callscreen_number_outgoing.png

Comment 12

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: callscreen_contact_connected.png

Comment 13

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: callscreen_contact_connected_button_active.png

Comment 14

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: callscreen_contact_connected_button_enabled.png

Comment 15

[Victoria Gerchinhoren [:vicky]]

Comment on attachment 8411890 [details]
callscreen_contact_connected.png

Wrong icon size to represent "dialpad" in keypad. You must be using the one corresponding to the tab bar, the correct icon should be bigger.

Comment 16

[Victoria Gerchinhoren [:vicky]]

Comment on attachment 8411886 [details]
callscreen_contact_outgoing.png

Wrong icon size to represent "dialpad" in keypad. You must be using the one corresponding to the tab bar, the correct icon should be bigger.

Comment 17

[Victoria Gerchinhoren [:vicky]]

Comment on attachment 8411905 [details]
callscreen_contact_connected_button_enabled.png

Wrong icon size to represent "dialpad" in keypad. You must be using the one corresponding to the tab bar, the correct icon should be bigger. 
Mute icon active color is ok though,

Comment 18

[Victoria Gerchinhoren [:vicky]]

Comment on attachment 8411903 [details]
callscreen_contact_connected_button_active.png

Icon in hitstate should be white.

Wrong icon size to represent "dialpad" in keypad. You must be using the one corresponding to the tab bar, the correct icon should be bigger.

Comment 19

[Victoria Gerchinhoren [:vicky]]

Comment on attachment 8411890 [details]
callscreen_contact_connected.png

Wrong icon size to represent "dialpad" in keypad. You must be using the one corresponding to the tab bar, the correct icon should be bigger.

Comment 20

[Victoria Gerchinhoren [:vicky]]

Comment on attachment 8411889 [details]
callscreen_number_outgoing.png

Upper panel where the number lives is too tall. Please refer to specs.

Wrong icon size to represent "dialpad" in keypad. You must be using the one corresponding to the tab bar, the correct icon should be bigger.

Comment 21

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: callscreen_contact_connected.png

Comment 22

[Victoria Gerchinhoren [:vicky]]

Correct icon is called: "actionicon_activecall_dialpad.png".

Comment 23

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: callscreen_contact_connected_button_enabled.png

Comment 24

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: callscreen_contact_connected_button_active.png

Comment 25

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: callscreen_contact_outgoing.png

Comment 26

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: callscreen_number_outgoing.png

Hi Vicky, if the panel where the phone number is located is not 10rem height (as it is when there is an associated contact), please tell us the right height. I have not been able to find the right value in bug 950760 's attachments.

Comment 27

[Germán Toro del Valle (:gtorodelvalle)]

Comment on attachment 8411889 [details]
callscreen_number_outgoing.png

Sorry I made as obsolete the wrong attachment ;)

Comment 28

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: callscreen_ended.png

Comment 29

[Victoria Gerchinhoren [:vicky]]

Comment on attachment 8411938 [details]
callscreen_number_outgoing.png

Drop shadow is missining in the icon next to "connecting".

Comment 30

[Victoria Gerchinhoren [:vicky]]

Comment on attachment 8411934 [details]
callscreen_contact_outgoing.png

Drop shadow is missining in the icon next to "connecting".

Comment 31

[Victoria Gerchinhoren [:vicky]]

Comment on attachment 8411930 [details]
callscreen_contact_connected_button_active.png

Drop shadow is missining in the icon next to "connecting".

Comment 32

[Victoria Gerchinhoren [:vicky]]

Comment on attachment 8411928 [details]
callscreen_contact_connected_button_enabled.png

Drop shadow is missining in the icon next to the timer.

Comment 33

[Victoria Gerchinhoren [:vicky]]

Comment on attachment 8411928 [details]
callscreen_contact_connected_button_enabled.png

Drop shadow is missining in the icon next to "connecting".

Comment 34

[Victoria Gerchinhoren [:vicky]]

Comment on attachment 8411930 [details]
callscreen_contact_connected_button_active.png

Drop shadow is missining in the icon next to the timer.

Comment 35

[Victoria Gerchinhoren [:vicky]]

Comment on attachment 8411934 [details]
callscreen_contact_outgoing.png

Drop shadow is missining in the icon next to "connecting".

Comment 36

[Victoria Gerchinhoren [:vicky]]

Comment on attachment 8411938 [details]
callscreen_number_outgoing.png

Drop shadow is missining in the icon next to "connecting".

Comment 37

[Victoria Gerchinhoren [:vicky]]

Comment on attachment 8411934 [details]
callscreen_contact_outgoing.png

Drop shadow is missing in the icon next to the "Connecting" word. This drop shadow should be the same as the one styled in the text.

Comment 38

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: callscreen_number_outgoing.png

Comment 39

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: callscreen_contact_outgoing.png

Comment 40

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: callscreen_contact_connected_button_active.png

Comment 41

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: callscreen_contact_connected_button_enabled.png

Comment 42

[Victoria Gerchinhoren [:vicky]]

Comment on attachment 8412571 [details]
callscreen_contact_connected_button_enabled.png

Can you put the dark overlay over the photo back?

Comment 43

[Victoria Gerchinhoren [:vicky]]

Comment on attachment 8412426 [details]
callscreen_ended.png

Hangup Icon has wrong position and size. Please use the size Pau told you.

Comment 44

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: callscreen_contact_connected_button_enabled.png

Comment 45

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: callscreen_contact_ended.png

Comment 46

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: callscreen_contact_ended.png

Comment 47

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: callscreen_contact_connected_keypad_visible.png

Comment 48

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: callscreen_contact_connected_keypad_visible_button_active.png

Comment 49

[Victoria Gerchinhoren [:vicky]]

Comment on attachment 8413661 [details]
callscreen_contact_connected_keypad_visible_button_active.png

"*" has an odd position. It should be moved up, please refer to specs: https://bug950760.bugzilla.mozilla.org/attachment.cgi?id=8410967

Moreover, this should be called "hit state" as that is just a feedback state and lasts less than a second.

Comment 50

[Victoria Gerchinhoren [:vicky]]

Comment on attachment 8413660 [details]
callscreen_contact_connected_keypad_visible.png

Same issue, the "*" should be moved up and the voicemail icon has been tweaked to match the letters weight (you can refer to the main dialer screen for the file)

Comment 51

[Victoria Gerchinhoren [:vicky]]

Due to the contrast ratio issue, colors have been adjusted. Please refer to the new mockups and specs in the metabug (https://bugzilla.mozilla.org/show_bug.cgi?id=950760) that will be uploaded within the next 24 hours.

Please change the colors and replace icons and ask for UI review again

Dialpad: Letters next to numbers are #038282
Replace active icons (turquoise ones are now with the new Hex value)
“Green” Button background should be #00adad
Dark overlay on top of the picture is #000000 and 40% opacity.

Comment 52

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: callscreen_number_connected_button_enabled.png

Comment 53

[Germán Toro del Valle (:gtorodelvalle)]

Taking into consideration the code dependencies amongst the distinct call screen cases (1 to 1 call, wall waiting and conference calls) we will centralise the bugs for the call waiting and conference call cases in this very bug.

On the other hand, I am going to mark as duplicate of this one the bugs related to the visual discrepancies since they are also covered and solved in this very bug.

Comment 60

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: callscreen_callwaiting_number_incoming.png

Please do not consider the weird text shown in the hold button which will be solved in bug 1002459 ;)

Comment 61

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: callscreen_callwaiting_number_connected.png

Comment 62

[Victoria Gerchinhoren [:vicky]]

Changes for
 
CONFERENCE CALL:
Dialpad: Letters next to numbers are #038282
Replace active icons (turquoise ones are now with the new Hex value)
“Green” Button background should be #00adad
Active call area background is #00adad
Active call area 2nd info line is #033B37

Thanks!

Comment 63

[Victoria Gerchinhoren [:vicky]]

Comment on attachment 8415240 [details]
callscreen_callwaiting_number_incoming.png

Put on hold button has a strange charachter there.

"Ignore call" button, should not have a gradient.

Number (606111032) from new call should be positioned in the middle of the area, please use this screenshot as reference: https://www.dropbox.com/s/tmzx9imse4h7mfu/2nd_call_0002_No-contact.png

thanks

Comment 64

[Victoria Gerchinhoren [:vicky]]

Comment on attachment 8415241 [details]
callscreen_callwaiting_number_connected.png

Timer should align with the baseline of the number.

Comment 65

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: callscreen_callwaiting_contact_connected.png

Comment 66

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: callscreen_callwaiting_contact_incoming.png

Please ignore the strange text shown on the "Hold" button since this has already been solved in master.

Comment 67

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: callscreen_callwaiting_number_incoming.png

Comment 68

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: callscreen_callwaiting_number_connected.png

Comment 72

[Victoria Gerchinhoren [:vicky]]

Comment on attachment 8417470 [details]
callscreen_callwaiting_number_incoming.png

Grey "Ignore call" Button should be #575757 (now it is #333333)

Comment 73

[Victoria Gerchinhoren [:vicky]]

Comment on attachment 8417438 [details]
callscreen_callwaiting_contact_incoming.png

Grey "Ignore call" Button should be #575757 (now it is #333333)

Comment 74

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: callscreen_callwaiting_number_incoming.png

Geez Vicky, you have a hell of an eye... :p

Comment 75

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: callscreen_callwaiting_contact_incoming.png

Comment 76

[Victoria Gerchinhoren [:vicky]]

Please change the solid 40% opacity dark overlay over the photo for a gradient from 40% black to 0% black. The aim of this overlay is to create legibility but the only information area where this is needed is the counter. So in order to lighten up the screen, dark area will only be the counter area. 

Example screen and spec to come in a few hours.

Thanks!

NI Paco to handle this.

Comment 77

[Pau Masiá [:Pau]]

Attachment: Visual Mockup. Call. Gradient overlay

Here I attach the mockups which show how the gradient overlay works.

Comment 78

[Pau Masiá [:Pau]]

Attachment: Visual Mockup. Gradient overlay. Light photo

Comment 79

[Pau Masiá [:Pau]]

Attachment: Visual Mockup. Gradient overlay. Dark photo

Comment 80

[Pau Masiá [:Pau]]

Attachment: Visual Spec. Call. Gradient overlay

Specs for gradient overlay. 
I have updated the opacity of the top color up to 50%.

Comment 81

[Germán Toro del Valle (:gtorodelvalle)]

Asking again for ui-review to validate the new overlay set ;-)

Comment 82

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: callscreen_contact_incoming.png

Comment 83

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: callscreen_contact_outgoing_connected.png

Comment 84

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: callscreen_callwaiting_contact_incoming.png

Comment 85

[Victoria Gerchinhoren [:vicky]]

Comment on attachment 8419427 [details]
callscreen_contact_outgoing_connected.png

Una lo-cura!

Comment 86

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: callscreen_callwaiting_contact_connected_1.png

Comment 87

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: callscreen_callwaiting_contact_connected_2.png

Comment 88

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: callscreen_conferencecall_connected.png

Comment 89

[Victoria Gerchinhoren [:vicky]]

Comment on attachment 8419436 [details]
callscreen_conferencecall_connected.png

Right arrow in the upper panel should be grey #575757

Comment 90

[Victoria Gerchinhoren [:vicky]]

Comment on attachment 8419428 [details]
callscreen_callwaiting_contact_incoming.png

"Ignore call" button should not have a gradient, should have a solid backgopund #575757

Comment 91

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: callscreen_callwaiting_contact_incoming.png

Comment 92

[Germán Toro del Valle (:gtorodelvalle)]

(In reply to Victoria Gerchinhoren [:vicky] from comment #89)
> Comment on attachment 8419436 [details]
> callscreen_conferencecall_connected.png
> 
> Right arrow in the upper panel should be grey #575757

Pau, we would need you to generate the requested icon, please. The one we are currently using is this one: https://github.com/mozilla-b2g/gaia/blob/master/apps/callscreen/style/images/proceed.png

On the other hand, Vicky, which icon would you like to show when the conference call is ended and the header is shown "in red".

Comment 93

[Pau Masiá [:Pau]]

Germán, I have uploaded a new zip with the new icon you asked me in the meta bug of Dialer. You can find it there with the following name "actionicon_callscreen_proceed.png"

Comment 94

[Germán Toro del Valle (:gtorodelvalle)]

Hi Carrie, would you be so kind to tell is if attachment 8419445 [details] is correct? This is, which photo should we show when there is a incoming call, the one of the established call or the one of the second incoming call?

Comment 95

[Noemí Freire (:noemi)]

(In reply to Germán Toro del Valle from comment #94)
> Hi Carrie, would you be so kind to tell is if attachment 8419445 [details]
> is correct? This is, which photo should we show when there is a incoming
> call, the one of the established call or the one of the second incoming call?

Regarding "https://mozilla.app.box.com/s/cpwxyeisjurklut93f0a/1/1030018334/9944055924/1" spec, page37(Call Waiting: Notification of Second Incoming Call), The photo appearing should be the one associated to the contact that user is currently talking to or device wallpaper in case of no having an associated photo. 
Anyway, I'll maintain Carrie ni flag since I'm not sure if there has been a change since then

Comment 96

[Germán Toro del Valle (:gtorodelvalle)]

The point is that this is something that there is in master right now so we should decide if filling a new bug to deal with it in master and then inherit that patch in the visual refresh of the Call Screen or dealing with it in this very bug.

Comment 97

[Noemí Freire (:noemi)]

(In reply to Germán Toro del Valle from comment #96)
> The point is that this is something that there is in master right now so we
> should decide if filling a new bug to deal with it in master and then
> inherit that patch in the visual refresh of the Call Screen or dealing with
> it in this very bug.

If finally needed, i'd suggest to handle it in a separate bug..., it is not a visual refresh related issue

Comment 98

[Germán Toro del Valle (:gtorodelvalle)]

In fact, I would definitely support dealing with that separate bug once the visual refresh of the Call Screen lands (this bug) because if not we are continuously delaying this visual refresh from landing because of issues that currently exist in master :-)

Comment 99

[Victoria Gerchinhoren [:vicky]]

(In reply to Germán Toro del Valle from comment #92)
> (In reply to Victoria Gerchinhoren [:vicky] from comment #89)
> > Comment on attachment 8419436 [details]
> > callscreen_conferencecall_connected.png
> > 
> > Right arrow in the upper panel should be grey #575757
> 
> Pau, we would need you to generate the requested icon, please. The one we
> are currently using is this one:
> https://github.com/mozilla-b2g/gaia/blob/master/apps/callscreen/style/images/
> proceed.png
> 
> On the other hand, Vicky, which icon would you like to show when the
> conference call is ended and the header is shown "in red".

Please use the hang up icon as specified here: https://bug950760.bugzilla.mozilla.org/attachment.cgi?id=8420050

Here's the mockup: https://bug950760.bugzilla.mozilla.org/attachment.cgi?id=8420048

Thanks.

Comment 100

[Victoria Gerchinhoren [:vicky]]

Comment on attachment 8419445 [details]
callscreen_callwaiting_contact_incoming.png

Visually OK. but the picture on the background should be from the contact of the active call and not the incomming one.

Giving a plus for the visual, but this should be solved funtionality wise.

Comment 101

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: callscreen_conferencecall_connected.png

Comment 102

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: callscreen_conferencecall_ended.png

Comment 103

[Victoria Gerchinhoren [:vicky]]

Comment on attachment 8420088 [details]
callscreen_conferencecall_connected.png

PLease move the icon 0.5 rem to the right so the icon lines up better.

Thanks!

Comment 104

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: callscreen_conferencecall_connected.png

Comment 105

[Carrie Wang [New account: [e-mail]]]

(In reply to Germán Toro del Valle from comment #94)
> Hi Carrie, would you be so kind to tell is if attachment 8419445 [details]
> is correct? This is, which photo should we show when there is a incoming
> call, the one of the established call or the one of the second incoming call?

Yes, that's the correct behavior. Thanks! It looks really nice with the visual refresh done! \o/

Comment 106

[Noemí Freire (:noemi)]

(In reply to Carrie Wang [PTO from 5/14 -23 ] [:carrie] from comment #105)
> (In reply to Germán Toro del Valle from comment #94)
> > Hi Carrie, would you be so kind to tell is if attachment 8419445 [details]
> > is correct? This is, which photo should we show when there is a incoming
> > call, the one of the established call or the one of the second incoming call?
> 
> Yes, that's the correct behavior. Thanks! It looks really nice with the
> visual refresh done! \o/

Just to be sure that the expected behavior is implemented, should we show the contact's photo corresponding to the active call or the one corresponding to the incoming call (the second call)?. Thanks!

Comment 107

[Victoria Gerchinhoren [:vicky]]

(In reply to Victoria Gerchinhoren [:vicky] from comment #100)
> Comment on attachment 8419445 [details]
> callscreen_callwaiting_contact_incoming.png
> 
> Visually OK. but the picture on the background should be from the contact of
> the active call and not the incomming one.
> 
> Giving a plus for the visual, but this should be solved funtionality wise.

Carrie, this comment is the one you need to confirm. Thanks.

Comment 108

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: callscreen_callwaiting_incoming_min_font_size.png

Comment 109

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: callscreen_callwaiting_connected_held_call_min_font_size.png

Comment 110

[Victoria Gerchinhoren [:vicky]]

Comment on attachment 8421610 [details]
callscreen_callwaiting_connected_held_call_min_font_size.png

+ but please extend the maximum width of the text area to be 2 rem separated from where time stamp should start.

Comment 112

[Germán Toro del Valle (:gtorodelvalle)]

Comment on attachment 8421610 [details]
callscreen_callwaiting_connected_held_call_min_font_size.png

Just so I do not forget fixing this once bug 1007709 lands ;-) Thanks Vicky!

Comment 113

[Germán Toro del Valle (:gtorodelvalle)]

Since a lot has happened since I asked for ui-review, I'll ask for it again for every screen ;-)

Comment 114

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: callscreen_singlecall_number_incoming_max_font_size.png

Comment 115

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: callscreen_singlecall_number_ongoing_max_font_size.png

Comment 116

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: callscreen_singlecall_number_ended_max_font_size.png

Comment 117

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: callscreen_singlecall_contact_incoming_max_font_size.png

Comment 118

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: callscreen_singlecall_contact_ongoing_max_font_size.png

Comment 119

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: callscreen_singlecall_contact_ended_max_font_size.png

Comment 120

[Carrie Wang [New account: [e-mail]]]

(In reply to Victoria Gerchinhoren [:vicky] from comment #107)
> (In reply to Victoria Gerchinhoren [:vicky] from comment #100)
> > Comment on attachment 8419445 [details]
> > callscreen_callwaiting_contact_incoming.png
> > 
> > Visually OK. but the picture on the background should be from the contact of
> > the active call and not the incomming one.
> > 
> > Giving a plus for the visual, but this should be solved funtionality wise.
> 
> Carrie, this comment is the one you need to confirm. Thanks.

Oooops, didn't figure out that is the photo of the incoming one. Yes, it should be the currently active one. Thanks!

Comment 121

[Noemí Freire (:noemi)]

Bug 1009596 already created to track the issue confirmed in comment 120. Thanks!

Comment 122

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: callscreen_singlecall_contact_incoming_min_font_size.png

Comment 123

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: callscreen_singlecall_contact_ongoing_min_font_size.png

Comment 124

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: callscreen_singlecall_contact_ended_min_font_size.png

Comment 126

[Victoria Gerchinhoren [:vicky]]

Comment on attachment 8421726 [details]
callscreen_singlecall_number_ended_max_font_size.png

ok. An icon re placement will take place in a different bug.(https://bugzilla.mozilla.org/show_bug.cgi?id=1008821)

Comment 127

[Victoria Gerchinhoren [:vicky]]

Comment on attachment 8421745 [details]
callscreen_singlecall_contact_ongoing_min_font_size.png

Can you please make the text's baseline the same in every size? Thanks!

Comment 128

[Victoria Gerchinhoren [:vicky]]

Comment on attachment 8421746 [details]
callscreen_singlecall_contact_ended_min_font_size.png

Can you please make the text's baseline the same in every size? Thanks!

Comment 129

[Victoria Gerchinhoren [:vicky]]

Comment on attachment 8421744 [details]
callscreen_singlecall_contact_incoming_min_font_size.png

Can you please make the text's baseline the same in every size? Thanks!

Comment 130

[Victoria Gerchinhoren [:vicky]]

Comment on attachment 8421744 [details]
callscreen_singlecall_contact_incoming_min_font_size.png

+ because the size is ok and the baseline issue will be solved in bug 1010104.

Comment 131

[Victoria Gerchinhoren [:vicky]]

Comment on attachment 8421745 [details]
callscreen_singlecall_contact_ongoing_min_font_size.png

+ because the size is ok and the baseline issue will be solved in bug 1010104.

Comment 132

[Victoria Gerchinhoren [:vicky]]

Comment on attachment 8421746 [details]
callscreen_singlecall_contact_ended_min_font_size.png

+ because the size is ok and the baseline issue will be solved in bug 1010104.

Comment 133

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: callscreen_callwaiting_number_incoming_fluid_font_size.png

Comment 134

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: callscreen_callwaiting_number_heldcall1_fluid_font_size.png

Comment 135

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: callscreen_callwaiting_number_heldcall2_fluid_font_size.png

Comment 136

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: callscreen_callwaiting_number_endedcall1_fluid_font_size.png

Comment 137

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: callscreen_callwaiting_number_endedcall2_fluid_font_size.png

Comment 138

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: callscreen_callwaiting_contact_incoming_fluid_font_size.png

Comment 139

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: callscreen_callwaiting_contact_heldcall1_fluid_font_size.png

Comment 140

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: callscreen_callwaiting_contact_heldcall2_fluid_font_size.png

Comment 141

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: callscreen_callwaiting_contact_endedcall1_fluid_font_size.png

Comment 142

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: callscreen_callwaiting_contact_endedcall2_fluid_font_size.png

Comment 143

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: callscreen_conferencecall_ongoing.png

Comment 144

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: callscreen_conferencecall_ongoing_number_participant_list.png

Comment 145

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: callscreen_conferencecall_ongoing_contact_participant_list.png

Comment 146

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: callscreen_conferencecall_number_leaving.png

Comment 147

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: callscreen_conferencecall_contact_leaving.png

Comment 148

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: callscreen_conferencecall_ended.png

Comment 149

[Victoria Gerchinhoren [:vicky]]

Comment on attachment 8422294 [details]
callscreen_callwaiting_number_heldcall1_fluid_font_size.png

Text size in white row is not correct, when having 2 calls on a screen, the normal size (max size) of it is smaller than the single call screen. PLease see specs for that.

Comment 150

[Victoria Gerchinhoren [:vicky]]

Comment on attachment 8422296 [details]
callscreen_callwaiting_number_heldcall2_fluid_font_size.png

Text size in white row is not correct, when having 2 calls on a screen, the normal size (max size) of it is smaller than the single call screen. PLease see specs for that.

Comment 151

[Victoria Gerchinhoren [:vicky]]

Comment on attachment 8422340 [details]
callscreen_conferencecall_ongoing_contact_participant_list.png

PLease, leave more space between the text and the icon, 2 rems would be ideal.

Comment 152

[Victoria Gerchinhoren [:vicky]]

Comment on attachment 8422341 [details]
callscreen_conferencecall_number_leaving.png

Max font size is too big, please follow spec.
"Group call" is cut before it should.

In app message should follow the new design as per specd here for messaging app: https://www.dropbox.com/s/s3g328f44b74j3x/Spec_SMS_MMS_in-appmessage.png

Comment 153

[Victoria Gerchinhoren [:vicky]]

Comment on attachment 8422343 [details]
callscreen_conferencecall_contact_leaving.png

In the upper panel the "call ended + time" is overlapping an arrow that shouldn't be there. 

 Max font size is too big, please follow spec.
"Group call" is cut before it should.

In app message should follow the new design as per specd here for messaging app: https://www.dropbox.com/s/s3g328f44b74j3x/Spec_SMS_MMS_in-appmessage.png

Comment 154

[Victoria Gerchinhoren [:vicky]]

Comment on attachment 8422338 [details]
callscreen_conferencecall_ongoing_number_participant_list.png

This screen is completely wrong. 

number should be in the middle of the row when there are not 2 lines of information. 

Dividers are single line, please check BB.
Last divider should not be there

Before the bottom area there's a full width line divider. Again, see BBs overlays.

Comment 155

[Victoria Gerchinhoren [:vicky]]

Comment on attachment 8422294 [details]
callscreen_callwaiting_number_heldcall1_fluid_font_size.png

Max size of text is too big. Please follow specs.

Comment 156

[Victoria Gerchinhoren [:vicky]]

Comment on attachment 8422311 [details]
callscreen_callwaiting_contact_endedcall2_fluid_font_size.png

Icon in call endend should be hang up.

Max size too big. Please follow specs

Comment 157

[Victoria Gerchinhoren [:vicky]]

Comment on attachment 8422309 [details]
callscreen_callwaiting_contact_endedcall1_fluid_font_size.png

Call ended should have hang up icon.

Max size too big. Please follow specs

Comment 158

[Victoria Gerchinhoren [:vicky]]

Comment on attachment 8422308 [details]
callscreen_callwaiting_contact_heldcall2_fluid_font_size.png


Max size too big. Please follow specs

Comment 159

[Victoria Gerchinhoren [:vicky]]

Comment on attachment 8422306 [details]
callscreen_callwaiting_contact_heldcall1_fluid_font_size.png


Max size too big. Please follow specs

Comment 160

[Victoria Gerchinhoren [:vicky]]

Comment on attachment 8422304 [details]
callscreen_callwaiting_contact_incoming_fluid_font_size.png

Baseline of upper panel text is wrong.

Bottom information panel's text is moved down and second line should not be bold, please check specs.

Comment 161

[Victoria Gerchinhoren [:vicky]]

Comment on attachment 8422300 [details]
callscreen_callwaiting_number_endedcall2_fluid_font_size.png

The correct icon is the Hang up one. 

Number and Call ended should have a 2rem gap in between.

Comment 162

[Victoria Gerchinhoren [:vicky]]

Comment on attachment 8422299 [details]
callscreen_callwaiting_number_endedcall1_fluid_font_size.png

Max font size too big. Please follow specs

Ended call icon should be hang up.

Comment 163

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: callscreen_singlecall_contact_ongoing_dialpad_visible.png

Comment 164

[Victoria Gerchinhoren [:vicky]]

Comment on attachment 8422471 [details]
callscreen_singlecall_contact_ongoing_dialpad_visible.png

The width of the hang up and dismiss keypad buttons is not correct. Check specs.

Comment 166

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: callscreen_callwaiting_number_heldcall1_fluid_font_size.png

Applying 2.5rem as the maximum font size and 2.3rem as the minimum one to the call waiting scenario ;-)

Comment 167

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: callscreen_callwaiting_number_heldcall2_fluid_font_size.png

Applying 2.5rem as the maximum font size and 2.3rem as the minimum one to the call waiting scenario ;-)

Comment 169

[Germán Toro del Valle (:gtorodelvalle)]

(In reply to Victoria Gerchinhoren [:vicky] from comment #151)
> Comment on attachment 8422340 [details]
> callscreen_conferencecall_ongoing_contact_participant_list.png
> 
> PLease, leave more space between the text and the icon, 2 rems would be
> ideal.

This issue will be solved in bug 977054. I'll set the ui-review for callscreen_conferencecall_ongoing_contact_participant_list.png (attachment 8422340 [details]) as blank so we know which screens/issues will not be solved in this bug. Thanks!

Comment 170

[Germán Toro del Valle (:gtorodelvalle)]

Comment on attachment 8422340 [details]
callscreen_conferencecall_ongoing_contact_participant_list.png

Will be solved in bug 977054 ;-)

Comment 171

[Germán Toro del Valle (:gtorodelvalle)]

Comment on attachment 8421745 [details]
callscreen_singlecall_contact_ongoing_min_font_size.png

Additional issues raised by Vicky will be solved in bug 1010104.

Comment 172

[Germán Toro del Valle (:gtorodelvalle)]

Comment on attachment 8421746 [details]
callscreen_singlecall_contact_ended_min_font_size.png

Additional issues raised by Vicky will be solved in bug 1010104.

Comment 173

[Germán Toro del Valle (:gtorodelvalle)]

(In reply to Victoria Gerchinhoren [:vicky] from comment #152)
> Comment on attachment 8422341 [details]
> callscreen_conferencecall_number_leaving.png
> 
> Max font size is too big, please follow spec.
> "Group call" is cut before it should.
> 
> In app message should follow the new design as per specd here for messaging
> app: https://www.dropbox.com/s/s3g328f44b74j3x/Spec_SMS_MMS_in-appmessage.png

I've solved the font size issue and created bug 1011418 to deal with the in-app message. Thanks!

Comment 174

[Germán Toro del Valle (:gtorodelvalle)]

Comment on attachment 8422341 [details]
callscreen_conferencecall_number_leaving.png

Setting the ui-review for callscreen_conferencecall_number_leaving.png (attachment 8422341 [details]) to blank to ease keeping track of the screen for which follow-up bugs have been created ;-)

Comment 175

[Victoria Gerchinhoren [:vicky]]

Comment on attachment 8423711 [details]
callscreen_callwaiting_number_heldcall1_fluid_font_size.png

Ahi vamos!

Comment 176

[Germán Toro del Valle (:gtorodelvalle)]

(In reply to Victoria Gerchinhoren [:vicky] from comment #153)
> Comment on attachment 8422343 [details]
> callscreen_conferencecall_contact_leaving.png
> 
> In the upper panel the "call ended + time" is overlapping an arrow that
> shouldn't be there. 
> 
>  Max font size is too big, please follow spec.
> "Group call" is cut before it should.
> 
> In app message should follow the new design as per specd here for messaging
> app: https://www.dropbox.com/s/s3g328f44b74j3x/Spec_SMS_MMS_in-appmessage.png

Icon issue and maximum font size solved. The in-app message issue will be solved in bug 1011418.

Comment 177

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: callscreen_conferencecall_contact_leaving.png

This is the final look of this screen regarding to the patch included in this bug. As I said in the previous comment, the in-app issue will be solved in callscreen_conferencecall_contact_leaving.png. Consequently, not asking for ui-review on this one to set it as pending work to be accomplished in an external bug.

Comment 178

[Germán Toro del Valle (:gtorodelvalle)]

(In reply to Victoria Gerchinhoren [:vicky] from comment #154)
> Comment on attachment 8422338 [details]
> callscreen_conferencecall_ongoing_number_participant_list.png
> 
> This screen is completely wrong. 
> 
> number should be in the middle of the row when there are not 2 lines of
> information. 
> 
> Dividers are single line, please check BB.
> Last divider should not be there
> 
> Before the bottom area there's a full width line divider. Again, see BBs
> overlays.

This participant list final and correct look will be implemented in bug 977054. So I'll leave the ui-review for this screen as blank.

Comment 179

[Germán Toro del Valle (:gtorodelvalle)]

Comment on attachment 8422338 [details]
callscreen_conferencecall_ongoing_number_participant_list.png

Setting the ui-review flag as blank since this screen will be correctly implemented in bug 977054.

Comment 180

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: callscreen_callwaiting_number_heldcall1_fluid_font_size.png

Comment 181

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: callscreen_callwaiting_contact_endedcall2_fluid_font_size.png

Comment 182

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: callscreen_callwaiting_contact_endedcall1_fluid_font_size.png

Comment 183

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: callscreen_callwaiting_contact_heldcall2_fluid_font_size.png

Comment 184

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: callscreen_callwaiting_contact_heldcall1_fluid_font_size.png

Comment 185

[Germán Toro del Valle (:gtorodelvalle)]

(In reply to Victoria Gerchinhoren [:vicky] from comment #160)
> Comment on attachment 8422304 [details]
> callscreen_callwaiting_contact_incoming_fluid_font_size.png
> 
> Baseline of upper panel text is wrong.
> 
> Bottom information panel's text is moved down and second line should not be
> bold, please check specs.

The baseline issue will be solved in bug 1010104.

The other issues have been solved. I'll upload a new screenshot in a sec. although I will not set the ui-review to mark that screen as work pending which will be implemented in an external bug.

Comment 186

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: callscreen_callwaiting_contact_incoming_fluid_font_size.png

The baseline issue will be solved in bug 1010104. Consequently not asking for further ui-review to mark this screen as work pending in an external bug.

Comment 187

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: callscreen_callwaiting_number_endedcall2_fluid_font_size.png

Comment 188

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: callscreen_callwaiting_number_endedcall1_fluid_font_size.png

Comment 189

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: callscreen_singlecall_contact_ongoing_dialpad_visible.png

Comment 190

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: callscreen_conferencecall_number_leaving.png

Uploading the latest version of this screen but not asking for ui-review since it has issues which will be solved in bug 1011418.

Comment 191

[Victoria Gerchinhoren [:vicky]]

Comment on attachment 8423877 [details]
callscreen_callwaiting_contact_endedcall1_fluid_font_size.png

Can you please change the row height to 8rem instead of 7.5? The specs are wrong, our bad, sorry.

Comment 192

[Victoria Gerchinhoren [:vicky]]

Comment on attachment 8423883 [details]
callscreen_callwaiting_contact_heldcall2_fluid_font_size.png

please fix the row height to 8rem.

Comment 193

[Victoria Gerchinhoren [:vicky]]

Comment on attachment 8423885 [details]
callscreen_callwaiting_contact_heldcall1_fluid_font_size.png

please fix the row height to 8rem.

Comment 194

[Victoria Gerchinhoren [:vicky]]

Comment on attachment 8423894 [details]
callscreen_callwaiting_number_endedcall2_fluid_font_size.png

please fix the row height to 8rem.

Comment 195

[Victoria Gerchinhoren [:vicky]]

Comment on attachment 8423897 [details]
callscreen_callwaiting_number_endedcall1_fluid_font_size.png

please fix the row height to 8rem.

Comment 196

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: callscreen_callwaiting_contact_endedcall1_fluid_font_size.png

New call waiting scenario row height set to 8 rems ;-)

Comment 197

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: callscreen_callwaiting_contact_heldcall2_fluid_font_size.png

New call waiting scenario call row height set to 8 rems ;-)

Comment 198

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: callscreen_callwaiting_contact_heldcall1_fluid_font_size.png

Call waiting scenario call row height set to 8 rems ;-)

Comment 199

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: callscreen_callwaiting_number_endedcall2_fluid_font_size.png

Call waiting scenario call row height set to 8 rems ;-)

Comment 200

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: callscreen_callwaiting_number_endedcall1_fluid_font_size.png

Call waiting scenario call row height set to 8 rems ;-)

Comment 201

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: callscreen_statusbar_number_outgoing_ongoing.png

Comment 202

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: callscreen_statusbar_number_incoming_ongoing_muted.png

Comment 203

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: callscreen_statusbar_contact_outgoing_ongoing.png

Comment 204

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: callscreen_statusbar_contact_outgoing_ongoing_muted.png

Comment 205

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: callscreen_statusbar_long_contact_incoming_ongoing.png

Comment 206

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: callscreen_statusbar_long_contact_incoming_ongoing_muted.png

Comment 207

[Victoria Gerchinhoren [:vicky]]

Comment on attachment 8424789 [details]
callscreen_statusbar_contact_outgoing_ongoing_muted.png

Please use #00adad for background color

Comment 208

[Victoria Gerchinhoren [:vicky]]

Comment on attachment 8424791 [details]
callscreen_statusbar_long_contact_incoming_ongoing_muted.png

Please use #00adad for background color

Comment 209

[Victoria Gerchinhoren [:vicky]]

Comment on attachment 8424788 [details]
callscreen_statusbar_contact_outgoing_ongoing.png

Please use #00adad for background color

Comment 210

[Victoria Gerchinhoren [:vicky]]

Comment on attachment 8424786 [details]
callscreen_statusbar_number_incoming_ongoing_muted.png

Please use #00adad for background color

Comment 211

[Victoria Gerchinhoren [:vicky]]

Comment on attachment 8424790 [details]
callscreen_statusbar_long_contact_incoming_ongoing.png

Please use #00adad for background color

Comment 212

[Victoria Gerchinhoren [:vicky]]

Comment on attachment 8424784 [details]
callscreen_statusbar_number_outgoing_ongoing.png

Please use #00adad for background color

Comment 213

[Victoria Gerchinhoren [:vicky]]

Comment on attachment 8424754 [details]
callscreen_callwaiting_contact_heldcall1_fluid_font_size.png

Second line of text in green row has a different color, please check specs.

Comment 214

[Victoria Gerchinhoren [:vicky]]

Comment on attachment 8424752 [details]
callscreen_callwaiting_contact_heldcall2_fluid_font_size.png

Second line of text in green row has a different color, please check specs.

Comment 215

[Victoria Gerchinhoren [:vicky]]

Comment on attachment 8424750 [details]
callscreen_callwaiting_contact_endedcall1_fluid_font_size.png

Second line of text in green row has a different color, please check specs.

Comment 216

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: callscreen_statusbar_contact_outgoing_ongoing_muted.png

Comment 217

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: callscreen_statusbar_long_contact_incoming_ongoing_muted.png

Comment 218

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: callscreen_statusbar_contact_outgoing_ongoing.png

Comment 219

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: callscreen_statusbar_contact_outgoing_ongoing_muted.png

Comment 220

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: callscreen_statusbar_number_incoming_ongoing_muted.png

Comment 221

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: callscreen_statusbar_number_incoming_ongoing.png

Comment 222

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: callscreen_statusbar_long_contact_incoming_ongoing.png

Comment 223

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: callscreen_statusbar_number_outgoing_ongoing.png

Comment 224

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: callscreen_callwaiting_contact_heldcall1_fluid_font_size.png

Comment 225

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: callscreen_callwaiting_contact_heldcall2_fluid_font_size.png

Comment 226

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: callscreen_callwaiting_contact_endedcall1_fluid_font_size.png

Comment 227

[Victoria Gerchinhoren [:vicky]]

Comment on attachment 8424843 [details]
callscreen_callwaiting_contact_endedcall1_fluid_font_size.png

PLease, align the baseline of the call duration with baseline of the 1st line os text in green row.

Comment 228

[Victoria Gerchinhoren [:vicky]]

Comment on attachment 8424839 [details]
callscreen_callwaiting_contact_heldcall1_fluid_font_size.png

align time baseline and 1st line of text in green row

Comment 229

[Germán Toro del Valle (:gtorodelvalle)]

(In reply to Victoria Gerchinhoren [:vicky] from comment #227)
> Comment on attachment 8424843 [details]
> callscreen_callwaiting_contact_endedcall1_fluid_font_size.png
> 
> PLease, align the baseline of the call duration with baseline of the 1st
> line os text in green row.

This issue will be implemented in bug 1010104 since it is highly related to the decisions made around the baseline issue.

Comment 230

[Germán Toro del Valle (:gtorodelvalle)]

(In reply to Victoria Gerchinhoren [:vicky] from comment #228)
> Comment on attachment 8424839 [details]
> callscreen_callwaiting_contact_heldcall1_fluid_font_size.png
> 
> align time baseline and 1st line of text in green row

This issue will be implemented in bug 1010104 since it is highly related to the decisions made around the baseline issue.

Comment 231

[Germán Toro del Valle (:gtorodelvalle)]

Comment on attachment 8424843 [details]
callscreen_callwaiting_contact_endedcall1_fluid_font_size.png

Vicky, if you are fine with implementing this request in bug 1010104, since it is highly related to the decisions made around the baseline issue, please set the ui-review as blank. Thanks!

Comment 232

[Germán Toro del Valle (:gtorodelvalle)]

Comment on attachment 8424839 [details]
callscreen_callwaiting_contact_heldcall1_fluid_font_size.png

Vicky, if you are fine with implementing this request in bug 1010104, since it is highly related to the decisions made around the baseline issue, please set the ui-review as blank. Thanks!

Comment 233

[Victoria Gerchinhoren [:vicky]]

Comment on attachment 8424828 [details]
callscreen_statusbar_number_incoming_ongoing_muted.png

Please use italics for the number / contact name (keep call duration in regular)

Comment 234

[Victoria Gerchinhoren [:vicky]]

Comment on attachment 8424832 [details]
callscreen_statusbar_long_contact_incoming_ongoing.png

Please use italics for the number / contact name (keep call duration in regular)

Comment 235

[Victoria Gerchinhoren [:vicky]]

Comment on attachment 8424833 [details]
callscreen_statusbar_number_outgoing_ongoing.png

Please use italics for the number / contact name (keep call duration in regular)

Comment 236

[Victoria Gerchinhoren [:vicky]]

Comment on attachment 8424829 [details]
callscreen_statusbar_number_incoming_ongoing.png

Please use italics for the number / contact name (keep call duration in regular)

Comment 237

[Victoria Gerchinhoren [:vicky]]

Comment on attachment 8424825 [details]
callscreen_statusbar_contact_outgoing_ongoing.png

Please use italics for the number / contact name (keep call duration in regular)

Comment 238

[Victoria Gerchinhoren [:vicky]]

Comment on attachment 8424824 [details]
callscreen_statusbar_long_contact_incoming_ongoing_muted.png

Please use italics for the number / contact name (keep call duration in regular)

Comment 239

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: callscreen_statusbar_number_incoming_ongoing_muted.png

Comment 240

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: callscreen_statusbar_long_contact_incoming_ongoing.png

Comment 241

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: callscreen_statusbar_number_outgoing_ongoing.png

Comment 242

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: callscreen_statusbar_number_incoming_ongoing.png

Comment 243

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: callscreen_statusbar_contact_outgoing_ongoing.png

Comment 244

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: callscreen_statusbar_long_contact_incoming_ongoing_muted.png

Comment 245

[Victoria Gerchinhoren [:vicky]]

Comment on attachment 8424843 [details]
callscreen_callwaiting_contact_endedcall1_fluid_font_size.png

Baseline issue should be addressed in bug 1010104

Comment 246

[Victoria Gerchinhoren [:vicky]]

Comment on attachment 8424839 [details]
callscreen_callwaiting_contact_heldcall1_fluid_font_size.png

Baseline issue should be addressed in bug 1010104

Comment 247

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: 19276.html

The mother of all pull requests is here... :-p

Comment 248

[Pau Masiá [:Pau]]

Attachment: Visual Mockup. Call. Gradient overlay

Comment 249

[Pau Masiá [:Pau]]

Attachment: Visual Mockup. Gradient overlay. Light photo

Comment 250

[Pau Masiá [:Pau]]

Attachment: Visual Mockup. Gradient overlay. Dark photo

Comment 251

[Pau Masiá [:Pau]]

Attachment: Visual Spec. Call. Gradient overlay

Comment 252

[Anthony Ricaud (:rik)]

Can you create two folders for the images? One for everything related to the call screen (action buttons like mute, speaker, place new call, keypad) and one for everything related to a handled call. If some images are used both by the callscreen ui and the handled call ui, you can create a third folder for those.

Comment 253

[Anthony Ricaud (:rik)]

I'm seeing issues in 2x density with the direction icon next to the duration, the direction icon in the 2nd incoming call and the merge icon.

Comment 254

[Anthony Ricaud (:rik)]

It seems like the lockscreen version is broken too.

Comment 255

[Anthony Ricaud (:rik)]

For the images, can you also create a directory for the ones used only in the status bar version?

Comment 256

[Anthony Ricaud (:rik)]

Comment on attachment 8424871 [details]
19276.html

I feel this is too big for one patch. We have some logic changes for the font sizes and some big big CSS changes that are not well tested. Therefore, I'd prefer landing the color/icon changes first and then fix the font issues.

Comment 257

[Anthony Ricaud (:rik)]

(In reply to Anthony Ricaud (:rik) from comment #254)
> It seems like the lockscreen version is broken too.
Ok, this is split into bug 951665. When we land this, we need to send a note to dev.gaia that the lockscreen will look weird for a few days. And put a screenshot in bug 951665 so that they can see what we mean exactly.

Comment 258

[Germán Toro del Valle (:gtorodelvalle)]

(In reply to Anthony Ricaud (:rik) from comment #252)
> Can you create two folders for the images? One for everything related to the
> call screen (action buttons like mute, speaker, place new call, keypad) and
> one for everything related to a handled call. If some images are used both
> by the callscreen ui and the handled call ui, you can create a third folder
> for those.

Done! In fact, I created 4 folders: call_screen, handled_call, lock_screen and shared. Already updated the PR including a new commit for you to track. We'll squash all the commits in one once you set the r+ ;-) Thanks!

Comment 259

[Germán Toro del Valle (:gtorodelvalle)]

(In reply to Anthony Ricaud (:rik) from comment #253)
> I'm seeing issues in 2x density with the direction icon next to the
> duration, the direction icon in the 2nd incoming call and the merge icon.

I'll comment this with Pau but could you provide further details regarding the issues you are noticing, please? Thanks!

Comment 260

[Germán Toro del Valle (:gtorodelvalle)]

(In reply to Anthony Ricaud (:rik) from comment #256)
> Comment on attachment 8424871 [details]
> 19276.html
> 
> I feel this is too big for one patch. We have some logic changes for the
> font sizes and some big big CSS changes that are not well tested. Therefore,
> I'd prefer landing the color/icon changes first and then fix the font issues.

Hi, I have also extracted the part of the patch regarding the adaptable font size for phone numbers and contact names. I will recover bug 1007709 which I marked as a duplicate of this one and we can include the patch there once the icons and style related issues land. Thanks!

Comment 261

[Germán Toro del Valle (:gtorodelvalle)]

bug 1007709 is no longer a duplicate of this bug. We'll manage its patch there ;-)

Comment 262

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: callscreen_singlecall_contact_hold.png

Hi Vicky! We found an scenario we were not applying the visual refresh to. It is the case when the ongoing call is set to on hold. I guess you would like to apply your magic touch to the resume button text color and weight (currently 700). Thanks!

Comment 263

[Germán Toro del Valle (:gtorodelvalle)]

In fact I have 2 additional doubts regarding comment 262 but I guess they are more for Carrie (or Omega during Carrie's PTO). Should the timer be stopped while the call is on hold? Should we set the icon status (direction) as paused instead as outgoing or incoming? Thanks!

Comment 264

[Victoria Gerchinhoren [:vicky]]

Comment on attachment 8427636 [details]
callscreen_singlecall_contact_hold.png

"Resume" button is wrong, it shouldcbe italic and not bold.
The icon next to timer should be the "on hold" one and oleas check the soecs for the text color and transparency details

Comment 265

[Germán Toro del Valle (:gtorodelvalle)]

(In reply to Victoria Gerchinhoren [:vicky] from comment #264)
> Comment on attachment 8427636 [details]
> callscreen_singlecall_contact_hold.png
> 
> "Resume" button is wrong, it shouldcbe italic and not bold.
> The icon next to timer should be the "on hold" one and oleas check the soecs
> for the text color and transparency details

Including the requested changes ;-)

Pau, could you check if the corresponding hold/paused icon has been generated and if not include it in the meta bug assets ZIP? It should be like actionicon_callscreen_outgoingcall.png or actionicon_callscreen_incomingcall.png. I found actionicon_activecall_hold.png but that one is a little bit "thicker" than the incoming and outgoing ones. In fact, I would say it should be just like actionicon_callscreen_pausedcall.png but in white (please check the color with Vicky in case it should not be white :) ). Thanks!

Comment 266

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: callscreen_singlecall_contact_held.png

In fact, I implemented using the icon I already had to check with Vicky if that is the desired color. Thanks!

Comment 267

[Victoria Gerchinhoren [:vicky]]

Comment on attachment 8427684 [details]
callscreen_singlecall_contact_held.png

The icon is good, so is the button, but the top panel should look different. Did you check the specs?

Comment 268

[Omega Feng [:Omega] [:馮於懋]]

ni? Carrie since she's back from PTO.

Comment 269

[Germán Toro del Valle (:gtorodelvalle)]

(In reply to Victoria Gerchinhoren [:vicky] from comment #267)
> Comment on attachment 8427684 [details]
> callscreen_singlecall_contact_held.png
> 
> The icon is good, so is the button, but the top panel should look different.
> Did you check the specs?

Hi Vicky. Do you mean regarding the fonts? If yes, you are right since Anthony asked me to extract the part of the patch which dealt with the adaptable font size for phone numbers and contact names. We will include it in bug 1007709. If you refer to other issues, please tell me because I do not recall further changes apart from the font size one. Thanks!

Comment 270

[Germán Toro del Valle (:gtorodelvalle)]

need-infoing Vicky regarding comment 269.

Comment 271

[Germán Toro del Valle (:gtorodelvalle)]

It seems we found and solved the bigger icon resolution issue pointed out by Anthony ;-)

Comment 272

[Germán Toro del Valle (:gtorodelvalle)]

Comment on attachment 8424871 [details]
19276.html

Hi Anthony, the patch is ready for the next review ;-) Thanks!

Comment 273

[Pau Masiá [:Pau]]

Germán, you can find the corresponding icon you have requested in the Assets Zip by the name of "actionicon_callscreen_pausedcall.png". It already has the new green color so it should be fine.

Thanks!

Comment 274

[Victoria Gerchinhoren [:vicky]]

(In reply to Germán Toro del Valle from comment #269)
> (In reply to Victoria Gerchinhoren [:vicky] from comment #267)
> > Comment on attachment 8427684 [details]
> > callscreen_singlecall_contact_held.png
> > 
> > The icon is good, so is the button, but the top panel should look different.
> > Did you check the specs?
> 
> Hi Vicky. Do you mean regarding the fonts? If yes, you are right since
> Anthony asked me to extract the part of the patch which dealt with the
> adaptable font size for phone numbers and contact names. We will include it
> in bug 1007709. If you refer to other issues, please tell me because I do
> not recall further changes apart from the font size one. Thanks!

Hi Germán. No, it is about how the upper panel is shown in the "on hold" scenario. The upper panel hould look different. Please find attached the spec.

Comment 275

[Victoria Gerchinhoren [:vicky]]

Here the spec: https://bug950760.bugzilla.mozilla.org/attachment.cgi?id=8428853

Thanks!

Comment 276

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: callscreen_singlecall_contact_held.png

Since there is a lot of information regarding the ui-review process in this bug and I expect this to be the last ui-review I'll ask for :-) , I decided to include the screenshot as a PNG. In forthcoming bugs, I'll include the screenshots in a single ZIP file if that is definitely the way to go ;-)

Comment 277

[Victoria Gerchinhoren [:vicky]]

Comment on attachment 8429170 [details]
callscreen_singlecall_contact_held.png

The text in the upper panel should have transparency, as please check specs.

Comment 278

[Anthony Ricaud (:rik)]

Comment on attachment 8424871 [details]
19276.html

In general, terrific job guys!

I left some small comments on github. The biggest one is the extra "overlay" element. I'd like to get rid of it, if possible.

Other than that, the _hitstate or _active versions of the icons should be merged into the sprite for each icon. This is because we don't want Gecko to decode an image when it tries to display the :active version of a button. Doing so would result in some lag on some devices.

In terms of naming, all icons are called "actionicon", even the ones that are not part of an action button (just providing information like the direction of the call). Is it possible to rename those?

This is a review- for tracking purposes but it's really close to a review+ !

Comment 279

[Carrie Wang [New account: [e-mail]]]

Hi Germán, 

I wonder how can we trigger the on-hold status for a single call? 
From the scenario of adding a call, the timer of the first call will stop while it's on-hold, but it will reset to 00:00 after resuming the call. I suppose the interaction here will be the same (but still need to double-confirm it by figuring out how can I trigger this use case). Thanks!

Comment 280

[Germán Toro del Valle (:gtorodelvalle)]

(In reply to Carrie Wang [:carrie] from comment #279)
> Hi Germán, 
> 
> I wonder how can we trigger the on-hold status for a single call? 
> From the scenario of adding a call, the timer of the first call will stop
> while it's on-hold, but it will reset to 00:00 after resuming the call. I
> suppose the interaction here will be the same (but still need to
> double-confirm it by figuring out how can I trigger this use case). Thanks!

Hi Carrie, I can force that state programmatically by setting the "connected-hold" status to the call but I don't really know the way to get to that state during a call. Mainly because the only way to put a call on hold I am aware of is via starting a second one and we wouldn't be in a single call scenario. I'll need-info Etienne to try to clarify this. Thanks!

Comment 281

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: callscreen_singlecall_contact_held.png

Comment 282

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: callscreen_singlecall_number_held.png

Comment 283

[Anthony Ricaud (:rik)]

Carrie: Germán: You can put a call on hold with a bluetooth device.

Comment 284

[Germán Toro del Valle (:gtorodelvalle)]

Hi Anthony,

(In reply to Anthony Ricaud (:rik) from comment #278)
> Comment on attachment 8424871 [details]
> 19276.html
> 
> In general, terrific job guys!
> 
> I left some small comments on github. The biggest one is the extra "overlay"
> element. I'd like to get rid of it, if possible.
> 

Giving a try to the box-shadow property and checking it with Vicky ;-)

> Other than that, the _hitstate or _active versions of the icons should be
> merged into the sprite for each icon. This is because we don't want Gecko to
> decode an image when it tries to display the :active version of a button.
> Doing so would result in some lag on some devices.
> 

OK, we'll use sprites for the buttons with these 3 states (normal, hit state and enabled).

> In terms of naming, all icons are called "actionicon", even the ones that
> are not part of an action button (just providing information like the
> direction of the call). Is it possible to rename those?
> 

Regarding the naming of the icons, it seems UX uses a nomenclature for them and they are not that fan of modifying the naming of the icons, mainly to track their versions and evolution. Maybe we could consider it for 2.1. Anyhow, I need-info Vicky to provide further details on this.

> This is a review- for tracking purposes but it's really close to a review+ !

Comment 285

[Germán Toro del Valle (:gtorodelvalle)]

Comment on attachment 8424871 [details]
19276.html

Hi Anthony, I think I have included all your suggestions. Thanks about that.

As you will see, I finally did not use the box-shadow option since it was not straightforward at all taking into consideration the current HTML element structure we have and all the scenarios we have to face (mainly regarding showing the phone number or the contact name and additional info). I opted for using a gradient as the background for the .duration element when the timer is shown in big.

Comment 286

[Victoria Gerchinhoren [:vicky]]

(In reply to Anthony Ricaud (:rik) (out until June 2nd) from comment #278)
Hi Rik, comments inline:

> I left some small comments on github. The biggest one is the extra "overlay"
> element. I'd like to get rid of it, if possible.
> 
This overlay should NOT be removed, it serves to legibility purposes. 

> In terms of naming, all icons are called "actionicon", even the ones that
> are not part of an action button (just providing information like the
> direction of the call). Is it possible to rename those?

we can remove the action icon name, but in general and for tracking purposes we should not rename icons. We're discussing the naming among the visual design team because I know they are too long right now, and will come up with a shorter naming, but ypu cannot put "contact-icon" as a name as it would be impossible to track it and discard the unused ones or replace for the new ones that will come in later versions. I'll take a look at the current names and propose a change for this specific ones.

Thanks!

Comment 287

[Germán Toro del Valle (:gtorodelvalle)]

Hi Vicky,

(In reply to Victoria Gerchinhoren [:vicky] from comment #286)
> (In reply to Anthony Ricaud (:rik) (out until June 2nd) from comment #278)
> Hi Rik, comments inline:
> 
> > I left some small comments on github. The biggest one is the extra "overlay"
> > element. I'd like to get rid of it, if possible.
> > 
> This overlay should NOT be removed, it serves to legibility purposes. 
>

No problem. I have kept it but implemented with no need of a new HTML element as suggested by Anthony ;)
 
> > In terms of naming, all icons are called "actionicon", even the ones that
> > are not part of an action button (just providing information like the
> > direction of the call). Is it possible to rename those?
> 
> we can remove the action icon name, but in general and for tracking purposes
> we should not rename icons. We're discussing the naming among the visual
> design team because I know they are too long right now, and will come up
> with a shorter naming, but ypu cannot put "contact-icon" as a name as it
> would be impossible to track it and discard the unused ones or replace for
> the new ones that will come in later versions. I'll take a look at the
> current names and propose a change for this specific ones.
> 
> Thanks!

Great! Maybe we could consider this renaming as a follow up of this bug not to block it if Anthony is also fine with it ;-) Thanks!

Comment 288

[Victoria Gerchinhoren [:vicky]]

Comment on attachment 8429942 [details]
callscreen_singlecall_number_held.png

please put the calling number the transparency mentioned in the spec.

Comment 289

[Victoria Gerchinhoren [:vicky]]

Comment on attachment 8429940 [details]
callscreen_singlecall_contact_held.png

Put the rtansparency mentioned on spec to the contact information text

Comment 290

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: callscreen_singlecall_contact_held.png

Comment 291

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: callscreen_singlecall_number_held.png

Comment 292

[Anthony Ricaud (:rik)]

Comment on attachment 8424871 [details]
19276.html

Good to go! http://ricaud.me/images/success-2.gif

Don't forget to squash when landing. Also, please wait for review+ for bug 951665 and land those two one after the other.

Comment 293

[Germán Toro del Valle (:gtorodelvalle)]

Merged in master: https://github.com/gtorodelvalle/gaia/commit/9b6df0c59f15dd20a3d0c29731b02f36fc5544c4

Thank you everyone involved for the awesome work! ;)

Comment 294

[Anthony Ricaud (:rik)]

The real merge commit is https://github.com/mozilla-b2g/gaia/commit/26d8fcab9b61f46451600f39c51e0387ef3c4f88

Comment 295

[Loli (:lolimartinezcr)]

With it i tested bugs: 1018891, 1018899 and 1018919. Please could somebody review this bugs? Thx

Comment 296

[Loli (:lolimartinezcr)]

(In reply to Loli from comment #295)
> With it i tested bugs: 1018891, 1018899 and 1018919. Please could somebody
> review this bugs? Thx

This bugs have been resolved to WFM, for this reason I change status to VERIFIED.

Hamachi
2.0
Gecko-7a31c32
Gaia-1bd6e89