1011498 - [Flame] Firefox logo on accounts signup page in FTE is cropped

Status: VERIFIED FIXED

(Firefox OS Graveyard :: FxA, defect, P2)

Description

[Kartikaya Gupta (email:[e-mail])]

Attachment: screenshot

I just did a local build and the Firefox logo in the FTE was cropped. I saw this when the FTE ran on startup but I also see it in the FTE if I trigger it from the developer menu. See attached screenshot.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

(My expectation is that the image isn't cropped horizontally, and that the right side of the firefox globe is visible)

Comment 3

[Jason Smith [:jsmith]]

Obviously we can't ship with a bug that shows our Firefox icon incorrectly.

Comment 4

[Sam Penrose]

No-Jun could you look at this one?

Comment 5

[No-Jun Park [:njpark]]

I can reproduce this in Flame, but on buri it appears fine.  Looks like the bigger screen caused the image to display incorrectly.

Version Info:
 Gaia      ef66efa34ed8a559c8998bde688fae88eb943a7a                         │
│ Gecko     https://hg.mozilla.org/mozilla-central/rev/b40296602083          │
│ BuildID   20140522040230                                                   │
│ Version   32.0a1                                                           │
│ ro.build.version.incremental=87                                            │
│ ro.build.date=Mon May  5 20:19:07 CST 2014

Comment 6

[Sam Penrose]

Thanks No-Jun. Jared, assigning to you and setting P2, both sort of by default. Feel free to redirect.

Comment 7

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Attachment: 5/29/14 screenshot - looks ok to me?

Can't repro on my Flame with latest pvt build / current gaia master. Mind taking another look, No-Jun?

Comment 8

[Jason Smith [:jsmith]]

(In reply to Jared Hirsch [:_6a68] [@6a68] from comment #7)
> Created attachment 8430998 [details]
> 5/29/14 screenshot - looks ok to me?
> 
> Can't repro on my Flame with latest pvt build / current gaia master. Mind
> taking another look, No-Jun?

That's not the screenshot I'm seeing on my device. I'm seeing what kats is seeing with the latest pvt build.

Comment 9

[Jason Smith [:jsmith]]

(In reply to Jason Smith [:jsmith] from comment #8)
> (In reply to Jared Hirsch [:_6a68] [@6a68] from comment #7)
> > Created attachment 8430998 [details]
> > 5/29/14 screenshot - looks ok to me?
> > 
> > Can't repro on my Flame with latest pvt build / current gaia master. Mind
> > taking another look, No-Jun?
> 
> That's not the screenshot I'm seeing on my device. I'm seeing what kats is
> seeing with the latest pvt build.

My guess is that you might building with incorrect DPI setting.

Comment 10

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Aha! Thanks Jason, I'll try now with GAIA_DEVICE_PIXELS_PER_PX=1.5

Comment 11

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

I've tried setting GAIA_DEVICE_PIXELS_PER_PX to 1.0, 1.5, 2.0, and 2.25, which covers all the sizes of assets I was given. The firefox logo looks the same to me in all cases on my Flame with this morning's pvtbuild.

Jason, any sense of what other factors might be at work? Or maybe this was a Gecko bug that's been fixed?

Also resetting ni? for No-Jun.

Comment 12

[Jason Smith [:jsmith]]

Looks like this got answered IRC. Let me know if you still can't reproduce with the latest Flame base image + 2.0.

Comment 13

[No-Jun Park [:njpark]]

turns out make reset-gaia was masking the issue.  Jared is investigating.

Comment 14

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Actually, I am wondering if there's something wrong with the pvt builds. Jason, any thoughts?

Comment 15

[Jason Smith [:jsmith]]

I don't know what the problem could be in a pvtbuild that would cause something like this.

Comment 16

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Thanks anyway. I found a CSS fix, opening a PR momentarily.

Comment 17

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Attachment: Github PR 19792

Comment 19

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Comment on attachment 8431154 [details] [review]
Github PR 19792

Hi Arthur and Fernando,

This is a tiny CSS patch, do you have time to take a look?

Thanks!

Jared

Comment 20

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8431154 [details] [review]
Github PR 19792

We should use a fixed size when available. Please check my comment in github, thanks.

Comment 22

[Arthur Chen [:arthurcc][inactive after 6/30]]

Just want to remind that there is the same issue in FTU.

Comment 26

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

OK, just so I don't forget *again* how to repro this, and lose *another* couple hours:

You can't do "GAIA_DEV_PIXELS_PER_PX=1.5 make install-gaia", it has to be "make GAIA_DEV_PIXELS_PER_PX=1.5 install-gaia". :-P

This is fixed on my flame, resubmitting momentarily.

Comment 27

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Comment on attachment 8431154 [details] [review]
Github PR 19792

Hi guys,

Tiny CSS patch updated. This blocks b2g and will need uplift, let me know if you can't review, and I'll find an alternate.

Thanks!

Jared

Comment 28

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8431154 [details] [review]
Github PR 19792

Looks good to me, thanks.

Comment 29

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Travis is green in my fork[1], merging.

Master: https://github.com/mozilla-b2g/gaia/commit/52f11078f1f92398a4bbc99ae102644ad12b1455

[1] https://travis-ci.org/6a68/gaia/builds/27714203

Comment 30

[Ryan VanderMeulen [:RyanVM]]

v2.0: https://github.com/mozilla-b2g/gaia/commit/faa91664e4757bf1509a8a9c76e2f189efbf7740

Comment 31

[Coler]

This issue has been verified successfully on Flame2.0&2.1.
Reproducing rate: 0/5
See attachment: Verify_Flame_Icon.mp4

Flame2.0 build version:
Gaia-Rev        8d1e868864c8a8f1e037685f0656d1da70d08c06
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/c756bd8bf3c3
Build-ID        20141130000204
Version         32.0

Flame2.1 build version:
Gaia-Rev        ccb49abe412c978a4045f0c75abff534372716c4
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/18fb67530b22
Build-ID        20141130001203
Version         34.0

Comment 32

[Coler]

Attachment: Verify_Flame_Icon.MP4