Closed Bug 1013537 Opened 6 years ago Closed 6 years ago

Implement animated translation icon for "Translation in Progress" infobar

Categories

(Firefox :: Translation, defect)

defect
Not set

Tracking

()

VERIFIED FIXED
Firefox 32

People

(Reporter: sevaan, Assigned: florian)

References

Details

(Whiteboard: [translation] p=2 s=it-32c-31a-30b.3 [qa!])

Attachments

(2 files)

The translation icon in the translation infobars should be animated when the "Translation in progress" infobar is displayed.
No longer blocks: 1011588
Depends on: 1011588
Flags: firefox-backlog+
Whiteboard: [translation] → [translation] p=0
Assignee: nobody → florian
Whiteboard: [translation] p=0 → [translation] p=2
Attached patch PatchSplinter Review
Note: the patch "doesn't work" on Mac because osx/browser.css doesn't include ../shared/translation/infobar.inc.css yet.

Including it now as is isn't really a good option because that breaks the sizing of the infobar and breaks the appearance of the buttons. I'm expecting this to be fixed by bug 988480.
Attachment #8427082 - Flags: review?(felipc)
Marco, could you please add this bug to the current iteration?
Flags: needinfo?(mmucci)
Added to Iteration 32.2
Status: NEW → ASSIGNED
Flags: needinfo?(mmucci)
Whiteboard: [translation] p=2 → [translation] p=2 s=it-32c-31a-30b.2 [qa?]
Attachment #8427082 - Flags: review?(felipc) → review+
https://hg.mozilla.org/mozilla-central/rev/43daa13856be
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 32
Note for QA: don't spend time verifying this on Mac, it's known to be broken on Mac until bug 988480 is fixed.
Hi Juan, can you review the bug to determine if further verification is required.
Flags: needinfo?(jbecerra)
Whiteboard: [translation] p=2 s=it-32c-31a-30b.2 [qa?] → [translation] p=2 s=it-32c-31a-30b.3 [qa?]
Flags: needinfo?(jbecerra)
QA Contact: bogdan.maris
Whiteboard: [translation] p=2 s=it-32c-31a-30b.3 [qa?] → [translation] p=2 s=it-32c-31a-30b.3 [qa+]
Verified on Windows 8.1 64bit and Ubuntu 13.04 64bit. Leaving [qa+] in whiteboard since I have to verify the fix on Mac OS X as well bug 988480 is fixed.
Verified on Mac OS X 10.9.3 as well using the revision from bug 988480.
Status: RESOLVED → VERIFIED
Whiteboard: [translation] p=2 s=it-32c-31a-30b.3 [qa+] → [translation] p=2 s=it-32c-31a-30b.3 [qa!]
You need to log in before you can comment on or make changes to this bug.