1013682 - A lot of wasted space after expanding folders in edit bookmark panel

Status: RESOLVED DUPLICATE of bug 1247824

(Firefox :: Theme, defect)

Description

[Sören Hentzschel]

Attachment: edit-bookmark-2.png

STR:

1. click the bookmark star icon
2. click the arrow to the right of "Folder"
3. click 'cancel' or 'done'
4. repeat steps 1 and 2
5. there is a lot of wasted space, see screenshot.

Tested with Firefox 29.0.1 Stable and Firefox 32.0a1 Nightly on Mac OS X 10.9.3.

Comment 1

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

this is an annoyance but doesn't break functionality. Would still be good to figure what happened here.

Comment 2

[[:Aleksej]]

WFM with firefox-29.0.1.ru.linux64.

Comment 3

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

yes, it's a Mac only bug

Comment 4

[u428464]

There is a similar issue with the clear history dialog on every platforms.

Comment 5

[Sören Hentzschel]

Attachment: screenshot

The identity panel is also affected.

Comment 6

[Sören Hentzschel]

And maybe related my older bug report bug 8390511.

Comment 7

[Sören Hentzschel]

Sorry for bug spamming, copy and paste error. :-( bug 983163 is my old bug report…

Comment 8

[Sören Hentzschel]

Last good revision: 178a4a770bb1 (2013-03-27)
First bad revision: 962f5293f87f (2013-03-28)
Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=178a4a770bb1&tochange=962f5293f87f

The issue described in bug 1013677 first appeared in the same range, bug 983163 is an older issue.

Comment 9

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

off-hand one related patch in the range may be Bug 852775

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Does this still reproduce for you, Sören?

Comment 11

[Sören Hentzschel]

Yes, it's still an issue.

Comment 12

[Stuart Philp :sphilp]

My mozregression results are the same as Sören's earlier results, the edit bookmark panel seems to have had this bug introduced around here:

 9:19.85 LOG: MainThread Bisector INFO Narrowed nightly regression window from [2013-03-27, 2013-03-29] (2 days) to [2013-03-27, 2013-03-28] (1 days) (~0 steps left)
 9:19.86 LOG: MainThread main INFO Got as far as we can go bisecting nightlies...
 9:19.86 LOG: MainThread Bisector INFO Last good revision: 178a4a770bb1
 9:19.86 LOG: MainThread Bisector INFO First bad revision: 962f5293f87f
 9:19.86 LOG: MainThread Bisector INFO Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=178a4a770bb1&tochange=962f5293f87f

Everything was fine on 2013-03-27 and broke on 2013-03-28

There is a separate, but maybe related, bug where the edit bookmark menu is cutoff, as seen in these bugs:
bug 1168844
bug 1013677

And a similar windows bug:
bug 1200045

I tested with mozregression both on my mbp's retina display and on my external 1080p monitor and can only reproduce both the cutoff and the whitespace issues on the retina display. That leads me to believe this is a dpi/scaling issue? Retina support was added late 2012/early 2013, so that somewhat lines up.

Comment 13

[Ryan VanderMeulen [:RyanVM]]

http://hg.mozilla.org/mozilla-central/rev/3253b8b2b75e looks like a possible candidate in that range. Nothing else really jumps out at me.

Comment 14

[u428464]

I don't know if it's the case but this bug may also concern the clear history dialog.

Comment 15

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

(In reply to Ryan VanderMeulen [:RyanVM UTC-4] from comment #13)
> http://hg.mozilla.org/mozilla-central/rev/3253b8b2b75e looks like a possible
> candidate in that range. Nothing else really jumps out at me.

yep, I identified the same in comment 9

Comment 16

[Mark Hammond [:markh] [:mhammond]]

It looks like the issue is the same as described in bug 852775 comment 3 - that for some reason the popup code is adding "height" (and maybe "width") attributes to the panel, which causes it to stop sizing. I haven't verified this is actually the case on Mac, but if I manually add a height attribute using the DOM inspector I see the same thing happening.

So I think this needs to be verified (ie, that a height attribute appears on the <panel id="editBookmarkPanel"/> element when it reproduces), then diagnose why the popup code is getting confused about the dynamic resize and adding those attributes.

Comment 18

[Brian Grinstead [:bgrins]]

I can reproduce this, and have confirmed it's retina only

Comment 19

[Matthew N. [:MattN]]

Blocking the osx-hidpi meta bug for now though it may also affect other platforms with > 1dppx

Comment 20

[Justin Dolske [:Dolske]]

Forward duping to 1247824 since we've got a patch there.