based on trying to load sourceforge (bug 101354) part #8 please make the certificate viewer a non modal window. This applies to the network prompts and the certificate manager. In general it would be nice to be able to do comparisons between certificates or to have them visible off to the side while making a decission.
->rangansen True, it would be nice. Still P3, but moving to 2.2
reassign former PSM engineers' bugs to nobody
Created attachment 328979 [details] [diff] [review] something like this might work
Comment on attachment 328979 [details] [diff] [review] something like this might work Thanks for this patch, I only have a minor change request. I think the CA-cert-exists warning message should continue to be modal. I agree the cert viewer is turned into modeless. I agree it makes sense to convert the crl-import-dialog to modeless, too. If you change + "chrome://pippki/content/cacertexists.xul", + block, + PR_FALSE); to PR_TRUE, then r=kaie
In comment 3 you said "this might work". Have you tested? Please make sure someone tests before checking in. Or let me know if you haven't.
Created attachment 355382 [details] [diff] [review] as used in my tree yes it was tested, but it'd be nice if you verified you're happy w/ it and tried it once.
Comment on attachment 355382 [details] [diff] [review] as used in my tree >@@ -483,7 +485,8 @@ nsNSSDialogs::DisplayGeneratingKeypairIn > > rv = nsNSSDialogHelper::openDialog(parent, > "chrome://pippki/content/createCertInfo.xul", >- runnable); >+ runnable, >+ PR_FALSE); > return rv; > } > >@@ -644,6 +647,7 @@ nsNSSDialogs::ShowCertError(nsIInterface > > rv = nsNSSDialogHelper::openDialog(nsnull, > "chrome://pippki/content/certerror.xul", >- block); >+ block, >+ PR_FALSE); > return rv; > } I disagree with your proposal to change the above two dialogs - status while generating key pair - cert error occurred during connection into modeless dialogs. But the rest of the patch is fine. Attach a new patch without the changes listed in this comment, and you have r=kaie
Created attachment 402389 [details] [diff] [review] Subset of timeless second patch This is the subset that I agree with.
Comment on attachment 402389 [details] [diff] [review] Subset of timeless second patch http://hg.mozilla.org/mozilla-central/rev/202a28e5f41a
Sounds like this bug has been fixed, closing.