If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Make psm dialogs non modal

RESOLVED FIXED

Status

Core Graveyard
Security: UI
P3
enhancement
RESOLVED FIXED
16 years ago
a year ago

People

(Reporter: timeless, Assigned: timeless)

Tracking

Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(2 attachments, 1 obsolete attachment)

(Assignee)

Description

16 years ago
based on trying to load sourceforge (bug 101354) part #8

please make the certificate viewer a non modal window.  This applies to the
network prompts and the certificate manager.

In general it would be nice to be able to do comparisons between certificates or
to have them visible off to the side while making a decission.

Updated

16 years ago
Priority: -- → P3
Target Milestone: --- → Future
(Assignee)

Updated

16 years ago
Depends on: 101390

Updated

16 years ago
Blocks: 109714

Comment 1

16 years ago
->rangansen
True, it would be nice. Still P3, but moving to 2.2
Assignee: ssaux → rangansen
Target Milestone: Future → 2.2
reassign former PSM engineers' bugs to nobody
Assignee: rangansen → nobody
QA Contact: junruh → nobody
Target Milestone: 2.2 → ---

Updated

13 years ago
Assignee: nobody → Stefan.Borggraefe
(Assignee)

Updated

13 years ago
Component: Security: UI → Security: UI
Product: PSM → Core
QA Contact: nobody → ui
(Assignee)

Updated

9 years ago
Version: psm2.1 → 1.0 Branch
(Assignee)

Updated

9 years ago
Version: 1.0 Branch → Trunk
(Assignee)

Comment 3

9 years ago
Created attachment 328979 [details] [diff] [review]
something like this might work
Assignee: Stefan.Borggraefe → timeless
Status: NEW → ASSIGNED
Attachment #328979 - Flags: review?(kaie)

Comment 4

9 years ago
Comment on attachment 328979 [details] [diff] [review]
something like this might work

Thanks for this patch, I only have a minor change request.

I think the CA-cert-exists warning message should continue to be modal.

I agree the cert viewer is turned into modeless.

I agree it makes sense to convert the crl-import-dialog to modeless, too.

If you change 
+    "chrome://pippki/content/cacertexists.xul",
+    block,
+    PR_FALSE);

to PR_TRUE, then r=kaie
Attachment #328979 - Flags: review?(kaie) → review-

Updated

9 years ago
OS: Windows 98 → All

Comment 5

9 years ago
In comment 3 you said "this might work". Have you tested? Please make sure someone tests before checking in. Or let me know if you haven't.
(Assignee)

Comment 6

9 years ago
Created attachment 355382 [details] [diff] [review]
as used in my tree

yes it was tested, but it'd be nice if you verified you're happy w/ it and tried it once.
Attachment #328979 - Attachment is obsolete: true
Attachment #355382 - Flags: review?(kaie)

Comment 7

8 years ago
Comment on attachment 355382 [details] [diff] [review]
as used in my tree

>@@ -483,7 +485,8 @@ nsNSSDialogs::DisplayGeneratingKeypairIn
> 
>   rv = nsNSSDialogHelper::openDialog(parent,
>                                      "chrome://pippki/content/createCertInfo.xul",
>-                                     runnable);
>+                                     runnable,
>+                                     PR_FALSE);
>   return rv;
> }
> 
>@@ -644,6 +647,7 @@ nsNSSDialogs::ShowCertError(nsIInterface
> 
>   rv = nsNSSDialogHelper::openDialog(nsnull, 
>                                      "chrome://pippki/content/certerror.xul",
>-                                     block);
>+                                     block,
>+                                     PR_FALSE);
>   return rv;
> }



I disagree with your proposal to change the above two dialogs
- status while generating key pair
- cert error occurred during connection
into modeless dialogs.

But the rest of the patch is fine.

Attach a new patch without the changes listed in this comment, and you have r=kaie
Attachment #355382 - Flags: review?(kaie) → review-

Comment 8

8 years ago
Created attachment 402389 [details] [diff] [review]
Subset of timeless second patch

This is the subset that I agree with.
Attachment #402389 - Flags: review+
Attachment #402389 - Flags: ui-review?(johnath)
(Assignee)

Updated

8 years ago
Summary: Certificate Viewer should never be modal → Make psm dialogs non modal
(Assignee)

Updated

8 years ago
Attachment #402389 - Flags: ui-review?(johnath)
(Assignee)

Comment 9

8 years ago
Comment on attachment 402389 [details] [diff] [review]
Subset of timeless second patch

http://hg.mozilla.org/mozilla-central/rev/202a28e5f41a

Comment 10

7 years ago
Sounds like this bug has been fixed, closing.
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Duplicate of this bug: 1005239
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.