Closed Bug 1014405 Opened 6 years ago Closed 5 years ago

[Stingray] Keyboard event handling in Gaia

Categories

(Firefox OS Graveyard :: Gaia::System, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: dwi2, Assigned: dwi2)

References

Details

(Whiteboard: [ft:conndevices])

Attachments

(1 file)

46 bytes, text/x-github-pull-request
johnhu
: review+
Details | Review
bug 989198 propose a new mechanism of dispatching keyboard event across BrowserElements.
see https://wiki.mozilla.org/WebAPI/BrowserAPI/KeyboardEvent#Dispatch_KeyboardEvent_across_BrowserElements

In system app, we should adopt this mechanism in order to fulfill requirement of Stingray
(I'll file another bug for phone)
Depends on: 989198
Assignee: nobody → tzhuang
OS: Mac OS X → Gonk (Firefox OS)
Hardware: x86 → ARM
Whiteboard: [FT:Stream3]
Blocks: 1026354
bug 1074040 clones part of system app into tv_apps/smart-system/ 
So we should adopt this new mechanism (proposed in bug 989198) in tv_apps/smart-system/
Blocks: CardUI
Depends on: 1074040
See Also: → 1014418
Whiteboard: [FT:Stream3] → [ft:conndevices]
Attached file pull request
Hi John,

With this patch, we could support hardware key event dispatching across browser element in tv_apps/smart-system/ . Please help to review the patch. Thanks
Attachment #8523635 - Flags: review?(im)
Comment on attachment 8523635 [details] [review]
pull request

Looks good to me. Thanks for this.
Attachment #8523635 - Flags: review?(im) → review+
Gaia-Try result is ok
https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=889e2fa47c38

Landed on master
https://github.com/mozilla-b2g/gaia/commit/40065d7b7c3fcc5afc57aa0e443dbac7f018b6ea
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Blocks: 1094066
You need to log in before you can comment on or make changes to this bug.