Closed Bug 1074040 Opened 5 years ago Closed 5 years ago

[Stingray] Default landing deck

Categories

(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect)

x86
macOS
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
2.1 S7 (24Oct)

People

(Reporter: jcheng, Assigned: johnhu)

References

Details

(Whiteboard: [ft:conndevices])

Attachments

(1 file, 3 obsolete files)

As a user, when I turn on my device, I will see the landing deck (or dashboard)
Depends on: 1074041
Assignee: nobody → im
As per offline discussion, I will do the following:
1. create Phone's HomescreenWindowManager to handle all homescreen related behaviors, including press home and long press home. (We don't need phone's card view in TV)
2. create TV's HomescreenWindowManager which will replace phone's at build time. It will dynamic loads LandingAppLauncher and LandingAppWindow
3. create LandingAppLauncher only for TV
4. create LandingAppWindow which is based on HomescreenWindow and is only for tv
5. modify build script to use TV's HomescreenWindowManager at build time

Let's start it.
switch component to system:window manager
Component: Gaia → Gaia::System::Window Mgmt
Attached file part 1: HomescreenWindowManager (obsolete) —
Alive,

This is the part 1 without the hold-home part. I will file another one for hold-home. It would be nice to have your feedback at this stage. So, please give me some feedback about this one. Thanks.
Attachment #8497958 - Flags: feedback?(alive)
BTW, I didn't fix the test cases. So, I believe the try will give us lots red items.
Comment on attachment 8497958 [details] [review]
part 1: HomescreenWindowManager

Offline discussion: we have more to improve.
Attachment #8497958 - Flags: feedback?(alive) → feedback+
Hi alive,

I had revised the code according to our offline discussion. Please feedback on this.
Attachment #8497958 - Attachment is obsolete: true
Attachment #8498601 - Flags: feedback?(alive)
Depends on: 1076613
Comment on attachment 8498601 [details] [review]
part 1: HomescreenWindowManager for phone

Shift this PR to bug 1076613.
Attachment #8498601 - Attachment is obsolete: true
Attachment #8498601 - Flags: feedback?(alive)
Depends on: 1078193
Attached file fork and remove useless items (obsolete) —
Hi,

I had finished the PR. Please review this patch. It adds landing app support and removes the followings:
1. ril related
2. utility tray
3. statusbar
4. edge gesture
5. rocketbar
6. payment
7. firefox account
8. nfc
9. lockscreen
10. mobileid
11. card view
12. some UI related to above.

The things I kept are:
1. window management, including XXXWindow, XXXWindowManager, XXXWindowLauncher
2. all dialogs
3. all toasts, including XXXBanner, XXXToast, notification
4. others without UI, including accessibility, bt, battey manager(we may need to demo on tablet).
Attachment #8505910 - Flags: review?(timdream)
Attachment #8505910 - Flags: review?(ehung)
Oh maybe it's too late but I'd like to see two commits: one for the code you copied and modified from System app, and one for your added files.
Ok, I should separate them as two bug. I can do that. But that may take one or two days.
Attached file PR with 2 commits
I had separate them as two commits. The result of this PR and last PR are identical. Please review this version. I will squash these two commit after this patch is reviewed. Thanks.
Attachment #8505910 - Attachment is obsolete: true
Attachment #8505910 - Flags: review?(timdream)
Attachment #8505910 - Flags: review?(ehung)
Attachment #8506631 - Flags: review?(timdream)
Attachment #8506631 - Flags: review?(ehung)
Comment on attachment 8506631 [details] [review]
PR with 2 commits

Alive should review this.
Attachment #8506631 - Flags: review?(timdream) → review?(alive)
(In reply to Tim Guan-tin Chien [:timdream] (MoCo-TPE) (please ni?) from comment #12)
> Comment on attachment 8506631 [details] [review]
> PR with 2 commits
> 
> Alive should review this.

Great, will ask your rubberstamp then.
Comment on attachment 8506631 [details] [review]
PR with 2 commits

IMO my responsibility is to understand how TV system works for landing page app; I think john had already explained to me before.

What I am suggesting to do is even we don't want to write any test for the new codes, I still want to see some diagrams or comments to explain how "two homescreen works" with homescreen window manager and homescreen window.
Attachment #8506631 - Flags: review?(alive) → review+
Thanks alive. I will add more comments before landing the code.
Comment on attachment 8506631 [details] [review]
PR with 2 commits

I'm fine with this approach as long as we remove useless components as much as possible or file bugs for tracking if we can't easily delete them due to dependency. We've had some conversation on Github and it looks good to me.
Attachment #8506631 - Flags: review?(ehung) → review+
Target Milestone: --- → 2.1 S7 (24Oct)
Comment on attachment 8506631 [details] [review]
PR with 2 commits

Tim,

We still need your review of this issue. Thanks.
Attachment #8506631 - Flags: review?(timdream)
Comment on attachment 8506631 [details] [review]
PR with 2 commits

Because of milestone and two 2+ got, I will land the code at two hours later and remove the r? of tim.
Attachment #8506631 - Flags: review?(timdream)
merged to master:
https://github.com/mozilla-b2g/gaia/commit/0888735b2c5932624808147b85a60d698d9d7352
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Whiteboard: [ft:conndevices]
You need to log in before you can comment on or make changes to this bug.