1014966 - [Vertical Homescreen] Scrolling does not pause during divider creation

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Description

[Johan Lorenzo [:jlorenzo]]

Build Information
Gaia      ef66efa34ed8a559c8998bde688fae88eb943a7a
Gecko     https://hg.mozilla.org/mozilla-central/rev/b40296602083
BuildID   20140522040230
Version   32.0a1
ro.build.version.incremental=94
ro.build.date=Tue May 20 09:29:20 CST 2014

Step to reproduce
Enter Edit Mode
Drag a random icon to the bottom of the screen
Continue dragging after exceeding the first divider reserved space

Actual results
You can scroll indefinitely.

Expected results
As per UX specs: When the user reaches the bottom of a row, a space will appear to allow the user to add the icon to the bottom of the row, any quick scrolling will pause.

Comment 1

[Cristian Rodriguez (:crdlc)]

Attachment: Github pull request

Thanks for the review

Comment 2

[Johan Lorenzo [:jlorenzo]]

https://moztrap.mozilla.org/manage/case/13314/

Comment 4

[Kevin Grandon :kgrandon]

Comment on attachment 8427656 [details]
Github pull request

Thanks. It would be good to have some test for this, but I'm not sure how easy an integration test would be. I wonder if we can cover this with a unit test? Perhaps either mocking some scrolling if needed, or maybe it could just work.

Comment 5

[Kevin Grandon :kgrandon]

Landed: https://github.com/mozilla-b2g/gaia/commit/560b40a757baac5f296711d299a2e178fdc3f924

Comment 6

[Kevin Grandon :kgrandon]

Mass modify - set status-b2g-v2.0 fixed for fixed bugs under vertical homescreen dependency tree.