Closed Bug 1015054 Opened 8 years ago Closed 8 years ago

[B2G][Gaia][CBS] Provide enhanced CBS search list format from Operator_Variant to Gecko


(Firefox OS Graveyard :: Gaia::System, defect)

Gonk (Firefox OS)
Not set


(feature-b2g:2.1, tracking-b2g:backlog)

2.1 S3 (29aug)
feature-b2g 2.1
tracking-b2g backlog


(Reporter: bevis, Assigned: arthurcc)



(Whiteboard: [priority][ft:system-platform][p=2])


(1 file)

*** Duplicated from Bug 990923 ***

Fire this bug for Gaia to provide a enhanced CBS search list defined in bug 990910 to gecko to support to
1. Set Search List for Multi-SIM
2. Set Search List of CBS for both CDMA/GSM network simultaneously.
Put this in v2.1
blocking-b2g: --- → backlog
feature-b2g: --- → 2.1
Whiteboard: [priority]
Hi Arthur, can you have a look first? If it belongs to us, it'll be in our 2.1 list.
Flags: needinfo?(arthur.chen)
Assignee: nobody → arthur.chen
Flags: needinfo?(arthur.chen)
Whiteboard: [priority] → [priority][ft:system-platform]
Whiteboard: [priority][ft:system-platform] → [priority][ft:system-platform][p=2]
Target Milestone: --- → 2.1 S1 (1aug)
Target Milestone: 2.1 S1 (1aug) → 2.1 S2 (15aug)
Jose, this is similar to migrating the voicemail number from a single value to an array we did before. So I merged some of the code and tests in this patch, would you mind take a look at it? Thanks!
Attachment #8468262 - Flags: review?(josea.olivera)
Comment on attachment 8468262 [details]
Link to

Clear the review as the patch lacks the handling of cdma operators.
Attachment #8468262 - Flags: review?(josea.olivera)
Target Milestone: 2.1 S2 (15aug) → 2.1 S3 (29aug)
Hi Jose, I noticed that all information of cell broadcast search list is listed in operator_variant.xml maintaining by us. To fulfill the second requirement in the description, can we simply change the format in the file? For example, the setting |cellBroadcastSearchList="0,9,19,28,112"| will become |cellBroadcastSearchList="{gsm: 0,9,19,28,112}"|. Does that make sense to you?
Flags: needinfo?(josea.olivera)
Comment on attachment 8468262 [details]
Link to

Hi Jose, I've implement what I proposed in the second commit of the patch. Please let me know what you think, thank you!
Attachment #8468262 - Flags: review?(josea.olivera)
Flags: needinfo?(josea.olivera)
Confirmed with EPM/EM, and this can be landed before FL.
Comment on attachment 8468262 [details]
Link to

LGTM. r=me

Thanks Arthur!
Attachment #8468262 - Flags: review?(josea.olivera) → review+
Thanks for reviewing!

master: ecae8e4d120356a08ecfe116b1bc98741e8733e2
Closed: 8 years ago
Resolution: --- → FIXED
blocking-b2g: backlog → ---
You need to log in before you can comment on or make changes to this bug.