1015054 - [B2G][Gaia][CBS] Provide enhanced CBS search list format from Operator_Variant to Gecko

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Bevis Tseng[:bevis][:btseng](Exited)]

*** Duplicated from Bug 990923 ***

Fire this bug for Gaia to provide a enhanced CBS search list defined in bug 990910 to gecko to support to
1. Set Search List for Multi-SIM
2. Set Search List of CBS for both CDMA/GSM network simultaneously.

Comment 1

[howie [:howie]]

Put this in v2.1

Comment 2

[howie [:howie]]

Hi Arthur, can you have a look first? If it belongs to us, it'll be in our 2.1 list.

Comment 3

[Arthur Chen [:arthurcc][inactive after 6/30]]

Attachment: Link to https://github.com/mozilla-b2g/gaia/pull/22550

Jose, this is similar to migrating the voicemail number from a single value to an array we did before. So I merged some of the code and tests in this patch, would you mind take a look at it? Thanks!

Comment 4

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8468262 [details]
Link to https://github.com/mozilla-b2g/gaia/pull/22550

Clear the review as the patch lacks the handling of cdma operators.

Comment 5

[Arthur Chen [:arthurcc][inactive after 6/30]]

Hi Jose, I noticed that all information of cell broadcast search list is listed in operator_variant.xml maintaining by us. To fulfill the second requirement in the description, can we simply change the format in the file? For example, the setting |cellBroadcastSearchList="0,9,19,28,112"| will become |cellBroadcastSearchList="{gsm: 0,9,19,28,112}"|. Does that make sense to you?

Comment 6

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8468262 [details]
Link to https://github.com/mozilla-b2g/gaia/pull/22550

Hi Jose, I've implement what I proposed in the second commit of the patch. Please let me know what you think, thank you!

Comment 7

[Kai-Chih Hu [:khu]]

Confirmed with EPM/EM, and this can be landed before FL.

Comment 8

[José Antonio Olivera Ortega [:jaoo]]

Comment on attachment 8468262 [details]
Link to https://github.com/mozilla-b2g/gaia/pull/22550

LGTM. r=me

Thanks Arthur!

Comment 9

[Arthur Chen [:arthurcc][inactive after 6/30]]

Thanks for reviewing!

master: ecae8e4d120356a08ecfe116b1bc98741e8733e2