921326 - Cellbroadcast API: support multiple sim cards

Status: VERIFIED FIXED

(Firefox OS Graveyard :: RIL, defect)

Comment 1

[Ken Chang[:kenkai]]

This is a 1.4+ bug.

Comment 2

[José Antonio Olivera Ortega [:jaoo]]

Here we will need some changes in the gaia side as well. Remember we set up the list of CB channels from Gaia and enable/disable the service as well. I'll keep an eye on this bug that way I could take care of it.

Comment 3

[Hsin-Yi Tsai (she/her) [:hsinyi]]

(In reply to José Antonio Olivera Ortega [:jaoo] from comment #2)
> Here we will need some changes in the gaia side as well. Remember we set up
> the list of CB channels from Gaia and enable/disable the service as well.
> I'll keep an eye on this bug that way I could take care of it.

Thanks for kind reminding, jaoo.

Yes, we'd change the format of "ril.cellbroadcast.searchlist" and "ril.cellbroadcast.disabled". I'd suggest we follow the same format for "ril.data.apnSettings", i.e. using an array as key result. How do you think?

Comment 4

[José Antonio Olivera Ortega [:jaoo]]

(In reply to Hsin-Yi Tsai  [:hsinyi] from comment #3)

> Yes, we'd change the format of "ril.cellbroadcast.searchlist" and
> "ril.cellbroadcast.disabled". I'd suggest we follow the same format for
> "ril.data.apnSettings", i.e. using an array as key result. How do you think?

I guess that "ril.cellbroadcast.searchlist" becomes an array is the right thing to do but I'm not sure if "ril.cellbroadcast.disabled" becomes an array is correct. Let me explain myself. If we are going to enable the service per ICC card we should become an array but if we are going to enable 'the service' globally we should keep it as a boolean then.

Comment 5

[Hsin-Yi Tsai (she/her) [:hsinyi]]

(In reply to José Antonio Olivera Ortega [:jaoo] from comment #4)
> (In reply to Hsin-Yi Tsai  [:hsinyi] from comment #3)
> 
> > Yes, we'd change the format of "ril.cellbroadcast.searchlist" and
> > "ril.cellbroadcast.disabled". I'd suggest we follow the same format for
> > "ril.data.apnSettings", i.e. using an array as key result. How do you think?
> 
> I guess that "ril.cellbroadcast.searchlist" becomes an array is the right
> thing to do but I'm not sure if "ril.cellbroadcast.disabled" becomes an
> array is correct. Let me explain myself. If we are going to enable the
> service per ICC card we should become an array but if we are going to enable
> 'the service' globally we should keep it as a boolean then.

Totally agree with you here. It makes sense to me to enalbe cellbroadcast per device, though UI should make the call.

Comment 6

[Hsin-Yi Tsai (she/her) [:hsinyi]]

(In reply to Hsin-Yi Tsai  [:hsinyi] from comment #5)
> (In reply to José Antonio Olivera Ortega [:jaoo] from comment #4)
> > (In reply to Hsin-Yi Tsai  [:hsinyi] from comment #3)
> > 
> > > Yes, we'd change the format of "ril.cellbroadcast.searchlist" and
> > > "ril.cellbroadcast.disabled". I'd suggest we follow the same format for
> > > "ril.data.apnSettings", i.e. using an array as key result. How do you think?
> > 
> > I guess that "ril.cellbroadcast.searchlist" becomes an array is the right
> > thing to do but I'm not sure if "ril.cellbroadcast.disabled" becomes an
> > array is correct. Let me explain myself. If we are going to enable the
> > service per ICC card we should become an array but if we are going to enable
> > 'the service' globally we should keep it as a boolean then.
> 
> Totally agree with you here. It makes sense to me to enalbe cellbroadcast
> per device, though UI should make the call.

Confirmed with UX on bug 947229 comment 8, we will have separate settings for each SIM. The result of "ril.cellbroadcast.disabled" should be an array then.

Comment 7

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

remove 1.4+ flag as this is feature. we should use meta bug to keep tracking. (b2g-DSDS-1.4)

Comment 8

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

Hi Joe,
Is bug 947229 included in the feature set of DSDS for 1.4?
Saw some comment and status change on that bug, but just ni you for confirmation.
If not, I'll defer this one to future milestone.

Comment 9

[Joe Cheng [:jcheng] (please needinfo)]

we are no longer including bug 947229 for v1.4
i'd like to confirm what's the behavior of the device in v1.4 (which should be the same as 1.3) without this bug? Enpei do you know? Thanks

Comment 10

[Enpei]

(In reply to Joe Cheng [:jcheng] from comment #9)
> we are no longer including bug 947229 for v1.4
> i'd like to confirm what's the behavior of the device in v1.4 (which should
> be the same as 1.3) without this bug? Enpei do you know? Thanks

Message setting is still for SIM 1 only without SIM picker on v1.4, which means Cell broadcast setting in it also for one SIM only. https://bugzilla.mozilla.org/show_bug.cgi?id=960474

Comment 11

[Hsin-Yi Tsai (she/her) [:hsinyi]]

(In reply to Enpei from comment #10)
> (In reply to Joe Cheng [:jcheng] from comment #9)
> > we are no longer including bug 947229 for v1.4
> > i'd like to confirm what's the behavior of the device in v1.4 (which should
> > be the same as 1.3) without this bug? Enpei do you know? Thanks
> 
> Message setting is still for SIM 1 only without SIM picker on v1.4, which

I think this should be "Message setting is global setting."
So, right now cellbroadcast setting is globally for two SIMs. 
But the UX spec expects separate setting for each SIM, please see bug 947229 comment 8.

> means Cell broadcast setting in it also for one SIM only.
> https://bugzilla.mozilla.org/show_bug.cgi?id=960474

Comment 12

[Hsin-Yi Tsai (she/her) [:hsinyi]]

de-assign myself since this is with lower priority and looks I won't be able to work on this recently.

Comment 13

[Bevis Tseng[:bevis][:btseng](Exited)]

Summarize tasks to be done in this bug:
1. Accept extended preference of "ril.cellbroadcast.disabled" from Gaia to toggle CBS per SIM. 
   (Depends on bug 1013093)
2. Accept new format of "ril.cellbroadcast.searchlist" from Gaia (defined in bug 990910)
   which includes CB searchlists of inserted SIM cards to set search list per SIM.
   (Depends on bug 990923)
3. Extend DOMMozCellBroadcastMessage to provide the serviceId of the received CB message.

Comment 14

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

Because the GAIA dependencies are not able to be done before 2.0 FL, remove feature-b2g.

Comment 15

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

This is requirement from CAF for 2.1.
Set to 2.1? so that we can prioritize in 2.1

Comment 16

[bhavana bajaj [:bajaj]]

Per email, discussion targeting this for 2.1 FL and hence setting the feature-b2g flag appropriately.

Comment 17

[Bevis Tseng[:bevis][:btseng](Exited)]

To remove the dependency from gaia (bug 1013093 and bug 990923),
I'd like to figure out a solution in gecko side to adopt both old/new settings.

Comment 18

[Bevis Tseng[:bevis][:btseng](Exited)]

Attachment: Patch Part 1 v1: Support to Set Search List for Each SIM.

1. Move setCellBroadcastSearchList() related logic from RadioInterface to a new Helper |gCellBroadcastSettingsHandler|.
2. Set search list to each RadioInterface accordingly.

Comment 19

[Bevis Tseng[:bevis][:btseng](Exited)]

Attachment: Patch Part 2 v1: Support to Toggle CellBroadcast Service per SIM.

1. Migrate the 'ril.cellbroadcast.disabled' from preference to settings.
2. Support to set 'ril.cellbroadcast.disabled' per RadioInterface.

Comment 20

[Bevis Tseng[:bevis][:btseng](Exited)]

Attachment: Patch Part 3 v1: Support to Receive Cellbroadcast Messages from different serviceId.

Comment 21

[Bevis Tseng[:bevis][:btseng](Exited)]

Attachment: Patch Part 4 v1: Add Test case to verify CB message received in Multi-SIM devices.

Comment 22

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Comment on attachment 8439113 [details] [diff] [review]
Patch Part 1 v1: Support to Set Search List for Each SIM.

Review of attachment 8439113 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/system/gonk/RadioInterfaceLayer.js
@@ +989,5 @@
>      },
>    };
>  });
>  
> +XPCOMUtils.defineLazyGetter(this, "gCellBroadcastSettingsHandler", function () {

Thanks for this global helper, but I don't think we really need this. When receiving settings change, each RadioInterface could/should take care of its setting.

@@ -3428,5 @@
> -          this.debug("'" + kSettingsCellBroadcastSearchList +
> -            "' is now " + JSON.stringify(aResult));
> -        }
> -        // TODO: Set searchlist for Multi-SIM. See Bug 921326.
> -        let result = Array.isArray(aResult) ? aResult[0] : aResult;

All you need is this patch is /s/aResult[0]/aResult[this.clientId]/.

Comment 23

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Comment on attachment 8439114 [details] [diff] [review]
Patch Part 2 v1: Support to Toggle CellBroadcast Service per SIM.

Review of attachment 8439114 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/system/gonk/RadioInterfaceLayer.js
@@ +1027,5 @@
> +      *   true if CBS is disabled. The value is applied to all RadioInterfaces.
> +      * Enhanced Format: Array of Boolean
> +      *   Each element represents the toggle of CBS per RadioInterface
> +      */
> +      lock.get(kSettingsCellBroadcastDisabled, this);

Same as comments for part 1 - let each RadioInterface receive the settings it cares and the RadioInterface should handle the change properly.

Comment 24

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Comment on attachment 8439115 [details] [diff] [review]
Patch Part 3 v1: Support to Receive Cellbroadcast Messages from different serviceId.

Review of attachment 8439115 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with comments addressed!

::: dom/system/gonk/RILContentHelper.js
@@ +304,5 @@
>                        timeSeconds: 'r',
>                        serviceClass: 'r'}
>  };
>  
> +function CellBroadcastMessage(serviceId, pdu) {

It's quite complicated ... but when we designed DSDS features, we adopted the coding style that we use 'clientId' as the argument in RILContentHelper function. So please s/serviceId/clientId/ :P

@@ +331,5 @@
>      interfaces:       [Ci.nsIDOMMozCellBroadcastMessage]
>    }),
>  
>    // nsIDOMMozCellBroadcastMessage
> +  serviceId: 0,

Let's use -1 as a default value. We will assign a correct value in constructor.

Comment 25

[Bevis Tseng[:bevis][:btseng](Exited)]

(In reply to Hsin-Yi Tsai [:hsinyi] from comment #22)
> 
> Thanks for this global helper, but I don't think we really need this. When
> receiving settings change, each RadioInterface could/should take care of its
> setting.
> 
> All you need is this patch is /s/aResult[0]/aResult[this.clientId]/.

Haha, alright, that was my 1st version of this patch.
I'll move them back in the new patches. :p

Comment 26

[Bevis Tseng[:bevis][:btseng](Exited)]

(In reply to Hsin-Yi Tsai [:hsinyi] from comment #24)
> Comment on attachment 8439115 [details] [diff] [review]
> Patch Part 3 v1: Support to Receive Cellbroadcast Messages from different
> serviceId.
> 
> Review of attachment 8439115 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> r=me with comments addressed!
> 
> ::: dom/system/gonk/RILContentHelper.js
> @@ +304,5 @@
> >                        timeSeconds: 'r',
> >                        serviceClass: 'r'}
> >  };
> >  
> > +function CellBroadcastMessage(serviceId, pdu) {
> 
> It's quite complicated ... but when we designed DSDS features, we adopted
> the coding style that we use 'clientId' as the argument in RILContentHelper
> function. So please s/serviceId/clientId/ :P

Thanks for the explanation. I'll follow the rule.

> @@ +331,5 @@
> >      interfaces:       [Ci.nsIDOMMozCellBroadcastMessage]
> >    }),
> >  
> >    // nsIDOMMozCellBroadcastMessage
> > +  serviceId: 0,
> 
> Let's use -1 as a default value. We will assign a correct value in
> constructor.

Comment 27

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Comment on attachment 8439116 [details] [diff] [review]
Patch Part 4 v1: Add Test case to verify CB message received in Multi-SIM devices.

Review of attachment 8439116 [details] [diff] [review]:
-----------------------------------------------------------------

It looks so good! But I'd still like to ask you to move the helpers to head.js in this patch. We could revise other existing test cases by using head.js afterwards that isn't rush or 100% necessary. Thank you. :)

::: dom/cellbroadcast/tests/marionette/test_cellbroadcast_multi_sim.js
@@ +68,5 @@
> +  runEmulatorCmd(aCommand, function(aResult) {
> +    --pendingEmulatorCmdCount;
> +
> +    ok(true, "Emulator response: " + JSON.stringify(aResult));
> +    if (Array.isArray(aResult) && aResult[0] === "OK") {

To be more general, we should check |aResult[aResult.length - 1] === "OK"|.

@@ +141,5 @@
> + */
> +function sendMultipleRawCbsToEmulatorAndWait(aPdus) {
> +  let promises = [];
> +
> +  promises.push(waitForManagerEvent("received"));

If we are going to send multiple pbus, is it expected that we should also receive multiple 'received' events?

Comment 28

[Bevis Tseng[:bevis][:btseng](Exited)]

(In reply to Hsin-Yi Tsai [:hsinyi] from comment #27)
> It looks so good! But I'd still like to ask you to move the helpers to
> head.js in this patch. We could revise other existing test cases by using
> head.js afterwards that isn't rush or 100% necessary. Thank you. :)

Sure, I'll address this in next update.

> 
> ::: dom/cellbroadcast/tests/marionette/test_cellbroadcast_multi_sim.js
> @@ +68,5 @@
> > +  runEmulatorCmd(aCommand, function(aResult) {
> > +    --pendingEmulatorCmdCount;
> > +
> > +    ok(true, "Emulator response: " + JSON.stringify(aResult));
> > +    if (Array.isArray(aResult) && aResult[0] === "OK") {
> 
> To be more general, we should check |aResult[aResult.length - 1] === "OK"|.
Will do.
> 
> @@ +141,5 @@
> > + */
> > +function sendMultipleRawCbsToEmulatorAndWait(aPdus) {
> > +  let promises = [];
> > +
> > +  promises.push(waitForManagerEvent("received"));
> 
> If we are going to send multiple pbus, is it expected that we should also
> receive multiple 'received' events?

No, these PDUs are expected to be concatenated into 1 CB message before triggering the 'received' event. :)

Comment 29

[Bevis Tseng[:bevis][:btseng](Exited)]

Attachment: Patch Part 1 v2: Support to Set Search List for Each SIM.

Address the suggestion in comment 22 to support without a helper.

Comment 30

[Bevis Tseng[:bevis][:btseng](Exited)]

Attachment: Patch Part 2 v2: Support to Toggle CellBroadcast Service per SIM.

Address the suggestion in comment 23 to support without a helper.

Comment 31

[Bevis Tseng[:bevis][:btseng](Exited)]

Attachment: Patch Part 3 v2: Support to Receive Cellbroadcast Messages from different serviceId. r=htsai

s/serviceId/clientId/

Comment 32

[Bevis Tseng[:bevis][:btseng](Exited)]

Attachment: Patch Part 4 v2: Add Test case to verify CB message received in Multi-SIM devices.

address suggestion in comment 27.

Comment 33

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Comment on attachment 8441148 [details] [diff] [review]
Patch Part 1 v2: Support to Set Search List for Each SIM.

Review of attachment 8441148 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/system/gonk/RadioInterfaceLayer.js
@@ +2471,2 @@
>      this.workerMessenger.send("setCellBroadcastSearchList",
> +                              { searchList: newSearchList });

The old implementation played a safer way. It considered the failure case. Could you explain the reason of this change, thank you?

Comment 34

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Comment on attachment 8441149 [details] [diff] [review]
Patch Part 2 v2: Support to Toggle CellBroadcast Service per SIM.

Review of attachment 8441149 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/system/gonk/ril_worker.js
@@ +14882,5 @@
>      RILQUIRKS_V5_LEGACY = quirks.v5Legacy;
>      RILQUIRKS_REQUEST_USE_DIAL_EMERGENCY_CALL = quirks.requestUseDialEmergencyCall;
>      RILQUIRKS_SIM_APP_STATE_EXTRA_FIELDS = quirks.simAppStateExtraFields;
>      RILQUIRKS_EXTRA_UINT32_2ND_CALL = quirks.extraUint2ndCall;
>      RILQUIRKS_HAVE_QUERY_ICC_LOCK_RETRY_COUNT = quirks.haveQueryIccLockRetryCount;

I notice the handler of REQUEST_CDMA_SET_BROADCAST_SMS_CONFIG seems missing. We need to make it do the same as the handler of REQUEST_GSM_SET_BROADCAST_SMS_CONFIG. Please help address the part in this bug as well.

Except this, the patch looks good.

Comment 35

[Bevis Tseng[:bevis][:btseng](Exited)]

(In reply to Hsin-Yi Tsai [:hsinyi] from comment #34)
> Comment on attachment 8441149 [details] [diff] [review]
> Patch Part 2 v2: Support to Toggle CellBroadcast Service per SIM.
> 
> Review of attachment 8441149 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: dom/system/gonk/ril_worker.js
> @@ +14882,5 @@
> >      RILQUIRKS_V5_LEGACY = quirks.v5Legacy;
> >      RILQUIRKS_REQUEST_USE_DIAL_EMERGENCY_CALL = quirks.requestUseDialEmergencyCall;
> >      RILQUIRKS_SIM_APP_STATE_EXTRA_FIELDS = quirks.simAppStateExtraFields;
> >      RILQUIRKS_EXTRA_UINT32_2ND_CALL = quirks.extraUint2ndCall;
> >      RILQUIRKS_HAVE_QUERY_ICC_LOCK_RETRY_COUNT = quirks.haveQueryIccLockRetryCount;
> 
> I notice the handler of REQUEST_CDMA_SET_BROADCAST_SMS_CONFIG seems missing.
> We need to make it do the same as the handler of
> REQUEST_GSM_SET_BROADCAST_SMS_CONFIG. Please help address the part in this
> bug as well.
Wow, you're right.
Thanks for catching this! :)
> 
> Except this, the patch looks good.

Comment 36

[Bevis Tseng[:bevis][:btseng](Exited)]

Attachment: Patch Part 5 v1: Add manifest.ini into webapi tests in marionette unit-tests.ini. r=htsai

Comment 37

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Comment on attachment 8441151 [details] [diff] [review]
Patch Part 4 v2: Add Test case to verify CB message received in Multi-SIM devices.

Review of attachment 8441151 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thank you!

::: dom/cellbroadcast/tests/marionette/head.js
@@ +175,5 @@
> + *
> + * @param aTestCaseMain
> + *        A function that takes no parameter.
> + */
> +function startTestCommon(aTestCaseMain) {

nit: maybe put this function and  runIfMultiSIM in the end of head.js so that authors could easily get the main entrance?

Comment 38

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Comment on attachment 8441148 [details] [diff] [review]
Patch Part 1 v2: Support to Set Search List for Each SIM.

Review of attachment 8441148 [details] [diff] [review]:
-----------------------------------------------------------------

See my comment 33 :)

Comment 39

[Bevis Tseng[:bevis][:btseng](Exited)]

(In reply to Hsin-Yi Tsai [:hsinyi] from comment #37)
> Comment on attachment 8441151 [details] [diff] [review]
> Patch Part 4 v2: Add Test case to verify CB message received in Multi-SIM
> devices.
> 
> Review of attachment 8441151 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Looks good, thank you!
> 
> ::: dom/cellbroadcast/tests/marionette/head.js
> @@ +175,5 @@
> > + *
> > + * @param aTestCaseMain
> > + *        A function that takes no parameter.
> > + */
> > +function startTestCommon(aTestCaseMain) {
> 
> nit: maybe put this function and  runIfMultiSIM in the end of head.js so
> that authors could easily get the main entrance?

I see. I'll move the order of these APIs for better reading. :)

Comment 40

[Bevis Tseng[:bevis][:btseng](Exited)]

(In reply to Hsin-Yi Tsai [:hsinyi] from comment #33)
> Comment on attachment 8441148 [details] [diff] [review]
> Patch Part 1 v2: Support to Set Search List for Each SIM.
> 
> Review of attachment 8441148 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: dom/system/gonk/RadioInterfaceLayer.js
> @@ +2471,2 @@
> >      this.workerMessenger.send("setCellBroadcastSearchList",
> > +                              { searchList: newSearchList });
> 
> The old implementation played a safer way. It considered the failure case.
> Could you explain the reason of this change, thank you?

Thanks for the explanation offline:
"
We should keep the old implementation to allow gaia to get the feedback of the request by observing the change of the |ril.cellbroadcast.searchlist| setting.
"

Comment 41

[Bevis Tseng[:bevis][:btseng](Exited)]

Attachment: Patch Part 4 v3: Add Test case to verify CB message received in Multi-SIM devices. r=htsai

address the nit in comment 37 to re-order the utilities for better reading.

Comment 42

[Bevis Tseng[:bevis][:btseng](Exited)]

Attachment: Patch Part 1 v3: Support to Set Search List for Each SIM. r=htsai

address the suggestion in comment 33 to restore the settings for negative response of setCellBroadcastSearchList.

Comment 43

[Bevis Tseng[:bevis][:btseng](Exited)]

Attachment: Patch Part 2 v3: Support to Toggle CellBroadcast Service per SIM.

Address the problem mention in comment 34 to setSmsBroadcastActivation() for postive response of REQUEST_CDMA_SET_BROADCAST_SMS_CONFIG.

Comment 44

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Comment on attachment 8441902 [details] [diff] [review]
Patch Part 1 v3: Support to Set Search List for Each SIM. r=htsai

Review of attachment 8441902 [details] [diff] [review]:
-----------------------------------------------------------------

Looks great, thank you.

Comment 45

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Comment on attachment 8441905 [details] [diff] [review]
Patch Part 2 v3: Support to Toggle CellBroadcast Service per SIM.

Review of attachment 8441905 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/system/gonk/RadioInterfaceLayer.js
@@ +1814,5 @@
> +  *
> +  * Simple Format: Boolean
> +  *   true if CBS is disabled. The value is applied to all RadioInterfaces.
> +  * Enhanced Format: Array of Boolean
> +  *   Each element represents the toggle of CBS per RadioInterface

nit: a period at the end of the line

Comment 46

[Bevis Tseng[:bevis][:btseng](Exited)]

(In reply to Hsin-Yi Tsai [:hsinyi] from comment #45)
> Comment on attachment 8441905 [details] [diff] [review]
> Patch Part 2 v3: Support to Toggle CellBroadcast Service per SIM.
> 
> Review of attachment 8441905 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: dom/system/gonk/RadioInterfaceLayer.js
> @@ +1814,5 @@
> > +  *
> > +  * Simple Format: Boolean
> > +  *   true if CBS is disabled. The value is applied to all RadioInterfaces.
> > +  * Enhanced Format: Array of Boolean
> > +  *   Each element represents the toggle of CBS per RadioInterface
> 
> nit: a period at the end of the line
oops. will do.

Comment 47

[Bevis Tseng[:bevis][:btseng](Exited)]

Attachment: Patch Part 2 v4: Support to Toggle CellBroadcast Service per SIM. r=htsai

Address nit in comment 45.

Comment 48

[Bevis Tseng[:bevis][:btseng](Exited)]

update try server result:
https://tbpl.mozilla.org/?tree=Try&rev=fb2ba5aa8aab

Comment 49

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/f6f0464fa835
https://hg.mozilla.org/integration/b2g-inbound/rev/041dd3366df1
https://hg.mozilla.org/integration/b2g-inbound/rev/da44ea22ec89
https://hg.mozilla.org/integration/b2g-inbound/rev/a26df6b1981b
https://hg.mozilla.org/integration/b2g-inbound/rev/a369658569d9

Comment 50

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/f6f0464fa835
https://hg.mozilla.org/mozilla-central/rev/041dd3366df1
https://hg.mozilla.org/mozilla-central/rev/da44ea22ec89
https://hg.mozilla.org/mozilla-central/rev/a26df6b1981b
https://hg.mozilla.org/mozilla-central/rev/a369658569d9

Comment 51

[Eric Chang [:ericcc] [:echang]]

Current emulator tests
http://dxr.mozilla.org/mozilla-central/source/dom/cellbroadcast/tests/marionette

No software emulator found to send fake cell broadcast message yet. Cell Broadcast message can only be sent from cell station, NowSMS is not capable of doing this.

Comment 52

[Eric Chang [:ericcc] [:echang]]

Verified landed in 
Gaia      fbb297c39aab5f17b179533d2a9a6c5166b2c197
Gecko     https://hg.mozilla.org/releases/mozilla-aurora/rev/fb5e796da813
BuildID   20140902160204
Version   34.0a2
ro.build.version.incremental=110
ro.build.date=Fri Jun 27 15:57:58 CST 2014
B1TC00011230