1015077 - Desktop client needs ringback visual and audio notification for outgoing calls

Status: RESOLVED DUPLICATE of bug 1065201

(Hello (Loop) :: Client, enhancement, P1)

Description

[Romain Testard [:RT]]

"Call ringing" is an indication that the other party is being notified of an incoming call.

Comment 1

[Romain Testard [:RT]]

This is required when clicking a call-back link on Firefox or when initiating a direct call from the desktop UI.

Comment 2

[Adam Roach [:abr]]

This isn't ringing; it's ringback: http://en.wikipedia.org/wiki/Ringback_tone

Comment 3

[Romain Testard [:RT]]

Attachment: Ringback Tone.mp3

Initial sound file which may change later.

Comment 4

[:shell escalante]

https://people.mozilla.org/~dhenein/labs/loop-mvp-spec/#call-outgoing

Comment 5

[Paul Silaghi, QA [:pauly]]

Comparing https://people.mozilla.org/~dhenein/labs/loop-mvp-spec/#call-outgoing with current aurora 33 results in several differences:
1. background photo
2. name
3. avatar
4. loading circle,
5. 'ringing...' text
6. cancel button
7. minimize, show in separate window, close buttons
Are those all handled in this bug ?

Comment 6

[Mark Banner (:standard8)]

This hasn't been implemented yet at all yet - the outgoing call scenario on the mvp spec is for direct calling only, which only comes when we have contacts.

I'm not sure which screen you're looking at in particular on Aurora, but I suspect it is covered by different bugs.

Comment 7

[Romain Testard [:RT]]

(In reply to Paul Silaghi, QA [:pauly] from comment #5)
> Comparing
> https://people.mozilla.org/~dhenein/labs/loop-mvp-spec/#call-outgoing with
Agreed, I don't think we got to the point where we could do a break-down. The breakdown should come under https://bugzilla.mozilla.org/show_bug.cgi?id=1046580 but the current "UX matching exercise" is about account-less mode (without conytacts or direct calling) as I understand it.

Comment 8

[Marco Mucci [:MarcoM]]

Hi Tomasz, can you assign a point value and mark the bug for QE verification.

Comment 9

[Mark Banner (:standard8)]

This work probably wants to be based on the work in bug 1065203. Note that the sound files are listed in bug 1065201 - the one attached here might be out of date.

Comment 10

[Tomasz Kołodziejski [:tomasz]]

This got blocked. Depending on the API developed in the other bug (will it magically work for the desktop client?) it may be 3 or 5 points. Maybe I'll assign the points later.

Also feel free <whoever knowing loop better than me> to assign the point value if you have better understanding of the difficulties here.

Comment 11

[Marco Mucci [:MarcoM]]

Thanks Tomasz.  I'll mark it blocked for IT 36.1

(In reply to Tomasz Kołodziejski [:tomasz] from comment #10)
> This got blocked. Depending on the API developed in the other bug (will it
> magically work for the desktop client?) it may be 3 or 5 points. Maybe I'll
> assign the points later.
> 
> Also feel free <whoever knowing loop better than me> to assign the point
> value if you have better understanding of the difficulties here.

Comment 12

[:shell escalante]

Hi Romain,

Is this the right sound here?  Or did that change?  I believe i lost the right sound file between 34 and 35 for this action - which still happens in 35.

Comment 13

[Romain Testard [:RT]]

No it's not.
My understanding was that all sounds had to be treated under a single bug hence i created the following:
Desktop client for Fx34: https://bugzilla.mozilla.org/show_bug.cgi?id=1065201
Clicker UI sounds for Fx34: https://bugzilla.mozilla.org/show_bug.cgi?id=1065203

These bugs could not make it in Fx34.

Fx35 sounds change slightly. For Fx35 desktop client sounds I created the following:
https://bugzilla.mozilla.org/show_bug.cgi?id=1088650

I recommend closing this bug as well as bug 1065201 and bug 1065203 to avoid confusion.

Comment 14

[Mark Banner (:standard8)]

I just chatted with RT about comment 13. Although bug 1088650 handles the new sounds, there's no change in the direct calling sounds.

I therefore recommend that we keep bug 1065201 and bug 1065203 for direct call implementation and use 1088650 for the rooms work.

Closing this one as a dupe of bug 1065201 as that's where we'll be doing the work.