Closed Bug 1015883 Opened 9 years ago Closed 8 years ago

[Dialer][Call Screen][Call Waiting] Apply the visual refresh to the CDMA call waiting scenario

Categories

(Firefox OS Graveyard :: Gaia::Dialer, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(blocking-b2g:-, ux-b2g:2.1)

RESOLVED FIXED
2.1 S1 (1aug)
blocking-b2g -
ux-b2g 2.1

People

(Reporter: gtorodelvalle, Assigned: gsvelto)

References

Details

(Whiteboard: [planned-sprint c=3])

Attachments

(10 files, 4 obsolete files)

17.46 KB, image/png
Details
11.16 KB, image/png
Details
2.39 MB, application/pdf
Details
6.11 KB, application/zip
Details
177.06 KB, image/png
Details
176.30 KB, image/png
Details
46 bytes, text/x-github-pull-request
Details | Review
63.91 KB, image/png
Details
62.69 KB, image/png
Details
19.15 KB, patch
rik
: review+
Carol
: ui-review+
Details | Diff | Splinter Review
The 2.0 visual refresh should be applied to the CDMA call waiting scenario since it is a special case allowing the user to attend one of the 2 ongoing calls.

Since it is a CDMA network functionality, I'll upload a couple of screenshots about how they look for the time being in desktop Firefox Nightly (thanks to Gabriele for the hack). Once there is a spec available and implemented, I guess we should ask someone in a CDMA network to try it for us :-)

I created this new bug not to block bug 951606 so we can land it ASAP. We would work in this bug as a follow-up.
Hi Vicky, do you know if there is a visual spec for this scenario? I only found the attachments included in bug 928700. Thanks!
Flags: needinfo?(vpg)
Depends on: 951606
(In reply to Germán Toro del Valle from comment #3)
> Hi Vicky, do you know if there is a visual spec for this scenario? I only
> found the attachments included in bug 928700. Thanks!

Germán, this is slightly different from the regular 2nd incomming call scenario but very similar, right? Since I am in WW right now, Pau will provide the adaptation of this scenario. PLease ping him if there's anything that should be different from this screens. (Since I never saw interactions specs for this case)
Thanks!
Flags: needinfo?(vpg) → needinfo?(b.pmm)
Hi Carrie! Looking at these mockups I have seen that there appears no "decline with message" button. Is this right? I've got to provide a proper visual mockup with its corresponding spec in order to implement correctly and I would need that info, please.

Thanks!
Flags: needinfo?(b.pmm) → needinfo?(cawang)
Attached file CDMA_call waiting_20131211.pdf (obsolete) —
Hi, UX spec attached here. Thanks!
Flags: needinfo?(cawang)
(In reply to Carrie Wang [:carrie] from comment #6)
> Created attachment 8429925 [details]
> CDMA_call waiting_20131211.pdf
> 
> Hi, UX spec attached here. Thanks!

Hey Carrie,

This spec is outdated and does not contain the new feature of "decline with message" that was later on incorporated. Can you please answer Pau with and updated spec so he can work on this screen? This is pretty urgent as it is blocking implementation.

Thanks!
Flags: needinfo?(cawang)
Hi Vicky, 

OK, we have another UX who works on CDMA part, so there might be a gap on spec transfer. In addition, the MADAI feature didn't update to CDMA spec. So, I've added it and uploaded here again. I think this is the correct one.
Flags: needinfo?(cawang)
Sprint 3 ends Friday and this bug is unassigned. Please let me know who is implementing this. Thank you!
Flags: needinfo?(jcheng)
ni? Etienne/Rik
Flags: needinfo?(jcheng)
Flags: needinfo?(etienne)
Flags: needinfo?(anthony)
No one. It wasn't ready for devs when we did our sprint planning and we're already swamped with work.
Flags: needinfo?(etienne)
Flags: needinfo?(anthony)
Joe or Wesley, please let me know if Rik's comment #13 means this will not make it or if there is something we can do here. Thanks!
Flags: needinfo?(whuang)
Flags: needinfo?(jcheng)
Just for the sake of clarity, you don't need extra visuals here as all components have already been designed and the only thing different to do is extending the "put on hold" button to be full width. And we can provide a nicer 2 arrow icon than the used in the current build. 

NI to Pau so he can provide the icon asset.
Flags: needinfo?(b.pmm)
For more context, we'll have to fix this before 2.0 ships. But unless some developer finds some free cycles (which I doubt), it will be after the "Feature Landing" period.

Also, CDMA development is harder because a lot of developers are not in countries with CDMA networks.
I might be able to work on this, not sure if I can make it by Friday though.
Attached file CDMA Assets (obsolete) —
This is the icon requested.
Flags: needinfo?(b.pmm)
Attachment #8434011 - Attachment is obsolete: true
Attached file CDMA Assets
Mockup of how this new icon should look like in context.
Edit assignee to Gabriele as he's working on it.
We didn't consider CDMA UI early enough in planning so the task came a little late. 
Very likely it won't be landed before FL.
Nominate to 2.0? to triage.
Assignee: nobody → gsvelto
blocking-b2g: --- → 2.0?
Flags: needinfo?(whuang)
Flags: needinfo?(jcheng)
Joe - Triage believes this should be tagged feature-b2g flag, not the blocker flag, as this is a missed feature needed for 2.0. Can you set the feature-b2g flag here?
blocking-b2g: 2.0? → ---
Flags: needinfo?(jcheng)
Wesley - Can you help with comment 23?
Flags: needinfo?(jcheng) → needinfo?(whuang)
Didn't hear strong request from partner for this. Let's defer the feature into 2.1.
Flags: needinfo?(whuang)
Flagging Vicky since she's been managing Comms VR, to ensure she is aware of this decision.
Flags: needinfo?(vpg)
Aware.
Flags: needinfo?(vpg)
Noted as no longer blocking 2.0.
No longer blocks: dialer-visual-refres
ux-b2g: --- → 2.1
Whiteboard: [planned-sprint c=3]
Target Milestone: --- → 2.1 S1 (1aug)
Status: NEW → ASSIGNED
This patch adjusts the CDMA call waiting scenario to match the visual refresh. Since the new appearance is simpler and less quirky than the old one I've taken the chance to clean up the CSS code and DOM:

- I've removed the shadow element which was used for a thin drop shadow in CDMA mode, it was a strange quirk we had only in that mode and I'm glad to see it go, the associated image has been removed.

- The switch-calls-button used to live in a special div (switch-calls) to the right of the numberWrapper for a number of reasons. This was also quirky and forced us to take it into account in a number of places in the CSS rules. Now the switch-calls div is gone and the button has been moved into the numberWrapper, this greatly simplifies the CSS code involved as well as making it more robust (it was brittle as hell before as it had very specific sizes and position).

- The assets for the button have been updated and the old ones removed. Note that the old assets were missing the high resolution icons so this is also very good.

- No changes were done to the unit-tests because the logic used to set the styles is unchanged (this was one of the few parts that was actually well done and robust to start with).

Pull request coming soon.
Attachment #8464025 - Flags: review?(anthony)
Gabriele: Can you join a screenshot and ask ui-review to Carol?
Flags: needinfo?(gsvelto)
Here are screenshots of both scenarios.
Flags: needinfo?(gsvelto)
Comment on attachment 8464028 [details] [review]
[PULL REQUEST] Applied the visual refresh to the CDMA call waiting scenario

Very well done in general.

Instead of doing the UI with floats, I'd rather use flexbox. Can you try this approach? If it requires too much work, we can keep the floats.
Attachment #8464025 - Flags: review?(anthony)
New, flexbox-infused patch, it was only a two-lines change fortunately. The PR was also updated.
Attachment #8464025 - Attachment is obsolete: true
Attachment #8464680 - Flags: review?(anthony)
This time for real ;-)
Attachment #8464680 - Attachment is obsolete: true
Attachment #8464680 - Flags: review?(anthony)
Attachment #8464690 - Flags: review?(anthony)
Attachment #8464690 - Flags: review?(anthony) → review+
Comment on attachment 8464690 [details] [diff] [review]
[PATCH v3] Applied the visual refresh to the CDMA call waiting scenario

Screenshots are in attachment 8464668 [details] and attachment 8464669 [details].
Attachment #8464690 - Flags: ui-review?(chuang)
Attachment #8464690 - Flags: ui-review?(chuang) → ui-review+
Pushed to gaia/master 7a5372714c8256fbe28c6be33423e8cff5839220
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
[Blocking Requested - why for this release]: If we intend to ship 2.0 on CDMA devices, I think we should take this patch. I'm not sure 2.0 is intended for CDMA devices though.
Before: attachment 8428606 [details]
After: attachment 8464669 [details]
blocking-b2g: --- → 2.0?
Wilfred - Can you weigh in from the product perspective if this CDMA visual refresh is still needed for 2.0 or not? We're past FC at this point, so triage would like to avoid introducing risk into the product at this time preferably.
Flags: needinfo?(wmathanaraj)
no devices that I am aware of planned for 2.0 on CDMA - but the work is there if any partner wants to take it for their specific release.
blocking-b2g: 2.0? → -
Flags: needinfo?(wmathanaraj)
I need some QA contact that test this bug. We can't test it because we haven't got SIM card with CDMA
You need to log in before you can comment on or make changes to this bug.