Use appropriate dependencies for the branch under test

RESOLVED FIXED

Status

Testing Graveyard
Eideticker
RESOLVED FIXED
4 years ago
9 months ago

People

(Reporter: davehunt, Assigned: davehunt)

Tracking

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Assignee)

Description

4 years ago
At the moment Eideticker is using gaiatest and b2gpopulate packages that are only guaranteed to support the master and mozilla-central branches. In bug 994176 we're going to be producing versions of these packages for the release branches such as v1.3 and v1.4.

Ideally we would avoid branching Eideticker in order to support these branches. Perhaps we could move these requirements out to files such as requirements-mozilla-b2g28_v1_3.txt and select the appropriate file based on the build under test.

This would mean we could only use methods used from these packages that are common across the branches, otherwise we'd need additional logic in Eideticker or would need to branch.
(Assignee)

Comment 1

4 years ago
Will: Any thoughts on this? I can experiment with splitting out the requirements into text files and conditionally picking one based on the target build.
Flags: needinfo?(wlachance)
(In reply to Dave Hunt (:davehunt) from comment #1)
> Will: Any thoughts on this? I can experiment with splitting out the
> requirements into text files and conditionally picking one based on the
> target build.

Yup, that makes sense to me. Note that you might need to modify setup.py in src/eideticker/setup.py to no longer explicitly list the dependencies, since the exact packages we're using will depend on the version.
Flags: needinfo?(wlachance)
(Assignee)

Updated

4 years ago
Blocks: 1002502
(Assignee)

Comment 3

4 years ago
I was thinking more about this and I don't think we can avoid branching. There are a couple of changes in the pipeline for gaiatest that will change our imports, so just depending on the appropriate version won't be enough. Maybe we could split the B2G parts into a submodule and only branch that, but I fear that would cause an even bigger headache.
Could we create a compatibility wrapper/module that we could import selectively for backwards compatibility? Ugly, but less so than branching most likely.
(Assignee)

Comment 5

4 years ago
Do you mean abstract gaiatest from Eideticker, and in this abstraction handle the branch appropriate imports and method calls? I think that would work, and is certainly less ugly than branching. We're only using gaiatest in a few places, and means all the ugliness and backward compatibility logic will be in one place.

Comment 6

4 years ago
Dave,
Are you taking this bug? It's blocking your existing patch for bug 1002502 but has no assignee.
Flags: needinfo?(dave.hunt)
(Assignee)

Comment 7

4 years ago
(In reply to Mike Lee [:mlee] from comment #6)
> Dave,
> Are you taking this bug? It's blocking your existing patch for bug 1002502
> but has no assignee.

Most likely, but this bug is also blocked on a bug that's assigned to me. :)
Flags: needinfo?(dave.hunt)
(Assignee)

Comment 8

4 years ago
I have an early proof-of-concept ready for feedback. Unfortunately this is sitting on my Eideticker dev laptop at home and I'm in the London office today. I'll try to remember to upload it this evening when I get home.
Assignee: nobody → dave.hunt
Status: NEW → ASSIGNED
(Assignee)

Comment 9

4 years ago
Created attachment 8438335 [details] [diff] [review]
Use appropriate dependencies for the branch under test. v1.0
Attachment #8438335 - Flags: feedback?(wlachance)
(Assignee)

Comment 10

4 years ago
Created attachment 8438336 [details] [diff] [review]
Use appropriate dependencies for the branch under test. v1.0

This is the correct patch.
Attachment #8438335 - Attachment is obsolete: true
Attachment #8438335 - Flags: feedback?(wlachance)
Attachment #8438336 - Flags: feedback?(wlachance)
Comment on attachment 8438336 [details] [diff] [review]
Use appropriate dependencies for the branch under test. v1.0

This all looks pretty reasonable to me!
Attachment #8438336 - Flags: feedback?(wlachance) → feedback+
(Assignee)

Comment 12

4 years ago
Comment on attachment 8438336 [details] [diff] [review]
Use appropriate dependencies for the branch under test. v1.0

Okay, I've tried (and failed) to replicate the update notifications on Tarako, so I think this is safe to request review. If the update notifications do show up, we can address this in bug 1023284 with a follow-up to this patch.
Attachment #8438336 - Flags: review?(wlachance)
Comment on attachment 8438336 [details] [diff] [review]
Use appropriate dependencies for the branch under test. v1.0

lgtm, as before
Attachment #8438336 - Flags: review?(wlachance) → review+
(Assignee)

Comment 14

4 years ago
Created attachment 8442009 [details] [diff] [review]
Use appropriate dependencies in CI. v1.0

This patch is for Eideticker CI, as the two should be landed at the same time.
Attachment #8442009 - Flags: review?(wlachance)
Comment on attachment 8442009 [details] [diff] [review]
Use appropriate dependencies in CI. v1.0

Review of attachment 8442009 [details] [diff] [review]:
-----------------------------------------------------------------

Awesome!
Attachment #8442009 - Flags: review?(wlachance) → review+
(Assignee)

Updated

4 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Flags: needinfo?(dave.hunt)
Resolution: --- → FIXED
(Assignee)

Updated

4 years ago
Duplicate of this bug: 991485

Updated

9 months ago
Product: Testing → Testing Graveyard
You need to log in before you can comment on or make changes to this bug.