Closed Bug 1017572 Opened 10 years ago Closed 10 years ago

[NFC] NfcManager proper handling of NDEF messages with no records

Categories

(Firefox OS Graveyard :: NFC, defect)

Product:
Firefox OS Graveyard
Component:
NFC
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(tracking-b2g:backlog, b2g-v2.0 fixed)

Status:
RESOLVED FIXED
Milestone:
2.0 S3 (6june)
Project Flags:
tracking-b2g backlog
Tracking Flags:
Tracking Status
b2g-v2.0 --- fixed

People

(Reporter: tauzen, Assigned: tauzen)

References

Details

Attachments

(1 file)

pull-request-1017572.txt
46 bytes, text/x-github-pull-request
gweng
: review+
Details | Review 
NfcManager, while handling tech NDEF and tech NDEF_WRITEABLE messages with no records, creates a MozNDEFRecord with invalid parameters, which causes invalid handling of the whole message.
Assignee: nobody → kmioduszewski
Blocks: 1006375, NFC-Gaia
Keywords: checkin-needed
Keywords: checkin-needed
blocking-b2g: --- → backlog

        Attachment #8432448 -
        Flags: review?(alive)

    
    

    
  
Comment on attachment 8432448 [details] [review]
pull-request-1017572.txt

Greg, please start to read and review NFC patches. If you feel you cannot review lemme know.

        Attachment #8432448 -
        Flags: review?(alive) → review?(gweng)

    
    

    
  
Comment on attachment 8432448 [details] [review]
pull-request-1017572.txt

I think this make code more clear and handle more possible states. Tests are also passed, so here is the r+.

        Attachment #8432448 -
        Flags: review?(gweng) → review+

    
  
Keywords: checkin-needed

    
    

    
  
Master: https://github.com/mozilla-b2g/gaia/commit/e794eeb8dcb308cd7b1580717ef38e2880987634
Status: NEW → RESOLVED
Closed: 10 years ago

          status-b2g-v2.0:
          --- → fixed
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 2.0 S3 (6june)

    
    

    
  
Reverted for frequent Gaia unit test failures.
Master: https://github.com/mozilla-b2g/gaia/commit/4152286b9cbadaa8fe2fecfa82226e99ae41a679

https://tbpl.mozilla.org/php/getParsedLog.php?id=41135842&tree=B2g-Inbound
Status: RESOLVED → REOPENED

          status-b2g-v2.0:
          fixed → ---
Resolution: FIXED → ---
Target Milestone: 2.0 S3 (6june) → ---

    
    

    
  
I've fixed this already in https://bugzilla.mozilla.org/show_bug.cgi?id=1020549 -> https://github.com/mozilla-b2g/gaia/commit/ac47da8f463aabcbf7d93aa76e3d517753d02302.

Sorry for even introducing this bug. Does anyone know why both unit tests and Travis were passing?

    
    

    
  
Sorry, I commented on a wrong bug.

    
    

    
  
Re-landed.
Master: https://github.com/mozilla-b2g/gaia/commit/5de1ef97904e4319aec20baf0e33a04dd97f4543
Status: REOPENED → RESOLVED
Closed: 10 years ago → 10 years ago

          status-b2g-v2.0:
          --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 2.0 S3 (6june)
blocking-b2g: backlog → ---

          tracking-b2g:
          --- → backlog

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: