[NFC] NfcManager proper handling of NDEF messages with no records

RESOLVED FIXED in Firefox OS v2.0

Status

Firefox OS
NFC
RESOLVED FIXED
4 years ago
3 years ago

People

(Reporter: tauzen, Assigned: tauzen)

Tracking

unspecified
2.0 S3 (6june)
x86
Mac OS X
Dependency tree / graph

Firefox Tracking Flags

(tracking-b2g:backlog, b2g-v2.0 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
NfcManager, while handling tech NDEF and tech NDEF_WRITEABLE messages with no records, creates a MozNDEFRecord with invalid parameters, which causes invalid handling of the whole message.
(Assignee)

Updated

4 years ago
Assignee: nobody → kmioduszewski
(Assignee)

Updated

4 years ago
Blocks: 1006375, 933640
(Assignee)

Updated

4 years ago
Keywords: checkin-needed
(Assignee)

Updated

4 years ago
Keywords: checkin-needed
blocking-b2g: --- → backlog
(Assignee)

Comment 1

4 years ago
Created attachment 8432448 [details] [review]
pull-request-1017572.txt
Attachment #8432448 - Flags: review?(alive)
Comment on attachment 8432448 [details] [review]
pull-request-1017572.txt

Greg, please start to read and review NFC patches. If you feel you cannot review lemme know.
Attachment #8432448 - Flags: review?(alive) → review?(gweng)
Comment on attachment 8432448 [details] [review]
pull-request-1017572.txt

I think this make code more clear and handle more possible states. Tests are also passed, so here is the r+.
Attachment #8432448 - Flags: review?(gweng) → review+
(Assignee)

Updated

4 years ago
Keywords: checkin-needed
Master: https://github.com/mozilla-b2g/gaia/commit/e794eeb8dcb308cd7b1580717ef38e2880987634
Status: NEW → RESOLVED
Last Resolved: 4 years ago
status-b2g-v2.0: --- → fixed
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 2.0 S3 (6june)
Reverted for frequent Gaia unit test failures.
Master: https://github.com/mozilla-b2g/gaia/commit/4152286b9cbadaa8fe2fecfa82226e99ae41a679

https://tbpl.mozilla.org/php/getParsedLog.php?id=41135842&tree=B2g-Inbound
Status: RESOLVED → REOPENED
status-b2g-v2.0: fixed → ---
Resolution: FIXED → ---
Target Milestone: 2.0 S3 (6june) → ---
I've fixed this already in https://bugzilla.mozilla.org/show_bug.cgi?id=1020549 -> https://github.com/mozilla-b2g/gaia/commit/ac47da8f463aabcbf7d93aa76e3d517753d02302.

Sorry for even introducing this bug. Does anyone know why both unit tests and Travis were passing?
Sorry, I commented on a wrong bug.
Re-landed.
Master: https://github.com/mozilla-b2g/gaia/commit/5de1ef97904e4319aec20baf0e33a04dd97f4543
Status: REOPENED → RESOLVED
Last Resolved: 4 years ago4 years ago
status-b2g-v2.0: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 2.0 S3 (6june)
blocking-b2g: backlog → ---
tracking-b2g: --- → backlog
You need to log in before you can comment on or make changes to this bug.