1017790 - Expose category information in the profiler data

Status: RESOLVED FIXED

(DevTools :: Performance Tools (Profiler/Timeline), defect)

Description

[Victor Porof [:vporof][:vp]]

Bug 1007203 adds categories to entries, but we still need to expose it in the profiler data.

Comment 1

[Victor Porof [:vporof][:vp]]

Attachment: v1

Comment 2

[Kannan Vijayan [:djvj]]

Comment on attachment 8432760 [details] [diff] [review]
v1

Review of attachment 8432760 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/public/ProfilingStack.h
@@ +116,5 @@
>      uint32_t flags() const volatile {
>          return flags_;
>      }
> +    uint32_t category() const volatile {
> +        return flags_ & ~IS_CPP_ENTRY & ~FRAME_LABEL_COPY;

It's better to define a constant CATEGORY_MASK, and have this expression be:

  return flags_ & CATEGORY_MASK

The definition of CATEGORY_MASK should be right alongside the definition of IS_CPP_ENTRY and FRAME_LABEL_COPY

Comment 3

[Victor Porof [:vporof][:vp]]

https://hg.mozilla.org/integration/fx-team/rev/748b4ffb759e

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/748b4ffb759e