Closed
Bug 1019182
Opened 10 years ago
Closed 10 years ago
ProfileEntry flags should be zeroed when setting frame data
Categories
(DevTools :: Performance Tools (Profiler/Timeline), defect)
DevTools
Performance Tools (Profiler/Timeline)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 32
People
(Reporter: vporof, Assigned: vporof)
References
Details
Attachments
(1 file)
|
5.81 KB,
patch
|
djvj
:
review+
|
Details | Diff | Splinter Review |
I noticed while working on bug 1017790. Since profile entries are never destroyed, whatever flags were set before stick around when frames are re-pushed onto the stack. We're doing the necessary work to handle IS_CPP_ENTRY and FRAME_LABEL_COPY, but previous category flags stick around. We should just throw away all the flags when setting new js/cpp frames, because the previous data is bound to be useless. We're actually doing this correctly IonMacroAssembler :)
|
Assignee | |
Comment 1•10 years ago
|
||
|
||
Updated•10 years ago
|
Attachment #8432749 -
Flags: review?(kvijayan) → review+
|
|
Assignee | |
Comment 2•10 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/d185d33cfce5
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/d185d33cfce5
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 32
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•