1018024 - [Flatfish] volume warning view does not fill tablet

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect)

Description

[Aras Balali Moghaddam]

Attachment: volume warning prompt but it does not fill the screen

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:29.0) Gecko/20100101 Firefox/29.0 (Beta/Release)
Build ID: 20140428193813

Steps to reproduce:

This is a responsive layout issue and I *think* this volume warning view only shows up the first time a headphone is plugged in
* Start playing music
* Turn screen off
* Plug in your headphones
* Turn the screen back on



Actual results:

* I see the high volume warning prompt but it does not fill the screen (see the screenshot)


Expected results:

* the alert view should fill the screen or at least be centred

Comment 1

[YF (Yang)]

Seem similar bug 1048804.

Comment 2

[YF (Yang)]

Due to https://github.com/mozilla-b2g/gaia/commit/56cc36a03b980729942fc6d34a87e997ccd0a033.


can use soundManager.resetToCEMaxVolume(); to reproduce.

Comment 3

[YF (Yang)]

Attachment: patch

A tentative changes, I did not successful check all affects, but I think it was worth, it to reduce the impact area.

It also makes the app install dialog is really centered. I don't know does this was included in the UI specification, the was intended to be implemented by bug 944653.

Comment 4

[YF (Yang)]

Comment on attachment 8527061 [details] [review]
patch

I just noticed the bug 944653 comment 2.

I feel the patch may have some deficiencies and omissions, but I did not think of a better way to handle it.

Comment 5

[[e-mail]]

Comment on attachment 8527061 [details] [review]
patch

Thanks for contribute! looks ok for a css only patch,
but please keep the style in apps/system/style/themes/default/core.css or confirm/alert dialog might fail.

please rebase the patch then ask review again.

Comment 6

[BMO Automation]

Firefox OS is not being worked on