Closed Bug 1018241 Opened 8 years ago Closed 8 years ago

Customize option in Search Messages continues to be wonky

Categories

(Thunderbird :: Search, defect)

31 Branch
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 33.0

People

(Reporter: alta88, Assigned: aceman)

References

Details

Attachments

(1 file)

Bug 549712 failed to fix or apparently understand the problem, despite a working patch as an example.

1. Closing the Customize dialog with a cancel or deletion or otherwise non selection to carry forward results in the menulist selecting the nonsensical and invalid "Customize..." item.
2. The filter is then allowed to be saved with this invalid value, creating a broken filter.
3. Attempting to edit such a filter again results in unexpected behavior.

Using a menulist's menuitem as a window opening option is abuse of menulist, but ok.  However, such an invalid menuitem cannot ever be a selected value.
Yes, I can reproduce the problem. Do you want to fix it or should I?
Version: unspecified → 31
Assignee: nobody → acelists
Blocks: 549712
Status: NEW → ASSIGNED
Attached patch patchSplinter Review
Would this suffice?
Attachment #8439546 - Flags: review?(mkmelin+mozilla)
Attachment #8439546 - Flags: feedback?(alta88)
Attachment #8439546 - Flags: feedback?(alta88) → feedback+
Comment on attachment 8439546 [details] [diff] [review]
patch

Review of attachment 8439546 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thx! r=mkmelin
Attachment #8439546 - Flags: review?(mkmelin+mozilla) → review+
Thanks.
Keywords: checkin-needed
Blocks: TB31found
https://hg.mozilla.org/comm-central/rev/dfcf4dadeaaf
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 33.0
You need to log in before you can comment on or make changes to this bug.