Closed
Bug 1019035
Opened 10 years ago
Closed 10 years ago
Rounded top-left corner on the toolbar while in display mode
Categories
(Firefox for Android Graveyard :: Awesomescreen, defect)
Tracking
(firefox34 verified)
RESOLVED
FIXED
Firefox 34
Tracking | Status | |
---|---|---|
firefox34 | --- | verified |
People
(Reporter: lucasr, Assigned: lucasr)
References
Details
Attachments
(3 files)
antlam has the details.
Comment 1•10 years ago
|
||
Proposed rounding of top left corner to complete the "tab" metaphor that currently exists to the right of the toolbar/URL bar.
Updated•10 years ago
|
Blocks: new-toolbar-v1
Assignee | ||
Comment 2•10 years ago
|
||
Assignee | ||
Comment 3•10 years ago
|
||
Comment on attachment 8472963 [details] [diff] [review] Rounded top-left corner on the toolbar while in display mode (r=mcomella) As per new design.
Attachment #8472963 -
Flags: review?(michael.l.comella)
Assignee | ||
Comment 4•10 years ago
|
||
Here's how it looks.
Comment on attachment 8472963 [details] [diff] [review] Rounded top-left corner on the toolbar while in display mode (r=mcomella) Review of attachment 8472963 [details] [diff] [review]: ----------------------------------------------------------------- Assuming the pop-in of the full urlbar while transitioning between states looks okay, lgtm. Disclaimer: I don't know much about using Paint/Path/Canvas.
Attachment #8472963 -
Flags: review?(michael.l.comella) → review+
Assignee: nobody → lucasr.at.mozilla
Status: NEW → ASSIGNED
Assignee | ||
Comment 6•10 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/e56bbc8b5bd0
Comment 7•10 years ago
|
||
Backed out along with the rest of the patch stack for robocop failures. https://hg.mozilla.org/integration/fx-team/rev/d18d3e14ac3e
Assignee | ||
Comment 8•10 years ago
|
||
The string changes in bug 1010741 caused the failures. Forgot to update the tests accordingly. Try build looks nice and green now, pushed: https://hg.mozilla.org/integration/fx-team/rev/479f3428fd81
Comment 9•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/479f3428fd81
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 34
Comment 10•10 years ago
|
||
Verified as fixed in: Build: Firefox for Android 34.0a1 (2014-08-19) Device: Samsung Galaxy S3 (Android 4.3)
status-firefox34:
--- → verified
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•