Rounded top-left corner on the toolbar while in display mode

RESOLVED FIXED in Firefox 34

Status

()

defect
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: lucasr, Assigned: lucasr)

Tracking

unspecified
Firefox 34
All
Android
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox34 verified)

Details

Attachments

(3 attachments)

(Assignee)

Description

5 years ago
antlam has the details.
Posted image mob_toolbar_new.png
Proposed rounding of top left corner to complete the "tab" metaphor that currently exists to the right of the toolbar/URL bar.
(Assignee)

Comment 3

5 years ago
Comment on attachment 8472963 [details] [diff] [review]
Rounded top-left corner on the toolbar while in display mode (r=mcomella)

As per new design.
Attachment #8472963 - Flags: review?(michael.l.comella)
(Assignee)

Comment 4

5 years ago
Posted image Screenshot
Here's how it looks.
Comment on attachment 8472963 [details] [diff] [review]
Rounded top-left corner on the toolbar while in display mode (r=mcomella)

Review of attachment 8472963 [details] [diff] [review]:
-----------------------------------------------------------------

Assuming the pop-in of the full urlbar while transitioning between states looks okay, lgtm.

Disclaimer: I don't know much about using Paint/Path/Canvas.
Attachment #8472963 - Flags: review?(michael.l.comella) → review+
Assignee: nobody → lucasr.at.mozilla
Status: NEW → ASSIGNED
Backed out along with the rest of the patch stack for robocop failures.
https://hg.mozilla.org/integration/fx-team/rev/d18d3e14ac3e
(Assignee)

Comment 8

5 years ago
The string changes in bug 1010741 caused the failures. Forgot to update the tests accordingly. Try build looks nice and green now, pushed:

https://hg.mozilla.org/integration/fx-team/rev/479f3428fd81
https://hg.mozilla.org/mozilla-central/rev/479f3428fd81
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 34
Verified as fixed in:
Build: Firefox for Android 34.0a1 (2014-08-19)
Device: Samsung Galaxy S3 (Android 4.3)
You need to log in before you can comment on or make changes to this bug.