1019035 - Rounded top-left corner on the toolbar while in display mode

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Awesomescreen, defect)

Description

[Lucas Rocha (:lucasr)]

antlam has the details.

Comment 1

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Attachment: mob_toolbar_new.png

Proposed rounding of top left corner to complete the "tab" metaphor that currently exists to the right of the toolbar/URL bar.

Comment 2

[Lucas Rocha (:lucasr)]

Attachment: Rounded top-left corner on the toolbar while in display mode (r=mcomella)

Comment 3

[Lucas Rocha (:lucasr)]

Comment on attachment 8472963 [details] [diff] [review]
Rounded top-left corner on the toolbar while in display mode (r=mcomella)

As per new design.

Comment 4

[Lucas Rocha (:lucasr)]

Attachment: Screenshot

Here's how it looks.

Comment 5

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8472963 [details] [diff] [review]
Rounded top-left corner on the toolbar while in display mode (r=mcomella)

Review of attachment 8472963 [details] [diff] [review]:
-----------------------------------------------------------------

Assuming the pop-in of the full urlbar while transitioning between states looks okay, lgtm.

Disclaimer: I don't know much about using Paint/Path/Canvas.

Comment 6

[Lucas Rocha (:lucasr)]

https://hg.mozilla.org/integration/fx-team/rev/e56bbc8b5bd0

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Backed out along with the rest of the patch stack for robocop failures.
https://hg.mozilla.org/integration/fx-team/rev/d18d3e14ac3e

Comment 8

[Lucas Rocha (:lucasr)]

The string changes in bug 1010741 caused the failures. Forgot to update the tests accordingly. Try build looks nice and green now, pushed:

https://hg.mozilla.org/integration/fx-team/rev/479f3428fd81

Comment 9

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/479f3428fd81

Comment 10

[Cristina Madaras, QA [:CristinaM]]

Verified as fixed in:
Build: Firefox for Android 34.0a1 (2014-08-19)
Device: Samsung Galaxy S3 (Android 4.3)