1020166 - Update IMEI tests to handle 1 and 2 IMEIs

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect, P1)

Description

[Zac C (:zac)]

Flame device should have two IMEIs reported in Gaia. Currently this is broken; see bug 1019783.

However when that bug is resolved, the tests that use IMEI (test_mmi.py and test_settings_device_info.py) need to be updated to handle both 1 and 2 IMEI devices

We can use the contents of the testvars file to set the expectation of 1 or 2 IMEI as the testvars file is configured precisely with the correct IMEIs depending upon device.

Update these tests to get the list of IMEI from the testvars file and loop through 1 or 2 of them in the UI.

Comment 1

[Zac C (:zac)]

Attachment: github pr

This needs a corresponding update in the Jenkins credentials and will also need to be patched to v1.4

Comment 2

[[:AndreiH]]

Now that patch has landed we need to resolve this.

https://github.com/mozilla-b2g/gaia/commit/c329a67bafe60032820ab64b52c07c22eeff114e

Comment 3

[Zac C (:zac)]

Still blocked by bug 1008737.

Comment 4

[Zac C (:zac)]

Comment on attachment 8434197 [details] [review]
github pr

Until the testvars files are updated on Jenkins this will fail but let's r? it locally in the meantime.

Comment 5

[Zac C (:zac)]

2.0 PR will come soon too

Comment 6

[Zac C (:zac)]

Attachment: github pr

Comment 7

[Robert Chira [:RobertC]]

Comment on attachment 8434197 [details] [review]
github pr

Comment in PR.

Comment 8

[raymond [:retornam] (inactive)]

Dwong will update this bug after we manually check and update the IMEI for all the FLAME devices we have.

Comment 9

[Dylan Chun Wong [:dwong]]

Does this mean all testvars should be updated to be an array? i.e. non dual SIM devices?

Comment 10

[raymond [:retornam] (inactive)]

(In reply to Dylan Chun Wong [:dwong] from comment #9)
> Does this mean all testvars should be updated to be an array? i.e. non dual
> SIM devices?

Dylan lets do this for all devices for now. Thanks

Comment 11

[Dylan Chun Wong [:dwong]]

A PR has been submitted to resolve Bug 1038079

Comment 12

[Zac C (:zac)]

*test_MMI.py only*

2.0:
https://github.com/mozilla-b2g/gaia/commit/6d3f100db3019619423639443fc772c6c3caa188
master:
https://github.com/mozilla-b2g/gaia/commit/528421f7bf2d8211b85162302c01452ef052ba54

test_settings_device_info is still awaiting resolution of https://bugzilla.mozilla.org/show_bug.cgi?id=1008737

Comment 13

[Florin Strugariu [:Bebe]]

Comment on attachment 8455224 [details] [review]
github pr

https://github.com/mozilla-b2g/gaia/commit/6d3f100db3019619423639443fc772c6c3caa188

Comment 14

[Zac C (:zac)]

Attachment: github pr

Should have fixed this one earlier, sorry :/

Comment 15

[Florin Strugariu [:Bebe]]

https://github.com/mozilla-b2g/gaia/commit/14e814a017f4b4575335b41e7a39a662fd76491f

Comment 16

[[:AndreiH]]

Attachment: Test MMI PR v2.0

Comment 17

[[:AndreiH]]

Comment on attachment 8456713 [details] [review]
Test MMI PR v2.0

Test MMI fix Merged on v2.0

https://github.com/mozilla-b2g/gaia/commit/404edc9230fb925a31845622a99de84fd35d1c7b

Comment 18

[[:AndreiH]]

Fix from bug 1008737 should be uplifted to v2.0 also