1021429 - [emulator][camera] Camera HAL for ICS emulator is unstable and causing gUM test case timeout

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Emulator, defect)

Description

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

According to bug 984274 comment #228, deadlock happened frequently while opening/closing camera HAL repetitively during the emulator mochitest.

Comment 1

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

@ayang, could you provide what you've found while investigating bug 984274? People can continue hunting the root case based on your work.

Comment 2

[Alfredo Yang (:alfredo)]

A deadlock at EmulatedCameraDevice::WorkerThread::stopThread() in android camera emulator HAL EmulatedCameraDevice.cpp.

Comment 4

[Alfredo Yang (:alfredo)]

I think it is not a dup, I still saw the deadlock log after bug 1022705 landed.
https://tbpl.mozilla.org/php/getParsedLog.php?id=42028723&full=1&branch=b2g-inbound

Comment 5

[Alfredo Yang (:alfredo)]

It also blocks other tests like ImageCapture test in bug 1069222.

Comment 6

[Alfredo Yang (:alfredo)]

Attachment: Wait for worker thread starting in startThread.

Fix emulated camera start/stop deadlock problem on try tests which open emulated camera preview.

Try result.
https://tbpl.mozilla.org/?tree=Try&rev=a3d17a2044f3

Comment 7

[Alfredo Yang (:alfredo)]

Attachment: use camera hal fix and enable gum test

Comment 8

[Alfredo Yang (:alfredo)]

Release on try looks good. Failures on debug are probably due to taking too long.

00:47:16     INFO -  14 INFO TEST-OK | /tests/b2g/components/test/mochitest/test_permission_gum_remember.html | took 52499ms

Comment 9

[Mike Habicher [:mikeh] (high bugzilla latency)]

Comment on attachment 8495738 [details] [review]
Wait for worker thread starting in startThread.

This looks good to me.

Comment 10

[Alfredo Yang (:alfredo)]

Hi schien, I try to fix the camera hal deadlock problem. There are 2 timeouts in try release  test_permission_gum_remember.html.
Do you think they are camera deadlock problem or other issue?

https://tbpl.mozilla.org/?tree=Try&rev=a3d17a2044f3

Comment 11

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

Comment on attachment 8495741 [details] [diff] [review]
use camera hal fix and enable gum test

Review of attachment 8495741 [details] [diff] [review]:
-----------------------------------------------------------------

My guess is there are some more issue in the gum test cases. I'll suggest no to turn on these test cases until we fix it.

::: b2g/config/emulator/sources.xml
@@ +6,5 @@
>    <!--original fetch url was https://git.mozilla.org/b2g-->
>    <remote fetch="https://git.mozilla.org/b2g" name="b2gmozilla"/>
>    <!--original fetch url was git://github.com/mozilla-b2g/-->
>    <remote fetch="https://git.mozilla.org/b2g" name="b2g"/>
> +  <remote fetch="https://github.com/alfredoyang" name="alfredo"/>

Why not commit your change directly to https://github.com/mozilla-b2g/android-development?

Comment 12

[Alfredo Yang (:alfredo)]

Comment on attachment 8495741 [details] [diff] [review]
use camera hal fix and enable gum test

Review of attachment 8495741 [details] [diff] [review]:
-----------------------------------------------------------------

::: b2g/config/emulator/sources.xml
@@ +6,5 @@
>    <!--original fetch url was https://git.mozilla.org/b2g-->
>    <remote fetch="https://git.mozilla.org/b2g" name="b2gmozilla"/>
>    <!--original fetch url was git://github.com/mozilla-b2g/-->
>    <remote fetch="https://git.mozilla.org/b2g" name="b2g"/>
> +  <remote fetch="https://github.com/alfredoyang" name="alfredo"/>

Ya, that's what I want to do next. :)

Comment 13

[Alfredo Yang (:alfredo)]

Hi sheriff, please help to commit the pull-request. Thanks.

Comment 14

[Ryan VanderMeulen [:RyanVM]]

emu-fix: https://github.com/mozilla-b2g/android-development/commit/c99e41d49f0b98eade30814e52c1de9e818def68

Comment 15

[Alfredo Yang (:alfredo)]

The result looks to open/close camera rapidly.

https://tbpl.mozilla.org/?tree=Try&rev=5be38715812c