784776 - build fails with clang 3.2

Status: RESOLVED FIXED

(Core :: General, defect)

Comment 1

[Jan Beich]

Attachment: Bug 784776 - Don't assume NULL is numeric.

mozilla-central-5b057a27cd0e/ipc/glue/CrossProcessMutex_unimplemented.cpp:43:10: error:
      cannot initialize return object of type 'CrossProcessMutexHandle'
      (aka 'unsigned long') with an rvalue of type 'nullptr_t'
  return NULL;
         ^~~~
/usr/include/sys/_null.h:35:14: note: expanded from macro 'NULL'
                ^~~~~~~

Comment 2

[Jan Beich]

Attachment: Bug 784776 - time() wants a pointer as an argument.

http://pubs.opengroup.org/onlinepubs/009696699/functions/time.html

mozilla-central-5b057a27cd0e/intl/locale/src/unix/nsDateTimeFormatUnix.cpp:103:8: error:
      no matching function for call to 'time'
  tt = time((time_t)NULL);
       ^~~~
/usr/include/time.h:150:8: note: candidate function not viable: no known conversion
      from 'time_t' (aka 'long') to 'time_t *' (aka 'long *') for 1st argument
time_t time(time_t *);
       ^

Comment 3

[Jan Beich]

Attachment: Bug 784776 - time() wants a pointer as an argument.

v2. Follow bug 783206 example and use nullptr.

Comment 4

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Comment on attachment 654347 [details] [diff] [review]
Bug 784776 - Don't assume NULL is numeric.

Use nullptr if it compiles here.

Comment 5

[Jan Beich]

(In reply to Chris Jones [:cjones] [:warhammer] from comment #4)
> Comment on attachment 654347 [details] [diff] [review]
> Bug 784776 - Don't assume NULL is numeric.
> 
> Use nullptr if it compiles here.

It doesn't (on 103383:e874475efe15).

ipc/glue/CrossProcessMutex_unimplemented.cpp:43:10: error:
      cannot initialize return object of type 'CrossProcessMutexHandle'
      (aka 'unsigned long') with an rvalue of type 'nullptr_t'
  return nullptr;
         ^~~~~~~
1 error generated.

Comment 6

[Jan Beich]

Attachment: Bug 784776 - Don't assume NULL is numeric. (hunspell)

Same as ipc/glue one. A warning turned into an error by -std=gnu++0x.

extensions/spellcheck/hunspell/src/affentry.hxx:87:94: error:
      cannot initialize a parameter of type 'unsigned short' with an rvalue of type
      'nullptr_t'
  ...char * word, int len, char in_compound, const FLAG needflag = NULL);
                                                        ^          ~~~~
extensions/spellcheck/hunspell/src/affentry.hxx:87:94: note:
      passing argument to parameter 'needflag' here
extensions/spellcheck/hunspell/src/affentry.hxx:150:103: error:
      cannot initialize a parameter of type 'unsigned short' with an rvalue of type
      'nullptr_t'
  ...* word, int len, int optflags, PfxEntry* ppfx, const FLAG needflag = NULL);
                                                               ^          ~~~~
extensions/spellcheck/hunspell/src/affentry.hxx:150:103: note:
      passing argument to parameter 'needflag' here
2 errors generated.

Comment 7

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 655381 [details] [diff] [review]
Bug 784776 - Don't assume NULL is numeric. (hunspell)

Shouldn't you use FLAG_NULL ?

Comment 8

[Jan Beich]

Attachment: Bug 784776 - Don't assume NULL is numeric. (hunspell)

(In reply to Olli Pettay [:smaug] from comment #7)
> Shouldn't you use FLAG_NULL ?

FLAG_NULL works, too.

Comment 9

[Olli Pettay [:smaug][[e-mail]]]

Though, I think we add a comment about the changes made to Mozilla's tree...
need to find the file where.

Comment 10

[Olli Pettay [:smaug][[e-mail]]]

Or maybe not... and this change is trivial anyway.

Comment 11

[Jan Beich]

(In reply to Olli Pettay [:smaug] from comment #9)
> Though, I think we add a comment about the changes made to Mozilla's tree...
> need to find the file where.

Someone else already submitted it upstream.

http://sourceforge.net/tracker/?func=detail&aid=3557292&group_id=143754&atid=756395

Comment 12

[Ryan VanderMeulen [:RyanVM]]

I updated README.hunspell in the Hunspell directory with this bug number before landing.

https://hg.mozilla.org/integration/mozilla-inbound/rev/b5078f2a37dd
https://hg.mozilla.org/integration/mozilla-inbound/rev/77cd258827fd
https://hg.mozilla.org/integration/mozilla-inbound/rev/7dd78bf25baa

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b5078f2a37dd
https://hg.mozilla.org/mozilla-central/rev/77cd258827fd
https://hg.mozilla.org/mozilla-central/rev/7dd78bf25baa

Comment 15

[Ryan VanderMeulen [:RyanVM]]

This never got upstreamed.