Closed
Bug 1022545
Opened 11 years ago
Closed 8 years ago
Library window needs improvement in High Contrast mode
Categories
(Firefox :: Theme, defect, P4)
Tracking
()
RESOLVED
FIXED
Firefox 51
| Tracking | Status | |
|---|---|---|
| firefox51 | --- | fixed |
People
(Reporter: Unfocused, Assigned: torroid, Mentored)
References
(Blocks 1 open bug)
Details
(Whiteboard: [good first bug][lang=css])
Attachments
(2 files)
|
256.38 KB,
image/png
|
Details | |
|
866 bytes,
patch
|
dao
:
review+
|
Details | Diff | Splinter Review |
Screenshot
The Library window needs some improvements to make it better when using High Contrast mode. See attached screenshot. Notably:
* Expanders in tree view lack contrast
* Gradient on toolbar should be removed, to improve contrast of toolbar items
Flags: firefox-backlog+
|
Reporter | |
Updated•11 years ago
|
Whiteboard: p=3
|
||
Updated•8 years ago
|
Points: --- → 3
Priority: -- → P3
Whiteboard: p=3
|
|
||
Updated•8 years ago
|
Assignee: nobody → dao+bmo
|
|
||
Comment 1•8 years ago
|
||
The expanders appear to be fixed. I think we just need to replace -moz-windows-compositor with -moz-windows-glass here:
https://hg.mozilla.org/mozilla-central/annotate/e56017a57ea7/browser/themes/windows/places/organizer.css#l186
Assignee: dao+bmo → nobody
Mentor: dao+bmo
Whiteboard: [good first bug][lang=css]
|
|
||
Updated•8 years ago
|
Component: Places → Theme
Product: Toolkit → Firefox
|
|
||
Updated•8 years ago
|
Priority: P3 → P4
|
Assignee | |
Comment 2•8 years ago
|
||
Hi! I hope this is not wrong.
Attachment #8782134 -
Flags: review?(dao+bmo)
|
|
||
Comment 3•8 years ago
|
||
Comment on attachment 8782134 [details] [diff] [review]
Replaced -moz-windows-compositor with -moz-windows-glass
Looks good!
Attachment #8782134 -
Flags: review?(dao+bmo) → review+
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/295286b531c7
Use -moz-windows-glass instead of -moz-windows-compositor. r=dao
|
|
||
Updated•8 years ago
|
Assignee: nobody → glenn28f
|
||
Comment 5•8 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox51:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 51
|
|
Assignee | |
Comment 6•8 years ago
|
||
Please could you suggest me a few bugs to get going.
Flags: needinfo?(dao+bmo)
|
|
||
Comment 7•8 years ago
|
||
(In reply to Glenn from comment #6)
> Please could you suggest me a few bugs to get going.
Bug 1296945 maybe? It's again a small bug, maybe not ideal if you're looking for some bigger task now.
Flags: needinfo?(dao+bmo)
You need to log in
before you can comment on or make changes to this bug.
Description
•