Closed
Bug 1022765
Opened 10 years ago
Closed 10 years ago
Esc doesn't open the console on the first try
Categories
(DevTools :: Framework, defect, P1)
Tracking
(firefox40 verified)
VERIFIED
FIXED
Firefox 40
Tracking | Status | |
---|---|---|
firefox40 | --- | verified |
People
(Reporter: canuckistani, Assigned: ochameau)
References
(Blocks 1 open bug)
Details
(Whiteboard: [polish-backlog][bugday-20150610])
Attachments
(1 file)
2.03 KB,
patch
|
pbro
:
review+
|
Details | Diff | Splinter Review |
STR: 1. open the inspector 2. click on a node in the markup view to select it 3. hit Esc to call up the console Results: * the first one fails, but the second one works. Subsequent attempts always work the first time until you click back into the inspector Expected: * hitting escape should always toggle the console wen you are in a tool pane that isn't the console ( this works on chrome )
Reporter | ||
Updated•10 years ago
|
Blocks: DevToolsPaperCuts
Updated•10 years ago
|
Whiteboard: [devedition-40]
Reporter | ||
Updated•10 years ago
|
Priority: -- → P1
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → poirot.alex
Assignee | ||
Comment 1•10 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=bfb6c09c8f42
Assignee | ||
Comment 2•10 years ago
|
||
In tooltip.js, we shouldn't set a `() => false` rejection listener as it makes the returned promise to *resolve* instead of *rejects*. http://mxr.mozilla.org/mozilla-central/source/browser/devtools/shared/widgets/Tooltip.js#422 Here, we are expecting the promise to *reject* when we don't want to show the tooltip. At the end, we were unexpectedly trying to show this tooltip. It was invisible, we the Tooltip code from here: http://mxr.mozilla.org/mozilla-central/source/browser/devtools/shared/widgets/Tooltip.js#207 was dismissing the first ESC keypress.
Assignee | ||
Updated•10 years ago
|
Attachment #8591714 -
Flags: review?(pbrosset)
Comment 3•10 years ago
|
||
Oh, this is in fact a duplicate of bug 988278 which I fixed last week :| I didn't fix it the same way though. My approach was that the tooltip shouldn't even try to handle keypress events if it's hidden: https://hg.mozilla.org/mozilla-central/diff/67683aaa2041/browser/devtools/shared/widgets/Tooltip.js This fix landed on m-c yesterday.
Assignee | ||
Comment 4•10 years ago
|
||
(In reply to Patrick Brosset [:pbrosset] [:patrick] from comment #3) > I didn't fix it the same way though. My approach was that the tooltip > shouldn't even try to handle keypress events if it's hidden: The offending tooltip isn't hidden by the time we hit ESC in this STR.
Updated•10 years ago
|
Attachment #8591714 -
Flags: review?(pbrosset) → review+
Updated•10 years ago
|
Status: NEW → ASSIGNED
Component: Developer Tools → Developer Tools: Framework
Assignee | ||
Comment 5•10 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=c86bcfdb8ef1
Keywords: checkin-needed
https://hg.mozilla.org/integration/fx-team/rev/24f64f2412f0
Keywords: checkin-needed
Whiteboard: [devedition-40] → [devedition-40][fixed-in-fx-team]
Comment 7•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/24f64f2412f0
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
status-firefox40:
--- → fixed
Resolution: --- → FIXED
Whiteboard: [devedition-40][fixed-in-fx-team] → [devedition-40]
Target Milestone: --- → Firefox 40
Updated•10 years ago
|
QA Whiteboard: [good first verify]
Comment 8•10 years ago
|
||
Followed STR in Windows 7 32 Bit Version: 40.0a2 Build ID: 20150513004008 User Agent: Mozilla/5.0 (Windows NT 6.1; rv:40.0) Gecko/20100101 Firefox/40.0 Status:--> Resolved Fixed
Comment 9•9 years ago
|
||
I have reproduced this bug with Nightly 32.0a1 (2014-06-09) with instruction from comment 0 and Linux x86. Verified as fixed with latest Nightly 41.0a1 (2015-06-09) (Build ID:20150609081916) Mozilla/5.0 (X11; Linux i686; rv:41.0) Gecko/20100101 Firefox/41.0
Comment 10•9 years ago
|
||
As per Comment 8 and Comment 9, The bug is fixed now!
Status: RESOLVED → VERIFIED
QA Whiteboard: [good first verify] → [good first verify][bugday-20150610]
Whiteboard: [devedition-40] → [devedition-40][bugday-20150610]
Reporter | ||
Updated•9 years ago
|
Whiteboard: [devedition-40][bugday-20150610] → [polish-backlog][bugday-20150610]
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•