1022765 - Esc doesn't open the console on the first try

Status: VERIFIED FIXED

(DevTools :: Framework, defect, P1)

Description

[Jeff Griffiths (:canuckistani) (:⚡︎)]

STR:

1. open the inspector
2. click on a node in the markup view to select it
3. hit Esc to call up the console

Results:

* the first one fails, but the second one works. Subsequent attempts always work the first time until you click back into the inspector

Expected:

* hitting escape should always toggle the console wen you are in a tool pane that isn't the console ( this works on chrome )

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: patch v1

https://treeherder.mozilla.org/#/jobs?repo=try&revision=bfb6c09c8f42

Comment 2

[Alexandre Poirot [:ochameau]]

In tooltip.js, we shouldn't set a `() => false` rejection listener as it makes the returned promise to *resolve* instead of *rejects*.

http://mxr.mozilla.org/mozilla-central/source/browser/devtools/shared/widgets/Tooltip.js#422
Here, we are expecting the promise to *reject* when we don't want to show the tooltip.

At the end, we were unexpectedly trying to show this tooltip. It was invisible, we the Tooltip code from here:
  http://mxr.mozilla.org/mozilla-central/source/browser/devtools/shared/widgets/Tooltip.js#207
was dismissing the first ESC keypress.

Comment 3

[Patrick Brosset <:pbro>]

Oh, this is in fact a duplicate of bug 988278 which I fixed last week :|
I didn't fix it the same way though. My approach was that the tooltip shouldn't even try to handle keypress events if it's hidden: https://hg.mozilla.org/mozilla-central/diff/67683aaa2041/browser/devtools/shared/widgets/Tooltip.js
This fix landed on m-c yesterday.

Comment 4

[Alexandre Poirot [:ochameau]]

(In reply to Patrick Brosset [:pbrosset] [:patrick] from comment #3)
> I didn't fix it the same way though. My approach was that the tooltip
> shouldn't even try to handle keypress events if it's hidden:

The offending tooltip isn't hidden by the time we hit ESC in this STR.

Comment 5

[Alexandre Poirot [:ochameau]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c86bcfdb8ef1

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/integration/fx-team/rev/24f64f2412f0

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/24f64f2412f0

Comment 8

[Sayed Mohammad Amir [:smamir]]

Followed STR in Windows 7 32 Bit
Version: 40.0a2
Build ID: 20150513004008
User Agent: Mozilla/5.0 (Windows NT 6.1; rv:40.0) Gecko/20100101 Firefox/40.0
Status:--> Resolved Fixed

Comment 9

[Forhad Hossain]

I have reproduced this bug with Nightly 32.0a1 (2014-06-09)  with instruction from comment 0 and Linux x86.     

Verified as fixed with latest Nightly 41.0a1 (2015-06-09) (Build ID:20150609081916)

Mozilla/5.0 (X11; Linux i686; rv:41.0) Gecko/20100101 Firefox/41.0

Comment 10

[Hossain Al Ikram [:ikram] (QA Contact)]

As per Comment 8 and Comment 9, The bug is fixed now!