Closed
Bug 1023197
Opened 10 years ago
Closed 10 years ago
[Mulet] keyboard unit test render_test.js fails because it rely on specific Linux fontconfig
Categories
(Firefox OS Graveyard :: Gaia::Keyboard, defect)
Tracking
(Not tracked)
RESOLVED
DUPLICATE
of bug 1080285
People
(Reporter: gerard-majax, Assigned: gerard-majax)
References
Details
Attachments
(1 file)
244.64 KB,
text/x-log
|
Details |
Running keyboard tests against mulet fails:
> 1) [keyboard-test/unit/render_test.js] Renderer resizeUI Key with ratio 2 should be twice as big:
> Uncaught Error: Error: expected 797 to equal 796 (http://keyboard.gaiamobile.org:8080/common/test/helper.js?time=1402309901628:33)
> at onerror (http://keyboard.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4959:7)
There is a similar behavior when running unit tests against b2g
Assignee | ||
Updated•10 years ago
|
OS: Gonk (Firefox OS) → Linux
Hardware: ARM → x86_64
Comment 1•10 years ago
|
||
Is there any bug for removing this test from b2g desktop blacklist? https://github.com/mozilla-b2g/gaia/blob/master/tests/python/gaia-unit-tests/gaia_unit_test/disabled.json#L4
Assignee | ||
Comment 2•10 years ago
|
||
Can we get input from Keyboard owners?
Flags: needinfo?(rlu)
Flags: needinfo?(janjongboom)
Flags: needinfo?(dflanagan)
Comment 3•10 years ago
|
||
I encounter this issue on Firefox Mac and I suspect this is because render_test.js rely on specific font dimensions. Not sure if this is what Alex (and Alex) is seeing. Rudy, can you fix this? This is annoying and blocking us from working effectively.
Summary: [Mulet] keyboard unit test render_test.js fails → [Mulet] keyboard unit test render_test.js fails because it rely on specific Linux fontconfig
Comment 4•10 years ago
|
||
I'll take a look if I have free cycles this week.
Assignee: nobody → rlu
Flags: needinfo?(rlu)
Flags: needinfo?(janjongboom)
Flags: needinfo?(dflanagan)
Assignee | ||
Comment 5•10 years ago
|
||
(In reply to Tim Guan-tin Chien [:timdream] (MoCo-TPE) (please ni?) from comment #3) > I encounter this issue on Firefox Mac and I suspect this is because > render_test.js rely on specific font dimensions. Not sure if this is what > Alex (and Alex) is seeing. I'm running this on Linux (Ubuntu 13.10), I don't know if it has an impact.
Comment 6•10 years ago
|
||
These are rounding bugs, just run the tests with the responsive view on, and on a 320x480 resolution. Or we can fix it by allowing 1px difference (which we did in other tests), but as long as it passes on Travis I don't really care.
Assignee | ||
Comment 7•10 years ago
|
||
(In reply to Jan Jongboom [:janjongboom] (Telenor) from comment #6) > These are rounding bugs, just run the tests with the responsive view on, and > on a 320x480 resolution. Or we can fix it by allowing 1px difference (which > we did in other tests), but as long as it passes on Travis I don't really > care. Jan, we hope to kill Travis :)
Comment 8•10 years ago
|
||
s/Travis/Try
Assignee | ||
Comment 9•10 years ago
|
||
Passing when run with: > FIREFOX=../gecko/obj-mulet/dist/bin/firefox ./bin/gaia-test And executed as: > make test-agent-test APP=keyboard 2>&1 | tee mulet-keyboard-unit-tests.log It finishes as: > > 2322 passing (3s) > So this part seems to be good.
Assignee | ||
Comment 10•10 years ago
|
||
Looks like it's now passing.
Assignee: rlu → lissyx+mozillians
Status: NEW → ASSIGNED
Assignee | ||
Comment 11•10 years ago
|
||
From attachment 8525229 [details] > ✓ [keyboard-test/unit/render_test.js] Key with ratio 2 should be twice as big
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Comment 12•10 years ago
|
||
I think this has been addressed by Bug 1080285 with Kevin's help.
Resolution: FIXED → DUPLICATE
You need to log in
before you can comment on or make changes to this bug.
Description
•