1023329 - [VsD Refresh] Lockscreen Visual Refresh > Color overlay with notifications wrong with wallpapers chosen from gallery and camera

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System::Lockscreen, defect)

Description

[John Lu [:mnjul][Please NI or I'll miss]]

The color overlay (average color of wallpaper) when there are notifications in lockscreen, as specified in bug 950884, only works correctly when the wallpaper is picked from "wallpaper", and not from "gallery" or a picture taken from camera on-the-spot. With the latter two approaches of choosing wallpapers, the overlay color will not be calculated at all, remaining being the color of the old wallpaper.

Comment 1

[John Lu [:mnjul][Please NI or I'll miss]]

Attachment: Patch (Github PR)

Comment 2

[John Lu [:mnjul][Please NI or I'll miss]]

Comment on attachment 8439795 [details] [review]
Patch (Github PR)

O-kay, here is the big, big patch.

The fundamental issue of this bug is that I only implemented average color calculation for the wallpaper picker in the wallpaper app, which would be entirely useless if the wallpaper was chosen from the inline activity of gallery or camera. So the calculation mechanism must be moved from wallpaper app to lockscreen (or other apps/objects if more suitable) --and this patch moves/reverts some changes in bug 950884 related to this average color calculation functionality.

With this patch, when the lockscreen observes change of wallpaper, it is responsible to calculate the average wallpaper color. Note that the wallpaper app has a canvas for the wallpaper when picking, but gallery/camera don’t, and we need to redo the canvas drawing in lockscreen when calculating average color. To reduce computation/performance overhead for color calculation, in this patch I have:
1. Downsampled (by image dimension) the drawn wallpaper image; the longest edge of the drawn-to-canvas image would be 100*DEVICE_PX. Visually the resulting average color has nearly no difference from that of full-sized wallpaper [1].
2. Deferred the calculation of wallpaper average color from [when wallpaper image is selected] to [when device is locked]. This can reduce the device lag-ness when choosing wallpaper.

[1] FYI, on Flame, calculating the average color from a 480x800 full-size wallpaper would take 600~800ms, while with the reduced-size wallpaper (150*250) it takes less than 100ms.

Comment 3

[Greg Weng [:snowmantw][:gweng][:λ]]

 Well it's embarrassing: conflicts occur...

Comment 4

[John Lu [:mnjul][Please NI or I'll miss]]

Conflicts are resolved, waiting for Travis & TPBL's pass...

Comment 5

[John Lu [:mnjul][Please NI or I'll miss]]

Things are green again now, so Greg, please review the patch for me, thanks.

Comment 6

[Greg Weng [:snowmantw][:gweng][:λ]]

Comment on attachment 8439795 [details] [review]
Patch (Github PR)

Please fix the nit (function designation) I mentioned on the GitHub page, thanks.

Comment 7

[John Lu [:mnjul][Please NI or I'll miss]]

I'm waiting for tests to pass for final landing.

For future uplift reference: in this bug, I made changes to modifications by bug 1024395; but bug 1024395 itself will not be uplifted to 2.0 branch because bug 973443 will not be uplifted. So when we're uplifting patch for this bug (as this bug is blocking-2.0), we might have to resolve conflicts manually.

Comment 9

[John Lu [:mnjul][Please NI or I'll miss]]

Master: https://github.com/mozilla-b2g/gaia/commit/419ef484139f06a4c62fdd31d8241cfa71b80a25

Comment 10

[John Lu [:mnjul][Please NI or I'll miss]]

As this is a 2.0 blocker, I will uplift the patch to 2.0 by myself (partly because need for potential conflict resolution as said in comment 7)

Comment 11

[John Lu [:mnjul][Please NI or I'll miss]]

Attachment: 2.0 uplift PR @ Github

Comment 13

[John Lu [:mnjul][Please NI or I'll miss]]

v2.0: https://github.com/mozilla-b2g/gaia/commit/729f214b887ce8efe7d870145d31acb2c6427817