Closed Bug 1023516 (srcset-tests) Opened 6 years ago Closed 5 years ago

Add tests for basic <img srcset>

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla36

People

(Reporter: johns, Assigned: johns)

References

()

Details

Attachments

(1 file)

This tracks adding tests for the basic (non-sizes) <img srcset> syntax

Syntax tests for the newer parse algorithm will be covered by Bug 1023514
Depends on: srcset
Summary: Add basic tests for <img srcset> → Add tests for basic <img srcset>
Blocks: 1023519
Depends on: 1025833
Reftests to make sure the features of srcset behave as they should. This is only testing srcset, not sizes nor <picture>, which are bug 1023519

Bug 1037643 has the tests for mutating img, removing/adding srcset, etc.
Bug 1023514 will cover ensuring we parse srcset properly

Let me know if you can think of anything else we should have coverage for before pref'ing this on
Attachment #8501390 - Flags: review?(jst)
I should mention that the tests differing only in scale factor are script generated duplicates, e.g.

> image-srcset-basic-selection-0.1x.html
> image-srcset-basic-selection-2x.html
> image-srcset-basic-selection-0.5x.html
> image-srcset-basic-selection-0.6x.html
> image-srcset-basic-selection-1.5x.html
> image-srcset-basic-selection-1x.html

Will all be identical outside of scale factor, which has to be specified on a per-file basis for the reftest harness
Attachment #8501390 - Flags: review?(jst) → review+
https://hg.mozilla.org/mozilla-central/rev/60ce1e142f90
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.