1023957 - Disable the in-content preferences for Firefox 32

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect)

Description

[Jared Wein [:jaws] (please needinfo? me)]

The preferences were enabled by bug 738797 but they weren't ready to ship in 32. We should disable them on Aurora 32.

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Patch

https://tbpl.mozilla.org/?tree=Try&rev=cf26f9c4880c

Comment 2

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Comment on attachment 8438706 [details] [diff] [review]
Patch

Review of attachment 8438706 [details] [diff] [review]:
-----------------------------------------------------------------

Don't ship it!

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8438706 [details] [diff] [review]
Patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): we are delaying shipping in-content prefs until firefox 33 (see bug 1014201)
User impact if declined: in-content prefs will be shipped to users with 32 and it's not ready in 32
Testing completed (on m-c, etc.): locally, pushed to try, simple pref flip
Risk to taking this patch (and alternatives if risky): none expected
String or IDL/UUID changes made by this patch: none

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

Marco, can you please add this bug to the current iteration?

Comment 5

[Marco Mucci [:MarcoM]]

Added to Iteration 33.1

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/fx-team/rev/bd48de0a468d

Comment 7

[Carsten Book [:Tomcat]]

sorry had to back this change out since it caused test regressions like https://tbpl.mozilla.org/php/getParsedLog.php?id=41942658&tree=Fx-Team

Comment 8

[Dão Gottwald [:dao]]

This wasn't even supposed to land on mozilla-central / fx-team.

Comment 9

[Jared Wein [:jaws] (please needinfo? me)]

I wasn't sure between status-firefox32:fixed or status-firefox32:disabled, considering that this 'disabled' the feature for 32 but the point of fixing the bug is to disable the feature. Consider me confused.

https://hg.mozilla.org/releases/mozilla-aurora/rev/67c27d331c7f

Comment 10

[Jared Wein [:jaws] (please needinfo? me)]

(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #9)
> I wasn't sure between status-firefox32:fixed or status-firefox32:disabled,
> considering that this 'disabled' the feature for 32 but the point of fixing
> the bug is to disable the feature. Consider me confused.

Ok, to finish my conversation with myself, this is the right thing. I have updated bug 738797 to mark as status-firefox32:disabled.

Comment 11

[Marco Mucci [:MarcoM]]

Hi Florin, can a contact be assigned for QA verification.

Comment 12

[[SV Manager] Florin Mezei, QA (:FlorinMezei)]

I've verified this on Windows, Mac OS and Linux:
- Aurora from June 18 shows in-content preferences
- Aurora from June 19 shows old preferences window
Custom preferences are kept when moving from a version with new in-content preferences to latest version with old preferences style.