1024460 - In multiconference, Contact's name or phone number is duplicate.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[Loli (:lolimartinezcr)]

Attachment: 2014-06-12-14-33-09.png

Hamachi
2.0
Gecko-fcf1d2a
Gaia-2bb6663

Reproducible: 100%

Pre-requisites: Multiconference established.

STR:
Tap right arrow and display the list of contacts.

Actual result:
See attached image. Duplicate contact's name and phone numbers

Expected result:
Not duplicate contact's name and phone numbers

Comment 1

[Maria Angeles Oteo (:oteo)]

Regression, working fine in v1.4 version

Tested on hamachi v1.4 version:
B-90
Gecko-dcfc7e2
Gaia-43da854
Platform version:30.0
BuildID:20140612024834

Comment 2

[Doug Sherk (:drs) (inactive)]

This is the regressing commit: https://github.com/mozilla-b2g/gaia/commit/9b6df0c59f15dd20a3d0c29731b02f36fc5544c4

Stealing.

Comment 3

[Doug Sherk (:drs) (inactive)]

Attachment: Fix duplicate contact names and phone numbers in the conference participant list.

PR: https://github.com/mozilla-b2g/gaia/pull/21145 (on top of bug 1031916)

The problem was that an old selector that we had for .fake-number had gone stale and wasn't being used for this field, so we had two instances of the phone number / contact name fields (one real and one hidden). We also weren't correctly styling the additional contact details anymore as they were grey and italic in the conference participant list.

I did some testing to make sure that this didn't regress anything on the main call screen and in the conference participant list, and it seems to be fine.

Comment 4

[Doug Sherk (:drs) (inactive)]

https://github.com/mozilla-b2g/gaia/commit/dbc51caee87b421685c15c4c61a7d0ae5a9a1ad4

Comment 5

[(PTO June 19-July 7) Ryan VanderMeulen]

v2.0: https://github.com/mozilla-b2g/gaia/commit/72df6446fb7f81de2beb3fa09e69d535f4470e2e

Comment 6

[Loli (:lolimartinezcr)]

Tested and working
Hamachi
2.0
Gecko-e50f6b7
Gaia-3bfe47c

Hamachi
2.1
Gecko-4b0c03f
Gaia-c13308f

Comment 7

[Elie]

Attachment: IMAG0009.jpg

This issue has been successfully verified on Flame 2.0:
Gaia-Rev        8d1e868864c8a8f1e037685f0656d1da70d08c06
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/c756bd8bf3c3
Build-ID        20141130000204
Version         32.0
Device-Name     flame
FW-Release      4.4.2


This issue has been successfully verified on Flame 2.1:
Gaia-Rev        ccb49abe412c978a4045f0c75abff534372716c4
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/18fb67530b22
Build-ID        20141130001203
Version         34.0
Device-Name     flame
FW-Release      4.4.2