1031916 - [Dialer][Conference] Conference call status bar is invisible, can't exit conference call view

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[Doug Sherk (:drs) (inactive)]

STR:
1) Get into a state where you have 2 active calls.
2) Merge those calls.
3) The conference call status bar is missing.

Cursory note from my bisecting/debugging:
I believe this is a regression from the last 2 weeks or so, but I'll bisect it further. Also, I don't see any errors in logcat yet.

Comment 1

[Doug Sherk (:drs) (inactive)]

Only v2.1 is affected. Another bug I noticed is that you can end the conference call by hitting the hangup button, but it won't actually change the visual state, so you get stuck in the broken conference call view. I'm keeping these bugs together here because I'm guessing that they're directly related.

Comment 2

[Doug Sherk (:drs) (inactive)]

The regressing commit is https://github.com/mozilla-b2g/gaia/commit/ce1a8ea7f6ef1381f39acec993d83752c58f4a81

Comment 3

[Doug Sherk (:drs) (inactive)]

Attachment: Fix bad check for hasOwnProperty on telephony.conferenceGroup.

PR: https://github.com/mozilla-b2g/gaia/pull/21141

This was happening because we were using hasOwnProperty on mozTelephony's conferenceGroup field. This is provided by an IDL file through XPCOM, which hasOwnProperty doesn't seem to support. You can confirm this really quickly by checking |console.hasOwnProperty('log') => false| in your console.

Comment 4

[Doug Sherk (:drs) (inactive)]

https://github.com/mozilla-b2g/gaia/commit/05a0303d554dfe44e8dad131ce62a4e382872aee

Comment 5

[bhavana bajaj [:bajaj]]

Switching the 2.1?->2.1+, on these fixed bugs as these are regression.

Nothing to land here, its just flag-cleanup of 2.1? list. Please Ni me if there is confusion/disagreement.

Comment 6

[Fred Muyumba [:FredM]]

This issue is verified fixed on Flame 2.2 Master KK (319mb) (Full Flash) and Flame 2.1 KK (319mb) (Full Flash)

Environmental Variables:
Device:2.2 Master KK (319mb) (Full Flash)
BuildID: 20141010040202
Gaia: 1036b544b7e102592bd9fab95cd9317329ac1293
Gecko: 50b689feab5f
Gonk: 52c909e821d107d414f851e267dedcd7aae2cebf
Version: 35.0a1 
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0


Environmental Variables:
Device: Flame 2.1 KK (319mb) (Full Flash)
BuildID: 20141010000201
Gaia: bc8eb493311c58f1f311a56b8b645b52bfbd2f71
Gecko: 72c13d8631ff
Gonk: 52c909e821d107d414f851e267dedcd7aae2cebf
Version: 34.0a2
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0
BuildID: 20141010000201
Gaia: bc8eb493311c58f1f311a56b8b645b52bfbd2f71
Gecko: 72c13d8631ff
Gonk: 52c909e821d107d414f851e267dedcd7aae2cebf
Version: 34.0a2 (2.1)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Result: The conference status bar is VISIBLE and the user CAN exit the conference call view