1024787 - Fix uncaught promise rejections in DevTools framework

Status: RESOLVED FIXED

(DevTools :: General, defect)

Description

[Jordan Santell [:jsantell] [@jsantell]]

When uncaught promise rejections throw errors, the following occur in framework:

0:38.24 TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/framework/test/browser_devtools_api.js | A promise chain failed to handle a rejection at resource://gre/modules/commonjs/toolkit/loader.js -> resource:///modules/devtools/framework/toolbox.js:901 - TypeError: this.doc is undefined
 0:38.24 TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/framework/test/browser_new_activation_workflow.js | A promise chain failed to handle a rejection at resource://gre/modules/commonjs/toolkit/loader.js -> resource:///modules/devtools/framework/toolbox.js:901 - TypeError: this.doc is undefined
 0:38.24 TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/framework/test/browser_toolbox_window_reload_target.js | A promise chain failed to handle a rejection - unknownError
 0:38.24 TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/framework/test/browser_toolbox_window_reload_target.js | A promise chain failed to handle a rejection - unknownError
 0:38.28 TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/framework/test/browser_toolbox_window_reload_target.js | A promise chain failed to handle a rejection - unknownError
 0:38.28 TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/framework/test/browser_toolbox_window_reload_target.js | A promise chain failed to handle a rejection - unknownError


The keybinding test is tracked in bug 991075

 0:38.24 TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/framework/test/browser_keybindings.js | A promise chain failed to handle a rejection at resource://gre/modules/commonjs/toolkit/loader.js -> resource:///modules/devtools/framework/toolbox.js:901 - TypeError: this.doc is undefined

Comment 1

[Jordan Santell [:jsantell] [@jsantell]]

Attachment: 1024787-devtools-framework-rejections.patch

Making a new bug (bug 1024789) for the remaining devtools/framework promise failure, as it seems like it may be in a different tool, and much larger than these.

 TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/framework/test/browser_toolbox_window_reload_target.js | A promise chain failed to handle a rejection - unknownError

Comment 2

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8439601 [details] [diff] [review]
1024787-devtools-framework-rejections.patch

Review of attachment 8439601 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/devtools/framework/test/browser_devtools_api.js
@@ -42,4 @@
>      is(toolbox.target, target, "toolbox target is correct");
>      is(toolbox._host.hostTab, gBrowser.selectedTab, "toolbox host is correct");
>      continueTests(toolbox);
> -  }).then(null, console.error);

Why remove this?  Isn't it needed to log any rejections?

@@ -73,2 @@
>      finishUp();
> -  }).then(null, console.error);

Same here.

Comment 3

[Jordan Santell [:jsantell] [@jsantell]]

With the patch in bug 991040 lands, uncaught errors will throw, so we'll see them there (which is why we're fixing these uncaught rejections in bug 	1018184, correct me if I'm misunderstanding)

Comment 4

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

(In reply to Jordan Santell [:jsantell] [@jsantell] from comment #3)
> With the patch in bug 991040 lands, uncaught errors will throw, so we'll see
> them there (which is why we're fixing these uncaught rejections in bug 
> 1018184, correct me if I'm misunderstanding)

Haha, yes, makes sense.  Too late in the day for thinking clearly...

Comment 5

[Jordan Santell [:jsantell] [@jsantell]]

Attachment: 1024787-devtools-framework-rejections.patch

:D

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Do you have a Try link for this by chance? :)

Comment 7

[Jordan Santell [:jsantell] [@jsantell]]

Pushed: https://tbpl.mozilla.org/?tree=Try&rev=517f12a02ea8

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/fx-team/rev/8190adf4e718

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/8190adf4e718