1024848 - [Text Selection] Enable selection carets sanity test on Windows browser

Status: RESOLVED FIXED

(Core :: DOM: Selection, defect)

Description

[Ting-Yu Lin [:TYLin] (PST, UTC-7)]

Long press to select a word has different behavior on Windows. For example, if we have a <input> containing "abc def ghi", long press on the character 'e' selects "def" on Linux. However, on Windows, it selects "def ", i.e. the word "def" with all the spaces afterward.

Comment 1

[Ting-Yu Lin [:TYLin] (PST, UTC-7)]

Attachment: part 1 - Improve selection carets test cases (v1)

On Windows, when selecting a word by long pressing, extra spaces after
the word will also be selected. To solve this problem, I redesign the
test cases by comparing the target content with the selected content
directly while ignoring spaces at certain test cases. I believe it's
easier to understand and less error-prone than the old
replace-selected-content-and-compare way.

I added a new method SelectionManager.selected_content() to make it
easier to get the current selected text.

Comment 2

[Ting-Yu Lin [:TYLin] (PST, UTC-7)]

Attachment: part 2 - Enable selection carets sanity tests on Windows browser (v1)

Try opt (Mnw, Gu, Mn): https://tbpl.mozilla.org/?tree=Try&rev=d40edd0baa7e
Try debug (Mn): https://tbpl.mozilla.org/?tree=Try&rev=5046738b3485

Comment 3

[Malini Das [:mdas] - Away, not checking bugmail]

Comment on attachment 8439801 [details] [diff] [review]
part 2 - Enable selection carets sanity tests on Windows browser (v1)

Review of attachment 8439801 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks so much for these great patches!

Comment 4

[Emanuel Hoogeveen [:ehoogeveen]]

(In reply to Ting-Yu Lin [:TYLin] (UTC+8) from comment #1)
> On Windows, when selecting a word by long pressing, extra spaces after
> the word will also be selected.

I also see double clicks doing this. This behavior seems suboptimal to me (selecting words is pretty useful); is it something we can control?

Comment 5

[Ting-Yu Lin [:TYLin] (PST, UTC-7)]

(In reply to Emanuel Hoogeveen [:ehoogeveen] from comment #4)
> (In reply to Ting-Yu Lin [:TYLin] (UTC+8) from comment #1)
> > On Windows, when selecting a word by long pressing, extra spaces after
> > the word will also be selected.
> 
> I also see double clicks doing this. This behavior seems suboptimal to me
> (selecting words is pretty useful); is it something we can control?

I double click on a word in Notepad, Word, and IE. They all select a word and all the subsequent spaces. I think this is the default behavior on Windows. The only exception I found is Google Chrome (version 35) on Windows. It does not select those spaces after the word.

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b26ccba8deb8
https://hg.mozilla.org/integration/mozilla-inbound/rev/589789cf7bf8

Comment 7

[Ryan VanderMeulen (PTO, back 6-April)]

https://hg.mozilla.org/mozilla-central/rev/b26ccba8deb8
https://hg.mozilla.org/mozilla-central/rev/589789cf7bf8

Comment 8

[Ting-Yu Lin [:TYLin] (PST, UTC-7)]

As Morris Tseng points out, we have a preference "layout.word_select.eat_space_to_next_word" defaults to false but it's overrided to true on Windows in all.js. That's why the word selection behavior is different on Windows.
http://dxr.mozilla.org/mozilla-central/source/modules/libpref/src/init/all.js