1019441 - [Text Selection] Selection carets sanity test

Status: RESOLVED FIXED

(Core :: DOM: Selection, defect)

Description

[u459114]

Create basic test for text selection.
1. editable object/ input/ text area test
   selection range check.
   pref enable/ disable test - no range selected in pref off case.
2. none-editable test
   No range selected on none-editable elements.

Comment 1

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: part 1 - Add SelectionManager in marionette (v1)

* Extract those caret manipulating functions in test_touchcaret.py to
  selection.py, and generalize them for manipulating selection.
* Use SelectionManager in test_touchcaret.py.
* Remove unneeded </input> from test_touchcaret.html.

Comment 2

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: part 2 - Add marionette test cases for selection carets (v1)

Add marionette test cases for selection carets feature in bug 987718.
Test cases target <input>, <textarea>, editable and non-editable
elements.

Run tests on browser manually:
./mach marionette-test layout/base/tests/marionette/test_seletioncarets.py

Run tests on b2g emulator manually:
./mach marionette-webapi layout/base/tests/marionette/test_seletioncarets.py

Try (Mnw, Gu): https://tbpl.mozilla.org/?tree=Try&rev=98009a80781d
Try (Mn): https://tbpl.mozilla.org/?tree=Try&rev=8408d6cb88a4

Comment 3

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Comment on attachment 8436774 [details] [diff] [review]
part 2 - Add marionette test cases for selection carets (v1)

Review of attachment 8436774 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/base/tests/marionette/test_seletioncarets.py
@@ +47,5 @@
> +
> +        # Long press the caret position. Selection carets should appear, and
> +        # select the first word.
> +        self.actions.press(el, x, y).wait(self._long_press_time)
> +        self.actions.release().perform()

Since bug 1020874 is merged, I'll use long_press() on (x, y) in next patch after receiving reviewer's comments.

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 8436774 [details] [diff] [review]
part 2 - Add marionette test cases for selection carets (v1)

Review of attachment 8436774 [details] [diff] [review]:
-----------------------------------------------------------------

rubber-stamp=me. I'm not familiar with marionette tests.

Comment 5

[Malini Das [:mdas] - Away, not checking bugmail]

Comment on attachment 8436774 [details] [diff] [review]
part 2 - Add marionette test cases for selection carets (v1)

Review of attachment 8436774 [details] [diff] [review]:
-----------------------------------------------------------------

looks good! Can the test be renamed to test_selectioncarets.py? There's a missing 'c' in the filename, and manifest.ini should be updated with the new name

Comment 6

[Malini Das [:mdas] - Away, not checking bugmail]

Comment on attachment 8436767 [details] [diff] [review]
part 1 - Add SelectionManager in marionette (v1)

Review of attachment 8436767 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for adding selection.py! Will make peoples' lives easier :)

Comment 7

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

(In reply to Malini Das [:mdas] from comment #5)
> Comment on attachment 8436774 [details] [diff] [review]
> part 2 - Add marionette test cases for selection carets (v1)
> 
> Review of attachment 8436774 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> looks good! Can the test be renamed to test_selectioncarets.py? There's a
> missing 'c' in the filename, and manifest.ini should be updated with the new
> name

Good catch! Will fix it.

Comment 8

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: part 1 - Add SelectionManager in marionette. r=mdas (v2, carry mdas's r+)

Rebased.

Comment 9

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: part 2 - Add marionette test cases for selection carets. r=roc, r=mdas (v2, carry roc and mdas's r+)

* Change file name to test_selectioncaret.py
* Use long_press() on (x, y)

Try opt (Mnw, Gu): https://tbpl.mozilla.org/?tree=Try&rev=96375a3ed1c7
Try debug (Mn): https://tbpl.mozilla.org/?tree=Try&rev=22423b5d1bb4

Comment 10

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: part 2 - Add marionette test cases for selection carets. r=roc, r=mdas (v3, carry roc and mdas's r+)

Fix try server test cases fail.

Try opt (Mnw, Gu): https://tbpl.mozilla.org/?tree=Try&rev=77efdd1e6dc7
Try debug (Mn): https://tbpl.mozilla.org/?tree=Try&rev=3c8398dec653

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/71b8546e8e57
https://hg.mozilla.org/integration/b2g-inbound/rev/82109f618af4

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/71b8546e8e57
https://hg.mozilla.org/mozilla-central/rev/82109f618af4

Comment 13

[Ryan VanderMeulen [:RyanVM]]

Fun times, this test perma-fails on Windows. Not that you would have known that because we only enabled them in production and Try today. But boy was that hilarity-making watching all trunk trees go orange in unison. I've disabled the test on Windows for now. Feel free to green it up and re-enable at your leisure.
https://hg.mozilla.org/mozilla-central/rev/3a81f39bf585

Log:
https://tbpl.mozilla.org/php/getParsedLog.php?id=41621079&tree=Mozilla-Central

Comment 14

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Wow, it's unexpected to see all the tests failed on Windows. I've tried a nightly build on Windows. The root cause is that long press to select a word has different behavior on Windows. For example, if we have a <input> containing "abc def ghi", long press on the character 'e' selects "def" on Linux. However, on Windows, it selects "def ", i.e. the word "def" with all the spaces afterward. That's why the tests went orange.

Ryan, thanks for disabling them on Windows until we find a proper solution.