1026116 - [B2G][2.0][Flame][Vertical Homescreen] Overscrolling is not enabled.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Yeojin Chung [:YeojinC]]

Attachment: logcat_20140616_OpenCtxt

Description:
The icons and search bar do not overscroll when the user flicks up/down twice to enable flywheel scrolling. The overscrolling option on the developer menu is NOT enabled on v.2.0

Pre-requisite: Have multiple (about 30) icons on the homescreen.

Repro Steps:
1) Update a Buri to 20140616063005.
2) Flick up twice to enable flyweel scrolling.
3) Flick down twice to enable flyweel scrolling.
4) Verify that the icons and search bar overscroll. 

Actual:
The search bar at the top of homescreen and the icons at the bottom do NOT overscroll.

Expected:
The search bar and icons at the top and bottom of the screen overscroll when the user enable flywheel scrolling.

Environmental Variables:
Device: Flame 2.0
Build ID: 20140616000203
Gaia: a6988c15b361938bea5976c846c147ecdc1121c0
Gecko: 52a276202888
Version: 32.0a2 (2.0) 
Firmware Version: v121-2
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0 

Notes: Overscrolling on the developer menu is not enabled by default on v.2.0. However, it IS enabled by default on v.2.1.

Repro frequency: 100%
Link to failed test case: https://moztrap.mozilla.org/manage/case/13073/ 
https://moztrap.mozilla.org/manage/case/13074/
See attached: logcat, YouTube link
(Logcat is used on Open C. See https://bugzilla.mozilla.org/show_bug.cgi?id=1010993)

----------------------------------------------------------------------------------------------------
The issue does NOT occur on Flame v.2.1:

Environmental Variables:
Device: Flame 2.1 - Master
Build ID: 20140616040202
Gaia: dfc4703bb81d1fa4f2087a1a6124b47a80a5d1de
Gecko: 80431d4fd0da
Version: 33.0a1 (2.1 - Master) 
Firmware Version: v121-2
User Agent: Mozilla/5.0 (Mobile; rv:33.0) Gecko/33.0 Firefox/33.0

Note: On v.2.1, overscrolling is enabled on the devleoper meny by default.

------------------------------------------------------------------------------------------------------
This issue DOES occur on Open C v.2.0:

Environmental Variables:
Device: Open_C 2.0
Build ID: 20140612000201
Gaia: 2bb66630315299ca947e40fcec23c9f7ea012111
Gecko: 670d69879f0e
Version: 32.0a2 (2.0)
Firmware Version: P821A10V1.0.0B06_LOG_DL
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0
-----------------------------------------------------------------------------------------------------
This issue DOES occur on Buri v.2.0:

Environmental Variables:
Device: Buri 2.0
Build ID: 20140616063005
Gaia: a6988c15b361938bea5976c846c147ecdc1121c0
Gecko: f2413cf1965e
Version: 32.0a2 (2.0) 
Firmware Version: v1.2device.cfg
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Comment 1

[Jason Smith [:jsmith]]

Can UX clarify that this is definitely a bug & not expected behavior?

Comment 2

[Stephany Wilkes]

Flagging Rob on overscroll behavior (though we'll be reviewing this soon).

Comment 3

[Rob MacDonald [:robmac]]

And I'll actually flag Gord on this one. Thanks!

Comment 4

[KTucker [:KTucker][Inactive 3/4/2016]]

You need to leave a comment with your 1.4 environmental variables and the reason why this issue does not occur on 1.4. Also, the 1.4 tracking flag should have been left alone and not changed to unaffected since this is not a regression. The feature didn't exist on 1.4.

Comment 5

[Yeojin Chung [:YeojinC]]

This feature did not exist prior to v.2.0. Unable to verify v.1.4, v.1.3.

This issue DOES occur on Open C v.2.0. The icons and search bar do not overscroll when the user flicks up/down twice to enable flywheel scrolling. 

Environmental Variables:
Device: Open_C 2.0
Build ID: 20140612000201
Gaia: 2bb66630315299ca947e40fcec23c9f7ea012111
Gecko: 670d69879f0e
Version: 32.0a2 (2.0)
Firmware Version: P821A10V1.0.0B06_LOG_DL
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0
-----------------------------------------------------------------------------------------------------
This issue DOES occur on Buri v.2.0. The icons and search bar do not overscroll when the user flicks up/down twice to enable flywheel scrolling. 

Environmental Variables:
Device: Buri 2.0
Build ID: 20140616063005
Gaia: a6988c15b361938bea5976c846c147ecdc1121c0
Gecko: f2413cf1965e
Version: 32.0a2 (2.0) 
Firmware Version: v1.2device.cfg
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Comment 6

[Gordon Brander :gordonb]

This sounds like a bug. I do not have these devices to repro, but overscroll should be enabled.

Comment 7

[Johan Lorenzo [:jlorenzo]]

As per 2.0 vertical homescreen specs, it is a bug (https://bug989848.bugzilla.mozilla.org/attachment.cgi?id=8424225)

Regression window wanted on 2.0 branch.

Comment 8

[Johan Lorenzo [:jlorenzo]]

Marked as 2.0? blocker since it's a regression.

Comment 9

[Kartikaya Gupta (email:[e-mail])]

The gaia patch to enable the pref (see bug 1020045 comment 12) isn't in 2.0. Somebody should uplift that.

Comment 10

[Kartikaya Gupta (email:[e-mail])]

Also, not a regression.

Comment 11

[Kartikaya Gupta (email:[e-mail])]

Attachment: PR that needs uplifting to 2.0

Apparently I can't set approval-gaia-v2.0 on patches that are in bugs that are not in the Gaia component. So we might as well put this bug to good use.

Comment 12

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8441350 [details] [review]
PR that needs uplifting to 2.0

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): new feature
[User impact] if declined: overscroll will not be enabled in 2.0
[Testing completed]: it's enabled on master
[Risk to taking this patch] (and alternatives if risky): low risk, enables a feature that we can easily disable if needed
[String changes made]: none

Comment 13

[Botond Ballo [:botond]]

(In reply to Kartikaya Gupta (email:[e-mail]) from comment #9)
> The gaia patch to enable the pref (see bug 1020045 comment 12) isn't in 2.0.
> Somebody should uplift that.

I did not ask for uplift because I was under the impression that the value in gecko/b2g/chrome/content/settings.js [1], which was flipped in the Gecko patch (which was uplifted), overrides the value in gaia/build/config/common-settings.json. I guess I was wrong. I'm still rather confused about the proliferation of places where the pref value is specified...

I'm not sure how to request uplift of a Gaia patch, but I'm happy to do so if someone points me to how.

[1] http://dxr.mozilla.org/mozilla-central/source/b2g/chrome/content/settings.js#653

Comment 14

[Botond Ballo [:botond]]

(In reply to Botond Ballo [:botond] (away until July 5) from comment #13)
> I'm not sure how to request uplift of a Gaia patch, but I'm happy to do so
> if someone points me to how.

Ah, you've just done it (and now I see how!) - thanks!

Comment 15

[Jason Smith [:jsmith]]

Going to reopen this to track an uplift of the overscrolling patch.

Comment 16

[bhavana bajaj [:bajaj]]

Comment on attachment 8441350 [details] [review]
PR that needs uplifting to 2.0

Johan can you please help with verification once this lands 2.0? Thanks for the help!

Comment 17

[KTucker [:KTucker][Inactive 3/4/2016]]

Please include the environmental variables for the Flame 1.4 and state why the issue did not reproduce even if the feature did not exist.

Comment 18

[Yeojin Chung [:YeojinC]]

This feature did not exist prior to v.2.0. Unable to Reproduce on v.1.4:

Environmental Variables:
Device: Flame 1.4
Build ID: 20140616000202
Gaia: 164644d91290708a71436dfdf4301e33b92e2c77
Gecko: 2949e8bef869
Version: 30.0 (1.4) 
Firmware Version: v121-2
User Agent: Mozilla/5.0 (Mobile; rv:30.0) Gecko/30.0 Firefox/30.0

Comment 19

[Kartikaya Gupta (email:[e-mail])]

This bug doesn't show up in the auto-uplift query [1] unless it is resolved/verified fixed. So I'm going to resolve it.

[1] https://bugzilla.mozilla.org/buglist.cgi?type0-1-0=nowordssubstr&field0-1-0=cf_status_b2g_2_0&field0-0-0=flagtypes.name&resolution=FIXED&query_format=advanced&value0-1-0=fixed%20verified%20unaffected%20wontfix%20disabled&bug_status=RESOLVED&bug_status=VERIFIED&type0-0-0=anywordssubstr&value0-0-0=approval-gaia-v2.0%2B&list_id=10504171

Comment 20

[Kartikaya Gupta (email:[e-mail])]

Actually RyanVM said we can also just set checkin-needed on the bug, which might be clearer in this case.

Comment 21

[Ryan VanderMeulen [:RyanVM]]

Looks like Vivien merged the PR already.
v2.0: https://github.com/mozilla-b2g/gaia/commit/2766e53ec6d4e268128adac6066345f18dcd871b

Comment 22

[Ryan VanderMeulen [:RyanVM]]

(In reply to Ryan VanderMeulen [:RyanVM UTC-4][PTO June 19-22] from comment #21)
> Looks like Vivien merged the PR already.
> v2.0:
> https://github.com/mozilla-b2g/gaia/commit/
> 2766e53ec6d4e268128adac6066345f18dcd871b

Ugh, I'm clearly not caffeinated enough yet today. That was the master landing from bug 1020045.
v2.0: https://github.com/mozilla-b2g/gaia/commit/8e883abdfe32bbbc3934513b4f7cbc0dd7ae3c49

Comment 23

[Johan Lorenzo [:jlorenzo]]

Overscroll is now on 2.0.

Comment 24

[Shally Li（leave from Mozilla）]

Per Comment 23,clear "verifyme".