1026301 - Add eBay logo to search plugin so about:newtab can use it

Status: VERIFIED FIXED

(Firefox :: Search, defect)

Description

[Drew Willcoxon :adw]

Joanne, in bug 1006203 comment 17 you wrote:

(In reply to Joanne Nagel from bug 1006203 comment #17)
> Just found the email from eBay that approved the images that Boriss had
> setup.

Joanne, Borris, does that refer to the images that Boriss posted to bug 962490 comment 34?  If so, I'll land those.

Comment 1

[Drew Willcoxon :adw]

Joanne, please see comment 0.

Comment 2

[Drew Willcoxon :adw]

Borris, please see comment 0.

Comment 3

[Joanne Nagel]

Has this been resolved or do you still  need something from me?

Comment 4

[Jennifer Morrow [:Boriss] (UX)]

(In reply to Joanne Nagel from comment #3)
> Has this been resolved or do you still  need something from me?

If Joanne is happy with the images in bug 1006203 comment #17, then we should feel free to use that.

Comment 5

[Drew Willcoxon :adw]

Attachment: patch

For the record, we verified over email that the answer to comment 0 is Yes.

Comment 6

[Drew Willcoxon :adw]

Marco, could we add this to the current iteration, please?

Comment 7

[Matthew N. [:MattN]]

Comment on attachment 8446000 [details] [diff] [review]
patch

I verified the image and data format.

Comment 8

[Marco Mucci [:MarcoM]]

Added to Iteration 33.2

Comment 9

[Drew Willcoxon :adw]

https://hg.mozilla.org/integration/fx-team/rev/b39fe6bc207b

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/b39fe6bc207b

Comment 11

[Drew Willcoxon :adw]

Comment on attachment 8446000 [details] [diff] [review]
patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #):
Bug 962490 added a search field to about:newtab and landed on 31.  The logo of the currently selected search engine, if available, appears to the left of the search field.

User impact if declined:
When eBay is the currently selected engine, its logo will not appear.  about:newtab gracefully handles missing logos, though.

Testing completed (on m-c, etc.):
manual testing, automated testing on m-c

Risk to taking this patch (and alternatives if risky):
very low

String or IDL/UUID changes made by this patch:
none

Comment 12

[Drew Willcoxon :adw]

Attachment: Beta patch

Bug 1002777 landed on 32 and changed eBay.xml, which made the m-c/Aurora patch not apply cleanly to Beta.

[Approval Request Comment]
Bug caused by (feature/regressing bug #):
Bug 962490 added a search field to about:newtab and landed on 31.  The logo of the currently selected search engine, if available, appears to the left of the search field.

User impact if declined:
When eBay is the currently selected engine, its logo will not appear.  about:newtab gracefully handles missing logos, though.

Testing completed (on m-c, etc.):
manual testing, automated testing on m-c

Risk to taking this patch (and alternatives if risky):
very low

String or IDL/UUID changes made by this patch:
none

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/3e7cf911402c
https://hg.mozilla.org/releases/mozilla-beta/rev/75427ba01d8f

Comment 14

[Petruta Horea [:phorea], Desktop QA]

Verified that the eBay logo is correctly displayed on Firefox 31 beta 6, Aurora 32.0a2 and Nightly 33.0a1 2014-06-29 on about:newtab page under Win 7 64-bit, Ubutnu 12.10 32-bit and Mac OSX 10.9.3