1026694 - Access to attach button

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect)

Comment 1

[Julien Wajsberg [:julienw]]

Note that this was how it was designed in v1.1 and was changed somewhen in v1.3 (bug 923023). We'll eventually need to settle.

Needs UX but really need VD before being actionable.

Comment 2

[Victoria Gerchinhoren [:vicky]]

This is being worked on from VD. Will provide visuals soon but there's some work still remaining to solve the spacing left for the text input area when saving space for the button.

Not clearing NI as reminder. 

Remember all mockups and specs will be provided in a 2.1 messaging metabug where all changes related to this app should be gathered.

Comment 3

[Jenny Lee]

I'm ok with moving the attachment button to composer area. If that's what we are planning to do, I suggest we pull out the "call contact" function and place it on header (when there's only one recipient). Tks ;)

Comment 4

[Jenny Lee]

Attachment: [2.1 Message] Access to attach button v1.0.pdf

Hello, please see attached for the spec. Thanks!

Comment 5

[Victoria Gerchinhoren [:vicky]]

Attachment: Visual Mockup. SMMS_compose_0000_01.png

Comment 6

[Victoria Gerchinhoren [:vicky]]

Attachment: Visual Mockup. SMMS_compose_0001_02.png

Comment 7

[Victoria Gerchinhoren [:vicky]]

Attachment: Visual Mockup. SMMS_compose_0004_invalid_field.png

Comment 8

[Victoria Gerchinhoren [:vicky]]

Attachment: Visual Mockup. SMMS_compose_0003_Longmessage.png

Comment 9

[Victoria Gerchinhoren [:vicky]]

Attachment: Visual Spec. Compose

Comment 10

[Victoria Gerchinhoren [:vicky]]

Find attached visuals and specs for implementing the attachment icon new placing.

Cheers.
V

Comment 11

[Julien Wajsberg [:julienw]]

Manuel, please note we took this in our sprint, this means we think the SMS team can handle this. So feel free to work on another work if you have some.

Comment 12

[Oleg Zasypkin [:azasypkin]]

Hey Fang,

Could you please provide us with the right image assets (1@x, @1.5x, @2x, @2.25x) for the new attachment button? 

Currently we have a white icon, but per spec color has changed + we didn't have @2x version for some reason.

Thanks!

Comment 13

[Fang Shih [:fang]]

Attachment: sms_icon_attachment .zip

Attached the new attachment icon at 1x 1.5x 2x 2.25x.

Comment 14

[Oleg Zasypkin [:azasypkin]]

(In reply to Fang Shih from comment #13)
> Created attachment 8462325 [details]
> sms_icon_attachment .zip
> 
> Attached the new attachment icon at 1x 1.5x 2x 2.25x.

Thanks Fang!

Comment 15

[Oleg Zasypkin [:azasypkin]]

Setting dependency on bug 1043518 as patch for this bug based on the latest master is impossible to verify in full.

Comment 16

[Oleg Zasypkin [:azasypkin]]

Attachment: GitHub pull request URL

Comment 17

[Oleg Zasypkin [:azasypkin]]

Comment on attachment 8462753 [details] [review]
GitHub pull request URL

Hi Steve,

Here is the patch with attachment button VR. Could you please review it?

Thanks!

Comment 18

[Steve Chung [:steveck]]

Comment on attachment 8462753 [details] [review]
GitHub pull request URL

Patch looks fine, but the unit test seems broken in composer test after applied it. Could you please investigate the root cause?

Comment 19

[Oleg Zasypkin [:azasypkin]]

Comment on attachment 8462753 [details] [review]
GitHub pull request URL

(In reply to Steve Chung [:steveck] from comment #18)
> Comment on attachment 8462753 [details] [review]
> GitHub pull request URL
> 
> Patch looks fine, but the unit test seems broken in composer test after
> applied it. Could you please investigate the root cause?

Thanks for review! I've added "type=button" to the add attachment button element, so tests should be fine now.

Comment 20

[Steve Chung [:steveck]]

Comment on attachment 8462753 [details] [review]
GitHub pull request URL

Just one nit, so r=me :)

Comment 21

[Oleg Zasypkin [:azasypkin]]

Master: https://github.com/mozilla-b2g/gaia/commit/29b480349511a56f82eb53e2e82d28f7b98f518b

Comment 22

[Alison Shiue]

Hi Oleg,

I do not see the change of call button on header for single recipient when I tried on

Gaia      5fd14b8bc428f87f9b5cf9cc49f9a4f362a970fb
Gecko     https://hg.mozilla.org/mozilla-central/rev/e6614d8d85f9
BuildID   20140803160202
Version   34.0a1

We should expect the change at this user story since the spec is defined on UX doc, right?

Comment 23

[Oleg Zasypkin [:azasypkin]]

(In reply to ashiue from comment #22)
> Hi Oleg,
> 
> I do not see the change of call button on header for single recipient when I
> tried on
> 
> Gaia      5fd14b8bc428f87f9b5cf9cc49f9a4f362a970fb
> Gecko     https://hg.mozilla.org/mozilla-central/rev/e6614d8d85f9
> BuildID   20140803160202
> Version   34.0a1
> 
> We should expect the change at this user story since the spec is defined on
> UX doc, right?

Hi Alison,

Thanks for noticing! This bug was only about attachment button, but I've just filed a separate bug 1048717 for the "Call" button too.

Thanks!

Comment 24

[Loli (:lolimartinezcr)]

Tested and working
Flame
2.1
Gecko-329b2e4
Gaia-d688d4f

Comment 25

[Eric Chang [:ericcc] [:echang]]

[Comms][Messages]Small set
https://moztrap.mozilla.org/manage/suites/?pagenumber=1&pagesize=20&sortfield=created_on&sortdirection=desc&filter-name=%5Bcomms%5D&filter-name=messages&filter-name=small