1027633 - Overscrolling the music list compresses towards the left edge instead of towards the middle of the list

Status: RESOLVED FIXED

(Core :: Panning and Zooming, defect)

Description

[Chris Lord [:cwiiis]]

If you overscroll the list of songs in the music player, the effect causes it to compress towards the edge of the screen instead of compressing to the middle like it does elsewhere.

I imagine this is a side-effect of the layout of the music app, but filing this bug against apz for now for investigation.

Video: https://www.dropbox.com/s/22s1awk7pjq8uvb/VID_0001.3gp

Comment 1

[Kartikaya Gupta (email:[e-mail])]

I took a quick look at the music player layout in the app manager. I think this is a result of overscroll not playing well with CSS transforms. When you are in one of the tabs other than the "tiles" tab (which is the leftmost icon in the bottom row of tabs) then there is a transform:translateX(-100%) applied to one of the parent divs (div id="views"). That is probably what is throwing off the overscroll.

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Unsure if this affects 2.0 (although it probably does). This should be a blocker, I think.

Comment 4

[Milan Sreckovic [:milan] (needinfo for best results)]

We should fix this, and if the fix is simple enough, do the uplift to 2.0.  I don't see it blocking the release though, not even 2.1.

Comment 5

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: bug1027633.patch

Simple css fix. Wilson let me know if it has side effects.

Comment 6

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

https://tbpl.mozilla.org/?tree=Gaia-Try&rev=0c71cd6aec33448f7b3180bf090b781ccfce82a2

Comment 7

[Milan Sreckovic [:milan] (needinfo for best results)]

Thanks Vivien; if this works, lets make sure we ask for the uplift and get this into 2.0/Aurora

Comment 8

[Kartikaya Gupta (email:[e-mail])]

Please make sure to also file a follow-up bug to fix this on the platform side, and have it block bug 1020045. I don't think there's any other bug tracking this issue at the moment.

Comment 9

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to Kartikaya Gupta (email:[e-mail]) from comment #8)
> Please make sure to also file a follow-up bug to fix this on the platform
> side, and have it block bug 1020045. I don't think there's any other bug
> tracking this issue at the moment.

Will do for sure.

Comment 10

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 8447135 [details] [diff] [review]
bug1027633.patch

Carrying squib r+.

I navigated around in the app and everything seems to works fine for me.

Comment 11

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

https://github.com/mozilla-b2g/gaia/commit/b34cc7bf7c4c6d22191cc7010be4ae3442e9a8d7

Comment 12

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Will open the followup soon.

Comment 13

[Botond Ballo [:botond]]

I un-applied the Gaia fix on master and retested this, and could not reproduce the issue.

I suspect, based on the description of the problem, that the underlying platform issue was bug 1035598, which has since been fixed.

In any case, there is no need to file another bug (as requested in comment 8) now.